Skip to content

[feat](checker) Add tablet stats key consistency checking for checker #54754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gavinchou merged 5 commits into from
Sep 4, 2025
Merged

[feat](checker) Add tablet stats key consistency checking for checker #54754

gavinchou merged 5 commits into from
Sep 4, 2025

Conversation

@wyxxxcat
Copy link
Contributor

@wyxxxcat wyxxxcat commented Aug 14, 2025 •
edited
Loading

What problem does this PR solve?

  1. add tablet stats key checking, check if it exists and it match the rowset info
  2. add related cases

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 14, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat wyxxxcat marked this pull request as ready for review August 14, 2025 09:52
@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Aug 14, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Aug 14, 2025

Cloud UT Coverage Report

Increment line coverage 69.57% (144/207) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 84.03% (1447/1722)
Line Coverage 67.30% (24980/37118)
Region Coverage 68.35% (12379/18110)
Branch Coverage 57.93% (6513/11242)

@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Aug 16, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 16, 2025

Cloud UT Coverage Report

Increment line coverage 69.57% (144/207) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 84.03% (1447/1722)
Line Coverage 67.31% (25056/37224)
Region Coverage 68.30% (12388/18138)
Branch Coverage 57.90% (6522/11264)

gavinchou
gavinchou reviewed Aug 20, 2025
View reviewed changes
gavinchou
gavinchou reviewed Aug 20, 2025
View reviewed changes
@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Aug 25, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 25, 2025

Cloud UT Coverage Report

Increment line coverage 74.38% (180/242) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.70% (1427/1705)
Line Coverage 67.08% (25461/37958)
Region Coverage 68.17% (12665/18578)
Branch Coverage 57.95% (6711/11580)

dataroaring
dataroaring approved these changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

PR approved by anyone and no changes requested.

@gavinchou gavinchou merged commit ec44981 into apache:master Sep 4, 2025
28 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 4, 2025
@wyxxxcat
[feat](checker) Add tablet stats key consistency checking for checker (…
f7f995b 
…#54754)

1. add tablet stats key checking, check if it exists and it match the
rowset info
2. add related cases
@github-actions github-actions bot mentioned this pull request Sep 4, 2025
Merged
morrySnow pushed a commit that referenced this pull request Sep 5, 2025
@github-actions @wyxxxcat
branch-3.1: [feat](checker) Add tablet stats key consistency checking…
d6932ab 
… for checker #54754 (#55663)

Cherry-picked from #54754

Co-authored-by: Uniqueyou <wangyixuan@selectdb.com>
wenzhenghu pushed a commit to wenzhenghu/doris that referenced this pull request Sep 8, 2025
@wyxxxcat @wenzhenghu
[feat](checker) Add tablet stats key consistency checking for checker (…
02aedbb 
…apache#54754)

1. add tablet stats key checking, check if it exists and it match the
rowset info
2. add related cases
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

@w41ter w41ter Awaiting requested review from w41ter w41ter is a code owner

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@wyxxxcat @hello-stephen @doris-robot @gavinchou @dataroaring @morrySnow