Skip to content

branch-3.0:[enhance](auth)support ldap user show grants (#54087) #54765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Sep 5, 2025
Merged

branch-3.0:[enhance](auth)support ldap user show grants (#54087) #54765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions fe/fe-core/src/main/java/org/apache/doris/analysis/ShowGrantsStmt.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,16 +80,17 @@ public void analyze(Analyzer analyzer) throws AnalysisException {
userIdent = ConnectContext.get().getCurrentUserIdentity();
}
}
boolean isSelf = userIdent != null && ConnectContext.get().getCurrentUserIdentity().equals(userIdent);
Preconditions.checkState(isAll || userIdent != null);
UserIdentity self = ConnectContext.get().getCurrentUserIdentity();

// if show all grants, or show other user's grants, need global GRANT priv.
if (isAll || !self.equals(userIdent)) {
if (isAll || !isSelf) {
if (!Env.getCurrentEnv().getAccessManager().checkGlobalPriv(ConnectContext.get(), PrivPredicate.GRANT)) {
ErrorReport.reportAnalysisException(ErrorCode.ERR_SPECIFIC_ACCESS_DENIED_ERROR, "GRANT");
}
}
if (userIdent != null && !Env.getCurrentEnv().getAccessManager().getAuth().doesUserExist(userIdent)) {
// ldap user not exist in userManager, so should not check
if (userIdent != null && !isSelf && !Env.getCurrentEnv().getAccessManager().getAuth()
.doesUserExist(userIdent)) {
throw new AnalysisException(String.format("User: %s does not exist", userIdent));
}
}
Expand Down