[fix](nereids) fix execute err which throw eq function not exist exception when join reorder #54953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33609 ms |
TPC-DS: Total hot run time: 184376 ms |
ClickBench: Total hot run time: 32.97 s |
morrySnow
reviewed
Aug 19, 2025
| } | ||
|
|
||
| return newJoin; | ||
| return JoinUtils.adjustJoinConjunctsNullable(newJoin); |
Contributor
There was a problem hiding this comment.
should only process if the subplan contains outer join?
morrySnow
reviewed
Aug 19, 2025
| Map<Slot, Slot> childSlotMap = new HashMap<>(); | ||
| for (Plan child : join.children()) { | ||
| for (Slot slot : child.getOutput()) { | ||
| childSlotMap.put(slot, slot); |
Contributor
There was a problem hiding this comment.
should not replace directly, generate a new slot with correct nullable is better, could reuse or refer to fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/AdjustNullable.java
Contributor
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
TPC-H: Total hot run time: 34571 ms |
TPC-DS: Total hot run time: 184971 ms |
ClickBench: Total hot run time: 33.39 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34147 ms |
TPC-DS: Total hot run time: 184779 ms |
ClickBench: Total hot run time: 32.44 s |
yujun777
reviewed
Aug 21, 2025
| } | ||
|
|
||
| if (newJoin.getJoinType().isOuterJoin()) { | ||
| return JoinUtils.adjustJoinConjunctsNullable(newJoin); |
Contributor
There was a problem hiding this comment.
let newJoin = JoinUtils.adjustJoinConjunctsNullable(newJoin) ?
yujun777
reviewed
Aug 21, 2025
| /** | ||
| * Adjust nullable attribute of slot reference in expression. | ||
| */ | ||
| public static Expression doUpdateExpression(AtomicBoolean changed, Expression input, |
Contributor
There was a problem hiding this comment.
if doUpdateExpression make public, maybe we can remove the arg changed and return Optinal to indicate whether have changed ? what's more, combine the arg debugCheck and isAnalyzedPhase into one: needCheck, then when AdjustNullable call doUpdateExpression, needCheck = debugCheck && !isAnalyzedPhase, when JsonUtils call doUpdateExpression , let needCheck = false ?
yujun777
reviewed
Aug 21, 2025
| * if the join change to '(b left join c) right a where b.condition > 1', | ||
| * the nullable property of b.condition should be false | ||
| */ | ||
| public static LogicalJoin<Plan, Plan> adjustJoinConjunctsNullable(LogicalJoin<Plan, Plan> join) { |
Contributor
There was a problem hiding this comment.
the logical should be like AdjustNullable.visitLogicalJoin, but here forget to update mark join conditions. maybe can reconstruct AdjustNullable.visitLogicalJoin, and expose a public function AdjustNullable.adjustJoinNullableWithReplaceSlots(join, replaceMap)
…ption when join reorder
…ption when join reorder
seawinde
force-pushed
the
fix_join_condition_query_eq_err
branch
from
49aa1e7 to
11084de
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34062 ms |
TPC-DS: Total hot run time: 184650 ms |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34227 ms |
TPC-DS: Total hot run time: 187574 ms |
ClickBench: Total hot run time: 32.79 s |
Contributor
|
PR approved by anyone and no changes requested. |
starocean999
approved these changes
Aug 29, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
github-actions bot
pushed a commit
that referenced
this pull request
Sep 4, 2025
…ption when join reorder (#54953) ### What problem does this PR solve? if query as following: select xx from a left join b on a.id = b.id left join c on b.id = c.id the column in table a, b, c are all non nullable. after join reorder the query is as following: select xx from b left join c on b.id = c.id right join a on on a.id = b.id the the nullable condition in join conjuncts maybe nullable wrongly. this would cause be exec fail with err msg `[INTERNAL_ERROR]Could not find function eq, arg String return Nullable(BOOL) ` the pr fix this
wenzhenghu
pushed a commit
to wenzhenghu/doris
that referenced
this pull request
Sep 8, 2025
…ption when join reorder (apache#54953) ### What problem does this PR solve? if query as following: select xx from a left join b on a.id = b.id left join c on b.id = c.id the column in table a, b, c are all non nullable. after join reorder the query is as following: select xx from b left join c on b.id = c.id right join a on on a.id = b.id the the nullable condition in join conjuncts maybe nullable wrongly. this would cause be exec fail with err msg `[INTERNAL_ERROR]Could not find function eq, arg String return Nullable(BOOL) ` the pr fix this
Closed
yiguolei
pushed a commit
to yiguolei/incubator-doris
that referenced
this pull request
Dec 30, 2025
…t exist exception when join reorder apache#54953 (apache#5643) commitId: selectdb/selectdb-core@fb26e43 pr: apache#54953
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
if query as following:
the column in table a, b, c are all non nullable.
after join reorder the query is as following:
the the nullable condition in join conjuncts maybe nullable wrongly.
this would cause be exec fail with err msg
[INTERNAL_ERROR]Could not find function eq, arg String return Nullable(BOOL)the pr fix this
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)