Skip to content

[test](plugin) trigger_and_wait_compaction should check cloud mode #55078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hello-stephen merged 1 commit into from
Aug 21, 2025
+3 −4
Merged

[test](plugin) trigger_and_wait_compaction should check cloud mode #55078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions regression-test/plugins/plugin_compaction.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ Suite.metaClass.trigger_and_wait_compaction = { String table_name, String compac
// running is true means compaction is still running
running = compactionStatus.run_status

if (!isCloudMode() && !is_time_series_compaction) {
if (!is_time_series_compaction) {
(exit_code, stdout, stderr) = be_show_tablet_status(be_host, be_port, tablet.TabletId)
assert exit_code == 0: "get tablet status failed, exit code: ${exit_code}, stdout: ${stdout}, stderr: ${stderr}"
def tabletStatus = parseJson(stdout.trim())
Expand All @@ -144,9 +144,8 @@ Suite.metaClass.trigger_and_wait_compaction = { String table_name, String compac
return false
}
} else {
// 1. cloud mode doesn't show compaction success time in tablet status for the time being,
// 2. time series compaction sometimes doesn't update compaction success time
// so we solely check run_status for these two cases
// time series compaction sometimes doesn't update compaction success time
// so we solely check run_status for it
if (running) {
logger.info("compaction is still running, be host: ${be_host}, tablet id: ${tablet.TabletId}")
return false
Expand Down