-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[enhance](variant)enhance max_sparse_column_statistics_size for variant #55124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
FE UT Coverage ReportIncrement line coverage |
|
run buildall |
TPC-H: Total hot run time: 33610 ms |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-DS: Total hot run time: 183771 ms |
ClickBench: Total hot run time: 33.23 s |
be/src/olap/rowset/segment_v2/variant/variant_column_reader.cpp
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/nereids/types/VariantType.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/nereids/types/VariantType.java
Outdated
Show resolved
Hide resolved
...st/java/org/apache/doris/nereids/trees/expressions/functions/ComputeSignatureHelperTest.java
Outdated
Show resolved
Hide resolved
FE UT Coverage ReportIncrement line coverage |
fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java
Outdated
Show resolved
Hide resolved
regression-test/suites/fault_injection_p0/test_variant_compaction_with_sparse_limit.groovy
Show resolved
Hide resolved
regression-test/suites/variant_p0/predefine/test_variant_compaction_with_sparse_limit.groovy
Show resolved
Hide resolved
|
run buildall |
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
FE UT Coverage ReportIncrement line coverage |
TPC-H: Total hot run time: 33991 ms |
TPC-DS: Total hot run time: 184188 ms |
ClickBench: Total hot run time: 33.44 s |
be/src/olap/rowset/segment_v2/variant/variant_column_reader.cpp
Outdated
Show resolved
Hide resolved
TPC-DS: Total hot run time: 187714 ms |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
ClickBench: Total hot run time: 32.73 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
eldenmoon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
TPC-H: Total hot run time: 34310 ms |
TPC-DS: Total hot run time: 186483 ms |
ClickBench: Total hot run time: 33.53 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
|
run p0 5 |
…nt (apache#55124) delete be config for max_sparse_column_statistics_size and add it for variant properties
…nt (apache#55124) delete be config for max_sparse_column_statistics_size and add it for variant properties
What problem does this PR solve?
delete be config for max_sparse_column_statistics_size
and add it for variant properties
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)