-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](variant) compaction compatible with both the old and new versions of variant. #55127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 34093 ms |
TPC-DS: Total hot run time: 184488 ms |
ClickBench: Total hot run time: 32.25 s |
FE UT Coverage ReportIncrement line coverage |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
regression-test/suites/variant_p0/predefine/variant_count_zero_predefine.groovy
Outdated
Show resolved
Hide resolved
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
b91a7d4 to
a815efe
Compare
|
run buildall |
TPC-H: Total hot run time: 34790 ms |
TPC-DS: Total hot run time: 184781 ms |
ClickBench: Total hot run time: 32.27 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
a815efe to
beda439
Compare
|
run buildall |
TPC-H: Total hot run time: 34035 ms |
TPC-DS: Total hot run time: 184716 ms |
ClickBench: Total hot run time: 32.9 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
beda439 to
38d730d
Compare
|
run buildall |
TPC-H: Total hot run time: 34049 ms |
TPC-DS: Total hot run time: 185490 ms |
ClickBench: Total hot run time: 32.19 s |
38d730d to
67d658e
Compare
|
run buildall |
TPC-H: Total hot run time: 34354 ms |
TPC-DS: Total hot run time: 187387 ms |
ClickBench: Total hot run time: 32.61 s |
FE UT Coverage ReportIncrement line coverage |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
eldenmoon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
67d658e to
5e7e538
Compare
|
run buildall |
TPC-H: Total hot run time: 34245 ms |
TPC-DS: Total hot run time: 186334 ms |
ClickBench: Total hot run time: 32.35 s |
FE UT Coverage ReportIncrement line coverage |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
|
run p0 5 |
amorynan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ns of variant. (apache#55127) 1. In the old version of variant, the path size of subcolumns was not recorded, so the data type in the segment footer was used to calculate the schema during compaction.
What problem does this PR solve?
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)