Skip to content

[fix](nereids)fix some show command's redirect policy #55185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
starocean999 merged 1 commit into from
Oct 14, 2025
Merged

[fix](nereids)fix some show command's redirect policy #55185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...e-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/ShowBackupCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

package org.apache.doris.nereids.trees.plans.commands;

import org.apache.doris.analysis.RedirectStatus;
import org.apache.doris.backup.AbstractJob;
import org.apache.doris.backup.BackupJob;
import org.apache.doris.catalog.Column;
Expand Down Expand Up @@ -187,4 +188,9 @@ public ShowResultSet doRun(ConnectContext ctx, StmtExecutor executor) throws Exc
public <R, C> R accept(PlanVisitor<R, C> visitor, C context) {
return visitor.visitShowBackupCommand(this, context);
}

@Override
public RedirectStatus toRedirectStatus() {
return RedirectStatus.FORWARD_NO_SYNC;
}
}
14 changes: 14 additions & 0 deletions ...e-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/ShowConfigCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

package org.apache.doris.nereids.trees.plans.commands;

import org.apache.doris.analysis.RedirectStatus;
import org.apache.doris.catalog.Column;
import org.apache.doris.catalog.Env;
import org.apache.doris.catalog.ScalarType;
Expand Down Expand Up @@ -177,4 +178,17 @@ public void run(ConnectContext ctx, StmtExecutor executor) throws Exception {
public <R, C> R accept(PlanVisitor<R, C> visitor, C context) {
return visitor.visitShowConfigCommand(this, context);
}

@Override
public RedirectStatus toRedirectStatus() {
// no need forward to master for backend config
if (nodeType == NodeType.BACKEND) {
return RedirectStatus.NO_FORWARD;
}
if (ConnectContext.get().getSessionVariable().getForwardToMaster()) {
return RedirectStatus.FORWARD_NO_SYNC;
} else {
return RedirectStatus.NO_FORWARD;
}
}
}
6 changes: 6 additions & 0 deletions ...-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/ShowRestoreCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

package org.apache.doris.nereids.trees.plans.commands;

import org.apache.doris.analysis.RedirectStatus;
import org.apache.doris.backup.AbstractJob;
import org.apache.doris.backup.RestoreJob;
import org.apache.doris.catalog.Column;
Expand Down Expand Up @@ -211,4 +212,9 @@ public <R, C> R accept(PlanVisitor<R, C> visitor, C context) {
return visitor.visitShowRestoreCommand(this, context);
}

@Override
public RedirectStatus toRedirectStatus() {
return RedirectStatus.FORWARD_NO_SYNC;
}

}
10 changes: 10 additions & 0 deletions ...rc/main/java/org/apache/doris/nereids/trees/plans/commands/ShowWorkloadGroupsCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

package org.apache.doris.nereids.trees.plans.commands;

import org.apache.doris.analysis.RedirectStatus;
import org.apache.doris.catalog.Column;
import org.apache.doris.catalog.Env;
import org.apache.doris.catalog.ScalarType;
Expand Down Expand Up @@ -87,4 +88,13 @@ public String toSql() {
public String toString() {
return toSql();
}

@Override
public RedirectStatus toRedirectStatus() {
if (ConnectContext.get().getSessionVariable().getForwardToMaster()) {
return RedirectStatus.FORWARD_NO_SYNC;
} else {
return RedirectStatus.NO_FORWARD;
}
}
}
Loading