Skip to content

Conversation

@zhiqiang-hhhh
Copy link
Contributor

What problem does this PR solve?

Some expression can not handle empty block, such as function element_at.
So materialize virtual column in advance to avoid errors.

Related PR: #52701

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34037 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 83bdf8b841e821a541d4d34feeaf204b5ff7114e, data reload: false

------ Round 1 ----------------------------------
q1	17612	5218	5115	5115
q2	1937	283	192	192
q3	10319	1281	691	691
q4	10219	1027	524	524
q5	7532	2348	2347	2347
q6	173	159	133	133
q7	892	732	610	610
q8	9304	1301	1158	1158
q9	6887	5101	5410	5101
q10	6877	2406	1960	1960
q11	468	297	264	264
q12	347	359	219	219
q13	17746	3635	3050	3050
q14	237	247	217	217
q15	560	484	502	484
q16	427	417	390	390
q17	593	861	367	367
q18	7415	7083	7044	7044
q19	1243	940	563	563
q20	355	352	224	224
q21	4005	3219	2413	2413
q22	1069	1013	971	971
Total cold run time: 106217 ms
Total hot run time: 34037 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5200	5147	5148	5147
q2	245	326	223	223
q3	2201	2718	2305	2305
q4	1357	1790	1365	1365
q5	4227	4631	4572	4572
q6	219	172	133	133
q7	2068	1969	1846	1846
q8	2673	2779	2711	2711
q9	7370	7375	7292	7292
q10	3152	3274	2885	2885
q11	583	516	494	494
q12	735	799	645	645
q13	3853	3993	3320	3320
q14	305	350	303	303
q15	541	486	477	477
q16	471	481	462	462
q17	1228	1608	1397	1397
q18	8017	7726	7715	7715
q19	858	841	864	841
q20	2057	2053	1909	1909
q21	4983	4318	4385	4318
q22	1094	1039	1008	1008
Total cold run time: 53437 ms
Total hot run time: 51368 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184199 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 83bdf8b841e821a541d4d34feeaf204b5ff7114e, data reload: false

query1	991	416	420	416
query2	6512	1785	1760	1760
query3	6752	223	220	220
query4	26235	23484	23014	23014
query5	4351	630	483	483
query6	339	219	215	215
query7	4633	503	295	295
query8	283	237	216	216
query9	8616	2897	2877	2877
query10	489	326	308	308
query11	15622	14950	14625	14625
query12	161	112	118	112
query13	1669	553	431	431
query14	8564	5771	5714	5714
query15	211	187	166	166
query16	7201	636	468	468
query17	1188	708	573	573
query18	1968	401	306	306
query19	185	182	158	158
query20	124	122	147	122
query21	214	122	106	106
query22	4014	4090	3995	3995
query23	33812	32879	32794	32794
query24	8095	2319	2346	2319
query25	542	466	414	414
query26	1239	268	160	160
query27	2754	502	353	353
query28	4366	2284	2236	2236
query29	773	558	452	452
query30	288	216	189	189
query31	862	800	702	702
query32	87	75	80	75
query33	568	368	373	368
query34	789	851	512	512
query35	779	813	753	753
query36	963	1017	913	913
query37	120	108	90	90
query38	4054	4024	3971	3971
query39	1571	1498	1425	1425
query40	223	126	114	114
query41	59	56	54	54
query42	122	109	109	109
query43	489	511	480	480
query44	1349	863	855	855
query45	176	182	165	165
query46	866	1018	645	645
query47	1746	1809	1729	1729
query48	412	420	312	312
query49	706	489	391	391
query50	643	693	391	391
query51	4146	4095	4144	4095
query52	106	116	103	103
query53	240	262	200	200
query54	586	605	530	530
query55	91	91	87	87
query56	312	304	308	304
query57	1168	1178	1146	1146
query58	277	270	269	269
query59	2655	2725	2563	2563
query60	339	333	319	319
query61	147	124	121	121
query62	829	727	667	667
query63	225	188	190	188
query64	4369	1048	682	682
query65	4322	4204	4209	4204
query66	1158	415	336	336
query67	15479	15203	14967	14967
query68	7982	964	575	575
query69	499	321	296	296
query70	1192	1210	1163	1163
query71	407	341	310	310
query72	5561	4699	4632	4632
query73	706	597	359	359
query74	9259	9039	8849	8849
query75	3183	3078	2651	2651
query76	3212	1134	730	730
query77	501	409	322	322
query78	9583	9487	8880	8880
query79	2489	839	608	608
query80	595	533	470	470
query81	508	252	219	219
query82	486	138	104	104
query83	256	250	233	233
query84	260	107	78	78
query85	813	374	339	339
query86	390	303	306	303
query87	4327	4288	4183	4183
query88	3749	2236	2204	2204
query89	394	325	295	295
query90	1877	221	221	221
query91	144	150	112	112
query92	82	70	66	66
query93	1902	984	645	645
query94	732	402	308	308
query95	395	327	308	308
query96	492	571	279	279
query97	2596	2690	2600	2600
query98	262	230	217	217
query99	1652	1422	1308	1308
Total cold run time: 271710 ms
Total hot run time: 184199 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.43 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 83bdf8b841e821a541d4d34feeaf204b5ff7114e, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.24	0.07	0.08
query4	1.62	0.11	0.11
query5	0.43	0.43	0.42
query6	1.18	0.63	0.66
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.59	0.53	0.51
query10	0.56	0.55	0.57
query11	0.17	0.11	0.11
query12	0.15	0.12	0.11
query13	0.62	0.61	0.62
query14	0.78	0.86	0.84
query15	0.86	0.85	0.85
query16	0.38	0.39	0.39
query17	1.04	1.04	1.04
query18	0.21	0.20	0.19
query19	1.99	1.82	1.82
query20	0.02	0.01	0.01
query21	15.44	0.94	0.60
query22	0.79	1.06	0.70
query23	14.99	1.33	0.60
query24	6.56	1.73	0.68
query25	0.48	0.20	0.09
query26	0.58	0.16	0.12
query27	0.06	0.06	0.05
query28	9.58	0.95	0.44
query29	12.54	3.91	3.24
query30	3.09	3.03	3.04
query31	2.81	0.58	0.40
query32	3.24	0.55	0.47
query33	3.01	3.09	3.07
query34	15.98	5.46	4.88
query35	4.93	4.85	4.93
query36	0.70	0.52	0.49
query37	0.10	0.07	0.07
query38	0.06	0.04	0.03
query39	0.03	0.03	0.02
query40	0.18	0.14	0.14
query41	0.08	0.03	0.03
query42	0.04	0.02	0.03
query43	0.03	0.03	0.03
Total cold run time: 106.33 s
Total hot run time: 32.43 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 50.00% (4/8) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 51.79% (17149/33115)
Line Coverage 37.26% (156264/419361)
Region Coverage 31.96% (119160/372791)
Branch Coverage 33.25% (52359/157466)

@zhiqiang-hhhh
Copy link
Contributor Author

run external

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Aug 27, 2025
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (8/8) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 70.73% (23010/32533)
Line Coverage 56.95% (238767/419251)
Region Coverage 52.30% (197862/378337)
Branch Coverage 54.00% (85571/158464)

Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (8/8) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 70.73% (23010/32533)
Line Coverage 56.96% (238790/419251)
Region Coverage 52.30% (197870/378337)
Branch Coverage 54.01% (85587/158464)

@BiteTheDDDDt BiteTheDDDDt merged commit e6f6845 into apache:master Aug 28, 2025
27 of 30 checks passed
@zhiqiang-hhhh zhiqiang-hhhh deleted the fix-virtual branch August 29, 2025 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants