Skip to content

[opt](mow) do not capture stack to reduce cpu #55368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 2 commits into from
Aug 29, 2025
Merged

[opt](mow) do not capture stack to reduce cpu #55368

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c6a459
[opt](mow) do not capture stack to reduce cpu
Aug 27, 2025
f350718
fix
Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions be/src/olap/rowset/segment_v2/segment.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,7 +834,7 @@ Status Segment::lookup_row_key(const Slice& key, const TabletSchema* latest_sche

DCHECK(_pk_index_reader != nullptr);
if (!_pk_index_reader->check_present(key_without_seq)) {
return Status::Error<ErrorCode::KEY_NOT_FOUND>("Can't find key in the segment");
return Status::Error<ErrorCode::KEY_NOT_FOUND, false>("");
}
bool exact_match = false;
std::unique_ptr<segment_v2::IndexedColumnIterator> index_iterator;
Expand All @@ -844,7 +844,7 @@ Status Segment::lookup_row_key(const Slice& key, const TabletSchema* latest_sche
return st;
}
if (st.is<ErrorCode::ENTRY_NOT_FOUND>() || (!has_seq_col && !has_rowid && !exact_match)) {
return Status::Error<ErrorCode::KEY_NOT_FOUND>("Can't find key in the segment");
return Status::Error<ErrorCode::KEY_NOT_FOUND, false>("");
}
row_location->row_id = cast_set<uint32_t>(index_iterator->get_current_ordinal());
row_location->segment_id = _segment_id;
Expand All @@ -871,7 +871,7 @@ Status Segment::lookup_row_key(const Slice& key, const TabletSchema* latest_sche
if (has_seq_col) {
// compare key
if (key_without_seq.compare(sought_key_without_seq) != 0) {
return Status::Error<ErrorCode::KEY_NOT_FOUND>("Can't find key in the segment");
return Status::Error<ErrorCode::KEY_NOT_FOUND, false>("");
}

if (with_seq_col && segment_has_seq_col) {
Expand All @@ -891,7 +891,7 @@ Status Segment::lookup_row_key(const Slice& key, const TabletSchema* latest_sche
Slice(sought_key.get_data(), sought_key.get_size() - rowid_length);
// compare key
if (key_without_seq.compare(sought_key_without_rowid) != 0) {
return Status::Error<ErrorCode::KEY_NOT_FOUND>("Can't find key in the segment");
return Status::Error<ErrorCode::KEY_NOT_FOUND, false>("");
}
}
// found the key, use rowid in pk index if necessary.
Expand Down
Loading