Skip to content

[chore](security) user_files_secure_path cannot be changed #55395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gavinchou merged 1 commit into from
Aug 30, 2025
Merged

[chore](security) user_files_secure_path cannot be changed #55395

gavinchou merged 1 commit into from
Aug 30, 2025

Conversation

@gavinchou
Copy link
Contributor

@gavinchou gavinchou commented Aug 28, 2025

No description provided.

@Thearas
Copy link
Contributor

Thearas commented Aug 28, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2025

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Aug 29, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
Copy link
Contributor

dataroaring commented Aug 29, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Aug 29, 2025

TPC-H: Total hot run time: 34220 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e23dc6c17637a431e3d46c6805f03c2540ac6ef3, data reload: false

------ Round 1 ----------------------------------
q1	17609	5254	5096	5096
q2	1989	324	241	241
q3	10212	1318	728	728
q4	10244	1058	555	555
q5	7512	2450	2360	2360
q6	191	169	138	138
q7	973	801	645	645
q8	9338	1329	1131	1131
q9	7086	5164	5234	5164
q10	6907	2411	1967	1967
q11	499	294	278	278
q12	350	384	229	229
q13	17801	3610	3006	3006
q14	262	240	231	231
q15	577	516	491	491
q16	432	435	379	379
q17	604	881	369	369
q18	7683	7490	7020	7020
q19	1214	959	571	571
q20	346	349	235	235
q21	3888	3174	2382	2382
q22	1086	1060	1004	1004
Total cold run time: 106803 ms
Total hot run time: 34220 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5164	5138	5126	5126
q2	248	335	226	226
q3	2182	2732	2340	2340
q4	1396	1826	1354	1354
q5	4262	4557	4719	4557
q6	232	180	151	151
q7	2031	1995	1849	1849
q8	2718	2688	2578	2578
q9	7570	7360	7435	7360
q10	3178	3329	2894	2894
q11	610	544	530	530
q12	753	813	614	614
q13	3549	4048	3318	3318
q14	297	310	282	282
q15	532	498	502	498
q16	443	507	446	446
q17	1184	1569	1403	1403
q18	7979	7733	7578	7578
q19	851	868	856	856
q20	2033	2091	1921	1921
q21	4982	4433	4420	4420
q22	1119	1053	1024	1024
Total cold run time: 53313 ms
Total hot run time: 51325 ms

@doris-robot
Copy link

doris-robot commented Aug 29, 2025

TPC-DS: Total hot run time: 186531 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e23dc6c17637a431e3d46c6805f03c2540ac6ef3, data reload: false

query1	1070	462	407	407
query2	6558	1760	1750	1750
query3	6750	223	222	222
query4	26315	23519	22829	22829
query5	4413	651	541	541
query6	340	247	246	246
query7	4658	523	302	302
query8	309	272	260	260
query9	8635	2888	2913	2888
query10	462	327	298	298
query11	15576	15071	14802	14802
query12	176	118	118	118
query13	1682	584	436	436
query14	8647	5783	5815	5783
query15	217	199	173	173
query16	7139	661	500	500
query17	962	790	628	628
query18	2014	443	333	333
query19	196	191	176	176
query20	135	125	123	123
query21	224	132	116	116
query22	4061	4072	4040	4040
query23	33872	32998	32970	32970
query24	8242	2399	2428	2399
query25	629	557	484	484
query26	1287	288	173	173
query27	2724	520	366	366
query28	4421	2291	2266	2266
query29	860	639	505	505
query30	300	231	212	212
query31	907	813	734	734
query32	91	83	89	83
query33	612	391	347	347
query34	805	877	521	521
query35	810	842	795	795
query36	993	1044	909	909
query37	125	115	91	91
query38	4121	4147	3950	3950
query39	1484	1464	1461	1461
query40	235	141	128	128
query41	66	62	64	62
query42	134	114	114	114
query43	530	507	496	496
query44	1348	862	861	861
query45	180	182	166	166
query46	872	1031	652	652
query47	1804	1806	1724	1724
query48	405	427	326	326
query49	763	515	423	423
query50	656	688	399	399
query51	4102	4185	4063	4063
query52	116	111	103	103
query53	256	273	201	201
query54	624	603	541	541
query55	101	91	93	91
query56	336	366	315	315
query57	1245	1214	1137	1137
query58	299	280	292	280
query59	2720	2740	2718	2718
query60	369	356	353	353
query61	177	165	162	162
query62	805	715	657	657
query63	241	193	195	193
query64	4597	1154	860	860
query65	4324	4170	4233	4170
query66	1182	476	412	412
query67	15588	15366	15268	15268
query68	7952	928	588	588
query69	508	334	300	300
query70	1213	1164	1098	1098
query71	419	346	347	346
query72	6075	5009	5135	5009
query73	644	606	359	359
query74	9151	9096	8682	8682
query75	3205	3108	2611	2611
query76	3202	1152	743	743
query77	537	431	338	338
query78	9593	9776	8855	8855
query79	2232	849	597	597
query80	714	584	580	580
query81	509	264	235	235
query82	198	139	117	117
query83	266	261	253	253
query84	303	117	94	94
query85	874	463	445	445
query86	388	332	303	303
query87	4299	4344	4121	4121
query88	2919	2243	2224	2224
query89	424	335	310	310
query90	1994	237	233	233
query91	164	167	145	145
query92	97	81	77	77
query93	2168	994	661	661
query94	711	431	331	331
query95	417	338	333	333
query96	486	597	281	281
query97	2640	2715	2619	2619
query98	263	231	223	223
query99	1352	1433	1308	1308
Total cold run time: 272814 ms
Total hot run time: 186531 ms

@doris-robot
Copy link

doris-robot commented Aug 29, 2025

ClickBench: Total hot run time: 33.48 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e23dc6c17637a431e3d46c6805f03c2540ac6ef3, data reload: false

query1	0.05	0.05	0.04
query2	0.09	0.06	0.05
query3	0.24	0.09	0.08
query4	1.60	0.12	0.12
query5	0.44	0.43	0.41
query6	1.17	0.64	0.66
query7	0.02	0.03	0.02
query8	0.05	0.04	0.04
query9	0.60	0.53	0.52
query10	0.58	0.57	0.56
query11	0.18	0.11	0.11
query12	0.15	0.12	0.12
query13	0.64	0.63	0.62
query14	0.79	0.84	0.85
query15	0.87	0.86	0.92
query16	0.39	0.42	0.39
query17	1.09	1.03	1.06
query18	0.22	0.20	0.20
query19	1.95	1.87	1.87
query20	0.02	0.01	0.02
query21	15.40	0.97	0.59
query22	0.78	1.25	0.99
query23	14.69	1.40	0.67
query24	6.96	1.81	1.09
query25	0.52	0.26	0.14
query26	0.65	0.17	0.14
query27	0.07	0.05	0.05
query28	10.21	0.93	0.45
query29	12.59	3.93	3.25
query30	3.14	3.10	2.93
query31	2.83	0.59	0.39
query32	3.25	0.56	0.48
query33	3.04	3.05	3.08
query34	15.97	5.54	4.91
query35	4.89	4.92	4.94
query36	0.69	0.51	0.51
query37	0.11	0.08	0.07
query38	0.06	0.05	0.04
query39	0.04	0.03	0.03
query40	0.19	0.15	0.16
query41	0.09	0.03	0.03
query42	0.05	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 107.4 s
Total hot run time: 33.48 s

@doris-robot
Copy link

doris-robot commented Aug 29, 2025

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 51.72% (17164/33184)
Line Coverage 37.20% (156409/420451)
Region Coverage 31.88% (119302/374173)
Branch Coverage 33.20% (52414/157885)

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 29, 2025

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 70.53% (22994/32602)
Line Coverage 56.82% (238837/420319)
Region Coverage 52.28% (198504/379682)
Branch Coverage 53.89% (85611/158864)

@gavinchou gavinchou merged commit 7794e51 into apache:master Aug 30, 2025
28 of 31 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 30, 2025
@gavinchou
[chore](security) user_files_secure_path cannot be changed (#55395)
4b7ef90
@github-actions github-actions bot mentioned this pull request Aug 30, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Aug 30, 2025
@gavinchou
[chore](security) user_files_secure_path cannot be changed (#55395)
247cc55
@github-actions github-actions bot mentioned this pull request Aug 30, 2025
Merged
morrySnow pushed a commit that referenced this pull request Sep 4, 2025
@github-actions @gavinchou
branch-3.1: [chore](security) user_files_secure_path cannot be changed …
b1859fa 
…#55395 (#55504)

Cherry-picked from #55395

Co-authored-by: Gavin Chou <gavin@selectdb.com>
dataroaring pushed a commit that referenced this pull request Sep 11, 2025
@github-actions @gavinchou
branch-3.0: [chore](security) user_files_secure_path cannot be changed …
e235255 
…#55395 (#55503)

Cherry-picked from #55395

Co-authored-by: Gavin Chou <gavin@selectdb.com>
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Closed
yiguolei pushed a commit to yiguolei/incubator-doris that referenced this pull request Nov 4, 2025
@gavinchou
[chore](security) user_files_secure_path cannot be changed (apache#55395
2cdce9c 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.9-merged dev/3.1.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gavinchou @Thearas @dataroaring @doris-robot @hello-stephen @morningman @morrySnow