Skip to content

Conversation

@zhiqiang-hhhh
Copy link
Contributor

What problem does this PR solve?

Related PR: #52701

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34433 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 88de0005497a62457bf6f6dab369aef46b373924, data reload: false

------ Round 1 ----------------------------------
q1	17597	5337	5114	5114
q2	1992	330	217	217
q3	10225	1325	740	740
q4	10246	1034	550	550
q5	7503	2417	2399	2399
q6	195	172	138	138
q7	947	772	623	623
q8	9346	1355	1152	1152
q9	6902	5117	5159	5117
q10	6930	2409	1972	1972
q11	480	300	291	291
q12	363	391	241	241
q13	17792	3714	3077	3077
q14	235	249	223	223
q15	560	518	500	500
q16	428	434	379	379
q17	597	868	376	376
q18	7563	7136	7097	7097
q19	1231	950	589	589
q20	343	346	229	229
q21	4111	3298	2433	2433
q22	1097	1047	976	976
Total cold run time: 106683 ms
Total hot run time: 34433 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5228	5493	5211	5211
q2	257	328	225	225
q3	2243	2699	2417	2417
q4	1408	1798	1416	1416
q5	4210	4576	4580	4576
q6	233	176	154	154
q7	2063	1974	1829	1829
q8	2727	2592	2620	2592
q9	7759	7122	7331	7122
q10	3118	3551	2878	2878
q11	598	536	507	507
q12	689	752	670	670
q13	3687	3907	3256	3256
q14	298	320	281	281
q15	534	495	482	482
q16	470	505	474	474
q17	1192	1549	1406	1406
q18	7939	7622	7538	7538
q19	845	878	1045	878
q20	2047	2069	1945	1945
q21	5156	4648	4656	4648
q22	1206	1130	1061	1061
Total cold run time: 53907 ms
Total hot run time: 51566 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 188382 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 88de0005497a62457bf6f6dab369aef46b373924, data reload: false

query1	1069	439	391	391
query2	6560	1798	1768	1768
query3	6757	230	226	226
query4	26584	23643	23166	23166
query5	4933	679	530	530
query6	359	277	231	231
query7	4655	522	305	305
query8	310	258	254	254
query9	8663	2931	2921	2921
query10	521	346	322	322
query11	15784	14923	15022	14923
query12	188	127	125	125
query13	1693	593	458	458
query14	10799	5968	5975	5968
query15	272	198	180	180
query16	7788	664	525	525
query17	1633	791	656	656
query18	2072	452	409	409
query19	271	207	169	169
query20	134	119	121	119
query21	224	134	118	118
query22	4398	4904	4640	4640
query23	34689	33836	32999	32999
query24	7781	2379	2363	2363
query25	555	506	444	444
query26	1203	277	161	161
query27	2684	526	381	381
query28	4366	2275	2240	2240
query29	786	601	500	500
query30	283	220	191	191
query31	875	808	752	752
query32	92	81	77	77
query33	563	399	353	353
query34	776	848	543	543
query35	795	822	784	784
query36	984	1025	954	954
query37	129	111	99	99
query38	4072	4123	4052	4052
query39	1497	1570	1416	1416
query40	221	134	119	119
query41	67	63	61	61
query42	131	112	110	110
query43	502	495	494	494
query44	1345	852	879	852
query45	183	184	177	177
query46	888	1025	650	650
query47	1782	1833	1749	1749
query48	396	422	335	335
query49	753	542	433	433
query50	651	675	416	416
query51	4113	4063	4333	4063
query52	126	114	104	104
query53	253	271	205	205
query54	621	615	556	556
query55	94	94	90	90
query56	339	343	329	329
query57	1183	1215	1129	1129
query58	290	285	284	284
query59	2759	2734	2665	2665
query60	353	363	351	351
query61	167	160	162	160
query62	833	712	697	697
query63	231	203	200	200
query64	4450	1161	851	851
query65	4302	4206	4234	4206
query66	1094	443	370	370
query67	15640	15410	15337	15337
query68	8896	956	598	598
query69	498	339	309	309
query70	1243	1199	1127	1127
query71	501	345	331	331
query72	5952	4986	5020	4986
query73	736	603	365	365
query74	9273	9064	9021	9021
query75	4154	3134	2643	2643
query76	3772	1146	744	744
query77	811	406	363	363
query78	9625	10021	8849	8849
query79	1760	878	595	595
query80	678	597	541	541
query81	472	264	220	220
query82	427	144	112	112
query83	271	273	247	247
query84	249	105	96	96
query85	892	456	425	425
query86	339	326	318	318
query87	4222	4315	4186	4186
query88	2818	2239	2193	2193
query89	397	319	296	296
query90	1939	228	227	227
query91	177	166	136	136
query92	93	75	77	75
query93	1108	966	654	654
query94	699	424	328	328
query95	410	331	330	330
query96	487	595	277	277
query97	2666	2721	2584	2584
query98	244	237	216	216
query99	1457	1421	1284	1284
Total cold run time: 278830 ms
Total hot run time: 188382 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.76 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 88de0005497a62457bf6f6dab369aef46b373924, data reload: false

query1	0.06	0.05	0.04
query2	0.10	0.05	0.06
query3	0.25	0.08	0.08
query4	1.61	0.12	0.12
query5	0.46	0.44	0.43
query6	1.20	0.65	0.64
query7	0.03	0.02	0.02
query8	0.06	0.05	0.04
query9	0.61	0.53	0.52
query10	0.58	0.59	0.58
query11	0.17	0.12	0.11
query12	0.15	0.13	0.12
query13	0.63	0.63	0.62
query14	0.80	0.86	0.84
query15	0.88	0.86	0.86
query16	0.39	0.43	0.40
query17	1.13	1.05	1.03
query18	0.22	0.20	0.20
query19	1.90	1.86	1.83
query20	0.02	0.01	0.02
query21	15.41	0.95	0.58
query22	0.77	1.21	0.73
query23	14.82	1.40	0.64
query24	6.77	1.62	0.66
query25	0.48	0.16	0.14
query26	0.55	0.15	0.13
query27	0.06	0.06	0.06
query28	10.12	0.92	0.43
query29	12.54	3.94	3.22
query30	3.05	3.08	3.01
query31	2.82	0.60	0.38
query32	3.23	0.56	0.48
query33	3.06	3.10	3.10
query34	16.04	5.43	4.86
query35	4.93	4.91	4.94
query36	0.70	0.51	0.50
query37	0.10	0.07	0.08
query38	0.06	0.04	0.04
query39	0.03	0.03	0.03
query40	0.19	0.15	0.15
query41	0.09	0.03	0.03
query42	0.04	0.04	0.03
query43	0.05	0.04	0.04
Total cold run time: 107.16 s
Total hot run time: 32.76 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 51.79% (17149/33115)
Line Coverage 37.26% (156273/419378)
Region Coverage 31.95% (119117/372840)
Branch Coverage 33.25% (52359/157488)

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Aug 28, 2025
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@zhiqiang-hhhh
Copy link
Contributor Author

run cloud_p0

@zhiqiang-hhhh
Copy link
Contributor Author

run p0

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 70.34% (22885/32533)
Line Coverage 56.54% (237041/419268)
Region Coverage 52.11% (197177/378386)
Branch Coverage 53.71% (85123/158486)

1 similar comment
@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 70.34% (22885/32533)
Line Coverage 56.54% (237041/419268)
Region Coverage 52.11% (197177/378386)
Branch Coverage 53.71% (85123/158486)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 70.35% (22887/32533)
Line Coverage 56.54% (237046/419268)
Region Coverage 52.12% (197218/378386)
Branch Coverage 53.72% (85137/158486)

Copy link
Contributor

@wangbo wangbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangbo wangbo merged commit b16db05 into apache:master Aug 29, 2025
25 of 28 checks passed
@zhiqiang-hhhh zhiqiang-hhhh deleted the fix-vs-2 branch August 29, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants