Skip to content

Conversation

@sollhui
Copy link
Contributor

@sollhui sollhui commented Aug 28, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@sollhui
Copy link
Contributor Author

sollhui commented Aug 28, 2025

run buildall

@Thearas
Copy link
Contributor

Thearas commented Aug 28, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@sollhui
Copy link
Contributor Author

sollhui commented Aug 28, 2025

run buildall

liaoxin01
liaoxin01 previously approved these changes Aug 28, 2025
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 28, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@sollhui
Copy link
Contributor Author

sollhui commented Aug 29, 2025

run buildall

@sollhui
Copy link
Contributor Author

sollhui commented Aug 29, 2025

run nonConcurrent

dataroaring
dataroaring previously approved these changes Aug 29, 2025
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sollhui sollhui dismissed stale reviews from dataroaring and liaoxin01 via 6d201e8 September 1, 2025 03:30
@sollhui sollhui force-pushed the skip_some_test_in_cloud_mode branch from 9cd4b50 to 6d201e8 Compare September 1, 2025 03:30
@sollhui
Copy link
Contributor Author

sollhui commented Sep 1, 2025

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 1, 2025
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2025

PR approved by at least one committer and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 9dd56b7 into apache:master Sep 1, 2025
28 of 30 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 1, 2025
github-actions bot pushed a commit that referenced this pull request Sep 1, 2025
dataroaring pushed a commit that referenced this pull request Sep 8, 2025
Cherry-picked from #55448

Co-authored-by: hui lai <laihui@selectdb.com>
morrySnow pushed a commit that referenced this pull request Sep 8, 2025
Cherry-picked from #55448

Co-authored-by: hui lai <laihui@selectdb.com>
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.9-merged dev/3.1.1-merged p0_test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants