[chore](recycler) Improve recycler metrics #55455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyxxxcat
requested review from
dataroaring,
gavinchou and
w41ter
as code owners
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
wyxxxcat
force-pushed
the
imp_recycler_metrics
branch
3 times, most recently
from
ec89be2 to
f3a9587
Compare
wyxxxcat
force-pushed
the
imp_recycler_metrics
branch
from
f3a9587 to
b290111
Compare
Contributor
Author
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
gavinchou
approved these changes
Aug 29, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 29, 2025
1. change the statistics of concurrent task nums to the statistics of task status for submitted, completed and error. the reason is that Promethus cannot collect tasks that are too short, resulting in no change in the concurrent number. 2. change the `atomic_long` to `atomic_ullong` for bytes 3. fixed the duplication of data collected by calling the `statistics_recycle` http interface
morrySnow
pushed a commit
that referenced
this pull request
Sep 4, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
change the statistics of concurrent task nums to the statistics of task status for submitted, completed and error. the reason is that Promethus cannot collect tasks that are too short, resulting in no change in the concurrent number.
change the
atomic_longtoatomic_ullongfor bytesfixed the duplication of data collected by calling the
statistics_recyclehttp interfaceRelease note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)