Skip to content

branch-3.0: [fix](nereids) fix window expression alias reuse expr id #55286 #55491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yujun777 wants to merge 4 commits into from
Closed

branch-3.0: [fix](nereids) fix window expression alias reuse expr id #55286 #55491

yujun777 wants to merge 4 commits into from

Conversation

@yujun777
Copy link
Contributor

@yujun777 yujun777 commented Aug 29, 2025

cherry pick from #55286

@yujun777 yujun777 requested a review from dataroaring as a code owner August 29, 2025 11:54
@yujun777
Copy link
Contributor Author

yujun777 commented Aug 29, 2025

run buildall

@Thearas
Copy link
Contributor

Thearas commented Aug 29, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

doris-robot commented Aug 29, 2025

TPC-H: Total hot run time: 39973 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bd50550c2396843e0df43217513d42697b433ab8, data reload: false

------ Round 1 ----------------------------------
q1	17578	6930	6716	6716
q2	2061	172	167	167
q3	10655	1132	1102	1102
q4	10435	743	751	743
q5	7700	2957	2736	2736
q6	211	131	133	131
q7	972	632	625	625
q8	9359	1930	2044	1930
q9	6660	6424	6412	6412
q10	7035	2260	2296	2260
q11	465	266	263	263
q12	396	215	214	214
q13	17783	3009	2964	2964
q14	229	204	216	204
q15	518	469	444	444
q16	479	376	376	376
q17	980	586	553	553
q18	7333	6625	6652	6625
q19	1391	1113	1158	1113
q20	467	202	200	200
q21	3883	3216	3165	3165
q22	1100	1030	1035	1030
Total cold run time: 107690 ms
Total hot run time: 39973 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6733	6595	6614	6595
q2	330	234	231	231
q3	2910	2933	2888	2888
q4	2152	1844	1862	1844
q5	5762	5772	5772	5772
q6	217	128	126	126
q7	2203	1771	1853	1771
q8	3386	3548	3499	3499
q9	8805	8906	8846	8846
q10	3597	3520	3502	3502
q11	598	500	493	493
q12	795	603	588	588
q13	8281	3144	3144	3144
q14	309	272	261	261
q15	521	466	470	466
q16	493	443	444	443
q17	1874	1626	1622	1622
q18	8200	7724	7825	7724
q19	1667	1668	1521	1521
q20	2070	1887	1886	1886
q21	5204	5106	5013	5013
q22	1152	1057	1027	1027
Total cold run time: 67259 ms
Total hot run time: 59262 ms

@doris-robot
Copy link

doris-robot commented Aug 29, 2025

TPC-DS: Total hot run time: 193127 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit bd50550c2396843e0df43217513d42697b433ab8, data reload: false

query1	950	410	398	398
query2	6283	1921	1917	1917
query3	8687	204	204	204
query4	33600	23927	23248	23248
query5	4056	465	452	452
query6	288	187	186	186
query7	4203	313	311	311
query8	280	218	231	218
query9	9515	2590	2600	2590
query10	498	258	258	258
query11	18035	15263	15321	15263
query12	165	105	103	103
query13	1559	444	433	433
query14	9901	7083	7132	7083
query15	263	186	176	176
query16	8037	506	515	506
query17	1601	645	603	603
query18	2151	339	329	329
query19	304	161	167	161
query20	127	113	118	113
query21	213	109	108	108
query22	4579	4596	4376	4376
query23	35031	34520	34647	34520
query24	11358	2984	2982	2982
query25	671	445	440	440
query26	1392	179	181	179
query27	2394	359	364	359
query28	6613	2183	2196	2183
query29	857	468	470	468
query30	263	170	171	170
query31	1091	848	831	831
query32	102	59	57	57
query33	784	304	313	304
query34	967	534	521	521
query35	867	731	742	731
query36	1139	914	937	914
query37	127	79	72	72
query38	4130	4000	4045	4000
query39	1517	1504	1443	1443
query40	205	99	101	99
query41	51	50	53	50
query42	115	101	98	98
query43	513	489	478	478
query44	1245	811	821	811
query45	187	166	177	166
query46	1153	753	738	738
query47	2024	1889	1966	1889
query48	479	401	416	401
query49	920	395	399	395
query50	840	445	434	434
query51	7383	7316	7081	7081
query52	108	91	90	90
query53	268	207	189	189
query54	1237	485	485	485
query55	85	75	77	75
query56	260	259	241	241
query57	1329	1197	1203	1197
query58	232	220	219	219
query59	3281	3081	2974	2974
query60	278	262	259	259
query61	107	108	112	108
query62	846	708	691	691
query63	230	200	184	184
query64	4045	661	660	660
query65	3374	3258	3344	3258
query66	851	302	298	298
query67	16166	15689	15721	15689
query68	4422	587	588	587
query69	433	264	269	264
query70	1136	1107	1092	1092
query71	357	285	263	263
query72	6259	4112	4094	4094
query73	790	353	354	353
query74	10534	9245	8971	8971
query75	3397	2633	2658	2633
query76	2970	1049	1165	1049
query77	404	288	270	270
query78	10595	9623	9535	9535
query79	2475	606	612	606
query80	1121	428	426	426
query81	549	225	225	225
query82	603	87	90	87
query83	239	142	149	142
query84	238	86	87	86
query85	1581	310	301	301
query86	486	289	267	267
query87	4442	4284	4288	4284
query88	4313	2417	2404	2404
query89	417	291	295	291
query90	1971	195	191	191
query91	200	152	171	152
query92	63	49	52	49
query93	2408	553	563	553
query94	817	310	297	297
query95	367	264	257	257
query96	623	279	279	279
query97	3307	3147	3144	3144
query98	221	204	194	194
query99	1532	1314	1326	1314
Total cold run time: 301680 ms
Total hot run time: 193127 ms

@doris-robot
Copy link

doris-robot commented Aug 29, 2025

ClickBench: Total hot run time: 30.4 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bd50550c2396843e0df43217513d42697b433ab8, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.02	0.03
query3	0.24	0.06	0.07
query4	1.63	0.10	0.11
query5	0.52	0.50	0.50
query6	1.13	0.75	0.72
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.57	0.51	0.51
query10	0.56	0.55	0.55
query11	0.14	0.11	0.09
query12	0.13	0.11	0.11
query13	0.61	0.59	0.60
query14	0.79	0.84	0.77
query15	0.85	0.84	0.83
query16	0.38	0.39	0.38
query17	1.05	1.02	1.09
query18	0.24	0.23	0.23
query19	1.99	1.77	1.87
query20	0.01	0.01	0.02
query21	15.39	0.58	0.58
query22	2.55	2.06	2.64
query23	16.98	0.93	0.73
query24	3.75	0.81	0.74
query25	0.14	0.17	0.22
query26	0.40	0.14	0.13
query27	0.05	0.06	0.04
query28	10.72	0.47	0.48
query29	12.58	3.36	3.33
query30	0.25	0.07	0.06
query31	2.87	0.39	0.38
query32	3.23	0.46	0.46
query33	3.01	3.07	3.04
query34	16.90	4.53	4.54
query35	4.55	4.59	4.60
query36	0.68	0.48	0.47
query37	0.08	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.03	0.02
query40	0.16	0.12	0.12
query41	0.09	0.03	0.02
query42	0.03	0.03	0.02
query43	0.03	0.02	0.02
Total cold run time: 105.53 s
Total hot run time: 30.4 s

@yujun777
Copy link
Contributor Author

yujun777 commented Aug 30, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Aug 30, 2025

TPC-H: Total hot run time: 39632 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 03fea52184ef5a63d9200ef7b428d0ce093c3d36, data reload: false

------ Round 1 ----------------------------------
q1	17592	6715	6619	6619
q2	2029	228	165	165
q3	10489	1114	1137	1114
q4	10207	745	728	728
q5	7688	2869	2857	2857
q6	207	127	127	127
q7	972	631	607	607
q8	9368	1910	2008	1910
q9	6783	6497	6495	6495
q10	7046	2237	2310	2237
q11	459	261	267	261
q12	397	210	214	210
q13	17791	2950	2996	2950
q14	228	205	203	203
q15	511	466	470	466
q16	482	369	370	369
q17	972	522	630	522
q18	7105	6634	6608	6608
q19	1397	1081	1048	1048
q20	477	196	202	196
q21	3851	3213	2949	2949
q22	1117	991	997	991
Total cold run time: 107168 ms
Total hot run time: 39632 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6588	6552	6545	6545
q2	330	224	228	224
q3	2865	2816	2934	2816
q4	2045	1767	1817	1767
q5	5721	5686	5673	5673
q6	206	127	124	124
q7	2166	1834	1732	1732
q8	3400	3544	3524	3524
q9	8863	8957	8818	8818
q10	3576	3469	3544	3469
q11	601	484	491	484
q12	795	597	609	597
q13	9262	3162	3162	3162
q14	323	278	279	278
q15	511	472	464	464
q16	502	446	442	442
q17	1821	1617	1608	1608
q18	8171	7727	7817	7727
q19	1729	1636	1628	1628
q20	2048	1826	1819	1819
q21	5223	5099	4883	4883
q22	1129	1101	1048	1048
Total cold run time: 67875 ms
Total hot run time: 58832 ms

@doris-robot
Copy link

doris-robot commented Aug 30, 2025

TPC-DS: Total hot run time: 193044 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 03fea52184ef5a63d9200ef7b428d0ce093c3d36, data reload: false

query1	955	413	394	394
query2	6250	1937	1842	1842
query3	8681	207	207	207
query4	33750	23410	23909	23410
query5	3739	460	447	447
query6	291	177	176	176
query7	4210	310	319	310
query8	278	215	219	215
query9	9386	2596	2590	2590
query10	487	270	266	266
query11	17799	15259	15245	15245
query12	152	103	106	103
query13	1569	435	425	425
query14	8587	7126	7092	7092
query15	248	170	180	170
query16	8028	500	486	486
query17	1577	629	600	600
query18	2171	325	316	316
query19	301	167	165	165
query20	125	124	121	121
query21	207	106	106	106
query22	4738	4613	4567	4567
query23	34410	34268	34466	34268
query24	11615	2896	2917	2896
query25	722	428	428	428
query26	1751	174	176	174
query27	2872	350	360	350
query28	7886	2161	2174	2161
query29	1040	476	463	463
query30	267	153	169	153
query31	1038	864	869	864
query32	102	60	61	60
query33	779	315	324	315
query34	926	523	519	519
query35	929	740	766	740
query36	1088	941	961	941
query37	175	72	67	67
query38	4108	3905	4012	3905
query39	1584	1459	1487	1459
query40	256	98	105	98
query41	49	48	45	45
query42	122	105	110	105
query43	550	472	493	472
query44	1245	796	808	796
query45	185	164	170	164
query46	1167	723	737	723
query47	2019	1971	1968	1968
query48	480	378	379	378
query49	1063	393	399	393
query50	836	411	427	411
query51	7491	7280	7220	7220
query52	104	92	93	92
query53	259	190	184	184
query54	1283	469	481	469
query55	84	78	82	78
query56	293	261	251	251
query57	1341	1192	1203	1192
query58	229	211	234	211
query59	3167	3010	3021	3010
query60	291	270	265	265
query61	139	114	113	113
query62	867	701	693	693
query63	229	191	190	190
query64	4997	705	630	630
query65	3368	3309	3310	3309
query66	1621	309	303	303
query67	16735	15587	15717	15587
query68	4664	592	580	580
query69	451	264	259	259
query70	1130	1108	1094	1094
query71	358	255	255	255
query72	6280	4058	3971	3971
query73	757	355	356	355
query74	10529	9327	9234	9234
query75	3371	2649	2665	2649
query76	2682	1030	1107	1030
query77	374	273	276	273
query78	10490	9545	9551	9545
query79	1371	590	599	590
query80	773	421	428	421
query81	515	222	215	215
query82	593	87	88	87
query83	159	151	147	147
query84	242	82	83	82
query85	1391	310	290	290
query86	401	290	307	290
query87	4374	4232	4269	4232
query88	3733	2415	2412	2412
query89	412	297	290	290
query90	2021	180	181	180
query91	185	150	146	146
query92	61	52	51	51
query93	1621	555	563	555
query94	749	309	292	292
query95	365	259	258	258
query96	607	279	284	279
query97	3296	3117	3158	3117
query98	213	215	198	198
query99	1593	1301	1301	1301
Total cold run time: 301052 ms
Total hot run time: 193044 ms

@doris-robot
Copy link

doris-robot commented Aug 30, 2025

ClickBench: Total hot run time: 30.27 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 03fea52184ef5a63d9200ef7b428d0ce093c3d36, data reload: false

query1	0.03	0.03	0.02
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.63	0.10	0.11
query5	0.52	0.50	0.51
query6	1.14	0.73	0.71
query7	0.02	0.02	0.01
query8	0.04	0.04	0.03
query9	0.56	0.49	0.52
query10	0.55	0.55	0.55
query11	0.14	0.10	0.10
query12	0.13	0.10	0.10
query13	0.60	0.59	0.59
query14	0.77	0.82	0.78
query15	0.84	0.82	0.82
query16	0.40	0.39	0.42
query17	1.01	1.08	1.05
query18	0.24	0.22	0.21
query19	1.91	1.88	1.86
query20	0.02	0.01	0.01
query21	15.39	0.60	0.58
query22	2.59	2.14	1.42
query23	16.99	1.14	0.86
query24	2.60	1.69	1.18
query25	0.14	0.17	0.08
query26	0.43	0.14	0.14
query27	0.04	0.05	0.05
query28	10.14	0.48	0.51
query29	12.54	3.34	3.27
query30	0.26	0.06	0.06
query31	2.85	0.39	0.39
query32	3.22	0.46	0.44
query33	2.97	3.03	3.06
query34	16.88	4.54	4.54
query35	4.59	4.56	4.59
query36	0.65	0.47	0.47
query37	0.08	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.03
query40	0.16	0.13	0.12
query41	0.07	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.6 s
Total hot run time: 30.27 s

dataroaring
dataroaring previously approved these changes Sep 5, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yujun777
Copy link
Contributor Author

yujun777 commented Sep 5, 2025

run buildall

@yujun777
Copy link
Contributor Author

yujun777 commented Sep 5, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 5, 2025

TPC-H: Total hot run time: 40300 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f96230f3cda9f228cea82b4d7984216766fb77ee, data reload: false

------ Round 1 ----------------------------------
q1	17687	6986	6741	6741
q2	2040	206	196	196
q3	10595	1165	1206	1165
q4	10503	769	769	769
q5	7783	2916	2858	2858
q6	213	131	135	131
q7	987	626	607	607
q8	9344	2006	2014	2006
q9	6743	6428	6457	6428
q10	6948	2317	2314	2314
q11	462	261	265	261
q12	395	210	216	210
q13	17790	3013	2967	2967
q14	238	212	205	205
q15	527	460	458	458
q16	442	379	376	376
q17	998	629	538	538
q18	7180	6784	6637	6637
q19	1407	1111	1035	1035
q20	477	195	199	195
q21	3914	3221	3284	3221
q22	1107	1001	982	982
Total cold run time: 107780 ms
Total hot run time: 40300 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6595	6575	6616	6575
q2	337	232	240	232
q3	3001	2926	2940	2926
q4	2098	1930	1811	1811
q5	5744	5856	5723	5723
q6	211	128	135	128
q7	2192	1834	1795	1795
q8	3420	3658	3545	3545
q9	8875	8938	8941	8938
q10	3611	3559	3563	3559
q11	592	497	503	497
q12	805	575	647	575
q13	9390	3124	3143	3124
q14	301	273	262	262
q15	505	468	475	468
q16	506	456	444	444
q17	1905	1622	1610	1610
q18	8293	7721	7694	7694
q19	1686	1550	1547	1547
q20	2108	1859	1934	1859
q21	5352	5039	5092	5039
q22	1174	1056	1062	1056
Total cold run time: 68701 ms
Total hot run time: 59407 ms

@doris-robot
Copy link

doris-robot commented Sep 5, 2025

TPC-DS: Total hot run time: 191775 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f96230f3cda9f228cea82b4d7984216766fb77ee, data reload: false

query1	942	410	405	405
query2	6238	1945	1869	1869
query3	8678	202	196	196
query4	33866	23560	23486	23486
query5	3651	461	454	454
query6	283	185	190	185
query7	4204	322	313	313
query8	281	223	234	223
query9	9531	2568	2582	2568
query10	470	251	263	251
query11	17861	15088	15617	15088
query12	165	102	101	101
query13	1575	432	426	426
query14	9493	6580	6533	6533
query15	259	173	176	173
query16	7901	469	487	469
query17	1626	649	602	602
query18	2148	346	336	336
query19	235	169	165	165
query20	127	115	118	115
query21	203	114	110	110
query22	4636	4520	4313	4313
query23	34889	34399	34589	34399
query24	12612	3025	2902	2902
query25	673	443	429	429
query26	1412	179	174	174
query27	3051	359	381	359
query28	7398	2171	2185	2171
query29	913	460	451	451
query30	273	160	156	156
query31	1042	857	801	801
query32	103	57	60	57
query33	774	317	341	317
query34	971	533	534	533
query35	871	743	751	743
query36	1110	989	968	968
query37	137	67	74	67
query38	4081	3941	3997	3941
query39	1524	1466	1486	1466
query40	205	105	102	102
query41	53	49	53	49
query42	112	106	100	100
query43	525	466	486	466
query44	1269	819	837	819
query45	190	167	167	167
query46	1178	730	734	730
query47	1981	1941	1903	1903
query48	463	377	385	377
query49	964	395	393	393
query50	836	411	431	411
query51	7399	7201	7179	7179
query52	102	95	90	90
query53	266	184	180	180
query54	1251	459	476	459
query55	78	79	81	79
query56	273	249	253	249
query57	1319	1210	1204	1204
query58	225	217	216	216
query59	3205	2878	3109	2878
query60	296	268	270	268
query61	135	125	109	109
query62	841	724	707	707
query63	226	196	195	195
query64	5200	662	641	641
query65	3413	3309	3316	3309
query66	1375	293	303	293
query67	16688	15503	15671	15503
query68	4454	579	578	578
query69	426	267	266	266
query70	1156	1123	1076	1076
query71	332	251	261	251
query72	6244	4069	4022	4022
query73	757	350	353	350
query74	10211	8993	9007	8993
query75	3397	2641	2652	2641
query76	2714	1077	1033	1033
query77	388	285	266	266
query78	10654	9547	9453	9453
query79	2569	595	623	595
query80	1079	443	433	433
query81	542	217	220	217
query82	598	89	89	89
query83	264	137	144	137
query84	232	84	82	82
query85	1444	306	299	299
query86	460	306	289	289
query87	4396	4290	4245	4245
query88	4106	2389	2380	2380
query89	409	298	291	291
query90	1988	192	188	188
query91	183	148	173	148
query92	64	50	51	50
query93	2351	559	544	544
query94	808	306	295	295
query95	361	253	252	252
query96	634	285	294	285
query97	3315	3169	3160	3160
query98	221	193	198	193
query99	1470	1283	1290	1283
Total cold run time: 304502 ms
Total hot run time: 191775 ms

@doris-robot
Copy link

doris-robot commented Sep 5, 2025

ClickBench: Total hot run time: 29.37 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f96230f3cda9f228cea82b4d7984216766fb77ee, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.02
query3	0.23	0.06	0.07
query4	1.63	0.10	0.10
query5	0.53	0.51	0.51
query6	1.15	0.72	0.73
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.59	0.50	0.50
query10	0.55	0.54	0.56
query11	0.14	0.10	0.11
query12	0.14	0.11	0.10
query13	0.61	0.60	0.59
query14	0.78	0.81	0.78
query15	0.85	0.83	0.83
query16	0.37	0.38	0.39
query17	1.01	0.99	1.06
query18	0.24	0.22	0.23
query19	1.96	1.82	1.79
query20	0.01	0.01	0.02
query21	15.41	0.59	0.58
query22	2.73	1.83	1.69
query23	17.07	0.86	0.84
query24	3.42	0.68	0.38
query25	0.38	0.05	0.04
query26	0.42	0.15	0.14
query27	0.05	0.04	0.05
query28	11.00	0.51	0.46
query29	12.58	3.22	3.24
query30	0.25	0.06	0.06
query31	2.85	0.39	0.38
query32	3.25	0.46	0.46
query33	2.99	2.99	3.03
query34	16.93	4.65	4.50
query35	4.54	4.51	4.55
query36	0.68	0.47	0.48
query37	0.09	0.06	0.06
query38	0.04	0.03	0.04
query39	0.04	0.02	0.03
query40	0.16	0.12	0.13
query41	0.07	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.97 s
Total hot run time: 29.37 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 5, 2025

FE UT Coverage Report

Increment line coverage 100.00% (5/5) 🎉
Increment coverage report
Complete coverage report

dataroaring
dataroaring approved these changes Sep 11, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2025

PR approved by anyone and no changes requested.

@yujun777 yujun777 closed this Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yujun777 @Thearas @doris-robot @hello-stephen @dataroaring