Skip to content

[opt](recycler) Avoid doing many Aws::Internal::GetEC2MetadataClient http call #55546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gavinchou merged 1 commit into from
Sep 4, 2025
Merged

[opt](recycler) Avoid doing many Aws::Internal::GetEC2MetadataClient http call #55546

gavinchou merged 1 commit into from
Sep 4, 2025

Conversation

@swjtu-zhanglei
Copy link
Contributor

@swjtu-zhanglei swjtu-zhanglei commented Sep 1, 2025 •
edited
Loading

  • The default constructor of ClientConfiguration will do some http call such as Aws::Internal::GetEC2MetadataClient and other init operation, which is unnecessary.So here we use a static instance, and deep cpy every time to avoid unnecessary operations.

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@swjtu-zhanglei
[opt](recycler) Avoid doing many `Aws::Internal::GetEC2MetadataClient…
0847aa9 
…` http call

* The default constructor of ClientConfiguration will do some http call
  such as Aws::Internal::GetEC2MetadataClient and other init operation,
  which is unnecessary.So here we use a static instance, and deep cpy every time
  to avoid unnecessary operations.
@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 1, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@swjtu-zhanglei
Copy link
Contributor Author

swjtu-zhanglei commented Sep 1, 2025

run buildall

@swjtu-zhanglei
Copy link
Contributor Author

swjtu-zhanglei commented Sep 2, 2025

run cloud_ut

dataroaring
dataroaring approved these changes Sep 3, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

PR approved by anyone and no changes requested.

@swjtu-zhanglei
Copy link
Contributor Author

swjtu-zhanglei commented Sep 4, 2025

run cloud_ut

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 4, 2025

Cloud UT Coverage Report

Increment line coverage 71.43% (5/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 84.73% (1481/1748)
Line Coverage 67.97% (26522/39022)
Region Coverage 68.91% (13140/19069)
Branch Coverage 58.89% (7037/11950)

@gavinchou gavinchou merged commit ded823b into apache:master Sep 4, 2025
33 of 34 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 4, 2025
@swjtu-zhanglei
[opt](recycler) Avoid doing many `Aws::Internal::GetEC2MetadataClient…
03c2176 
…` http call (#55546)

* The default constructor of ClientConfiguration will do some http call
such as Aws::Internal::GetEC2MetadataClient and other init operation,
which is unnecessary.So here we use a static instance, and deep cpy
every time to avoid unnecessary operations.
@github-actions github-actions bot mentioned this pull request Sep 4, 2025
Merged
morrySnow pushed a commit that referenced this pull request Sep 5, 2025
@github-actions @swjtu-zhanglei
branch-3.1: [opt](recycler) Avoid doing many `Aws::Internal::GetEC2Me…
d1cbff1 
…tadataClient` http call #55546 (#55682)

Cherry-picked from #55546

Co-authored-by: Lei Zhang <zhanglei@selectdb.com>
wenzhenghu pushed a commit to wenzhenghu/doris that referenced this pull request Sep 8, 2025
@swjtu-zhanglei @wenzhenghu
[opt](recycler) Avoid doing many `Aws::Internal::GetEC2MetadataClient…
605f164 
…` http call (apache#55546)

* The default constructor of ClientConfiguration will do some http call
such as Aws::Internal::GetEC2MetadataClient and other init operation,
which is unnecessary.So here we use a static instance, and deep cpy
every time to avoid unnecessary operations.
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

@w41ter w41ter Awaiting requested review from w41ter w41ter is a code owner

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@swjtu-zhanglei @hello-stephen @gavinchou @dataroaring @morrySnow