Skip to content

[fix](iceberg rest) OAuth2 Token refresh using Iceberg default value #55578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zy-kkk merged 2 commits into from
Sep 3, 2025
Merged

[fix](iceberg rest) OAuth2 Token refresh using Iceberg default value #55578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
928bd03
[fix](iceberg rest) OAuth2 Token refresh using Iceberg default value
zy-kkk Sep 2, 2025
7f0ef25
fix ut
zy-kkk Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...e/src/main/java/org/apache/doris/datasource/property/metastore/IcebergRestProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@ public class IcebergRestProperties extends AbstractIcebergProperties {
@ConnectorProperty(names = {"iceberg.rest.oauth2.token-refresh-enabled"},
required = false,
description = "Enable oauth2 token refresh for the iceberg rest catalog service.")
private String icebergRestOauth2TokenRefreshEnabled = "false";
private String icebergRestOauth2TokenRefreshEnabled = String.valueOf(
OAuth2Properties.TOKEN_REFRESH_ENABLED_DEFAULT);

@ConnectorProperty(names = {"iceberg.rest.vended-credentials-enabled"},
required = false,
Expand Down
3 changes: 2 additions & 1 deletion ...c/test/java/org/apache/doris/datasource/property/metastore/IcebergRestPropertiesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ public void testOAuth2CredentialFlow() {
Assertions.assertEquals("client_credentials", catalogProps.get(OAuth2Properties.CREDENTIAL));
Assertions.assertEquals("http://auth.example.com/token", catalogProps.get(OAuth2Properties.OAUTH2_SERVER_URI));
Assertions.assertEquals("read write", catalogProps.get(OAuth2Properties.SCOPE));
Assertions.assertEquals("false", catalogProps.get(OAuth2Properties.TOKEN_REFRESH_ENABLED));
Assertions.assertEquals(String.valueOf(OAuth2Properties.TOKEN_REFRESH_ENABLED_DEFAULT),
catalogProps.get(OAuth2Properties.TOKEN_REFRESH_ENABLED));
}

@Test
Expand Down
Loading