Skip to content

[thirdparty](patch)fix brpc core when enable ssl #55649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Sep 5, 2025
Merged

[thirdparty](patch)fix brpc core when enable ssl #55649

yiguolei merged 1 commit into from
Sep 5, 2025

Conversation

@koarz
Copy link
Contributor

@koarz koarz commented Sep 4, 2025 •
edited
Loading

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 4, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@koarz
Copy link
Contributor Author

koarz commented Sep 4, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 4, 2025

TPC-H: Total hot run time: 34335 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit daa3f64a08e1ae01a021a1e1ad97c16cd000a64e, data reload: false

------ Round 1 ----------------------------------
q1	17609	5260	5111	5111
q2	2016	319	215	215
q3	10269	1283	725	725
q4	10237	1024	520	520
q5	7569	2483	2325	2325
q6	190	172	137	137
q7	948	763	639	639
q8	9348	1341	1150	1150
q9	6916	5234	5186	5186
q10	6949	2409	1975	1975
q11	492	341	275	275
q12	353	368	241	241
q13	17792	3630	3056	3056
q14	248	243	227	227
q15	571	505	489	489
q16	431	428	398	398
q17	615	850	364	364
q18	7448	7109	7077	7077
q19	1319	951	600	600
q20	348	338	230	230
q21	3804	3210	2391	2391
q22	1066	1026	1004	1004
Total cold run time: 106538 ms
Total hot run time: 34335 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5234	5146	5202	5146
q2	262	332	226	226
q3	2162	2652	2313	2313
q4	1358	1750	1318	1318
q5	4201	4420	4448	4420
q6	219	178	133	133
q7	2103	1970	1889	1889
q8	2684	2760	2658	2658
q9	7381	7348	7376	7348
q10	3207	3269	2914	2914
q11	591	532	520	520
q12	673	781	663	663
q13	3579	3879	3353	3353
q14	287	290	276	276
q15	523	473	473	473
q16	457	521	469	469
q17	1225	1528	1455	1455
q18	8037	7653	7693	7653
q19	882	946	1005	946
q20	1987	2093	1951	1951
q21	5087	4514	4331	4331
q22	1128	1045	1001	1001
Total cold run time: 53267 ms
Total hot run time: 51456 ms

@doris-robot
Copy link

doris-robot commented Sep 4, 2025

TPC-DS: Total hot run time: 187649 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit daa3f64a08e1ae01a021a1e1ad97c16cd000a64e, data reload: false

query1	1060	465	404	404
query2	6571	1712	1742	1712
query3	6754	227	223	223
query4	26340	23574	23609	23574
query5	4684	639	552	552
query6	334	242	237	237
query7	4673	537	300	300
query8	292	250	251	250
query9	8621	2910	2905	2905
query10	474	368	300	300
query11	15864	15355	14965	14965
query12	174	121	118	118
query13	1677	557	425	425
query14	9410	5869	5755	5755
query15	221	199	178	178
query16	7436	687	520	520
query17	1248	816	669	669
query18	2049	458	359	359
query19	221	214	192	192
query20	138	131	126	126
query21	216	136	117	117
query22	4140	4089	3915	3915
query23	34059	33116	33038	33038
query24	8194	2423	2423	2423
query25	618	562	482	482
query26	1250	286	180	180
query27	2725	502	363	363
query28	4372	2273	2228	2228
query29	818	615	487	487
query30	300	227	195	195
query31	916	789	770	770
query32	93	84	80	80
query33	573	390	361	361
query34	816	867	531	531
query35	816	843	750	750
query36	987	1040	932	932
query37	129	112	88	88
query38	4072	4031	4009	4009
query39	1493	1435	1614	1435
query40	230	135	129	129
query41	65	63	64	63
query42	144	112	117	112
query43	495	502	473	473
query44	1353	862	866	862
query45	190	177	176	176
query46	884	1021	654	654
query47	1781	1806	1754	1754
query48	393	453	325	325
query49	754	515	408	408
query50	690	708	409	409
query51	4116	4235	4127	4127
query52	117	114	106	106
query53	249	270	205	205
query54	646	633	537	537
query55	95	93	93	93
query56	357	329	335	329
query57	1233	1212	1126	1126
query58	297	284	294	284
query59	2634	2639	2619	2619
query60	367	362	354	354
query61	169	197	163	163
query62	830	756	685	685
query63	235	195	199	195
query64	4568	1144	840	840
query65	4315	4246	4248	4246
query66	1155	445	373	373
query67	15671	15224	15023	15023
query68	9194	960	589	589
query69	515	348	304	304
query70	1230	1147	1128	1128
query71	600	353	335	335
query72	6003	4994	5097	4994
query73	770	660	373	373
query74	8934	9063	8915	8915
query75	4278	3099	2699	2699
query76	3718	1162	744	744
query77	827	422	340	340
query78	9539	9719	8863	8863
query79	1708	840	578	578
query80	722	591	517	517
query81	492	346	235	235
query82	242	146	117	117
query83	300	274	256	256
query84	310	109	97	97
query85	845	472	434	434
query86	364	327	332	327
query87	4379	4328	4277	4277
query88	2844	2264	2295	2264
query89	407	334	293	293
query90	2085	233	237	233
query91	170	172	135	135
query92	92	81	77	77
query93	1126	997	637	637
query94	693	419	338	338
query95	419	348	334	334
query96	490	594	284	284
query97	2659	2687	2578	2578
query98	251	217	216	216
query99	1446	1426	1320	1320
Total cold run time: 276513 ms
Total hot run time: 187649 ms

@doris-robot
Copy link

doris-robot commented Sep 4, 2025

ClickBench: Total hot run time: 32.45 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit daa3f64a08e1ae01a021a1e1ad97c16cd000a64e, data reload: false

query1	0.05	0.04	0.05
query2	0.10	0.05	0.05
query3	0.25	0.08	0.08
query4	1.60	0.12	0.12
query5	0.44	0.43	0.41
query6	1.16	0.64	0.65
query7	0.03	0.03	0.03
query8	0.05	0.04	0.04
query9	0.60	0.54	0.53
query10	0.59	0.58	0.58
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.63	0.63	0.62
query14	0.81	0.83	0.85
query15	0.88	0.86	0.87
query16	0.40	0.42	0.41
query17	1.07	1.07	1.08
query18	0.21	0.20	0.20
query19	1.97	1.95	1.79
query20	0.01	0.01	0.02
query21	15.40	0.98	0.58
query22	0.75	1.16	0.73
query23	14.91	1.40	0.63
query24	6.33	1.29	0.31
query25	0.31	0.19	0.15
query26	0.64	0.16	0.13
query27	0.06	0.05	0.06
query28	9.70	0.99	0.42
query29	12.64	3.92	3.23
query30	3.06	3.04	2.98
query31	2.83	0.59	0.38
query32	3.26	0.56	0.48
query33	3.10	3.18	3.15
query34	16.00	5.52	4.87
query35	4.91	4.95	4.98
query36	0.71	0.50	0.51
query37	0.10	0.08	0.07
query38	0.06	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.16	0.14
query41	0.09	0.03	0.03
query42	0.04	0.03	0.02
query43	0.04	0.04	0.04
Total cold run time: 106.31 s
Total hot run time: 32.45 s

@doris-robot
Copy link

doris-robot commented Sep 4, 2025

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 51.84% (17205/33189)
Line Coverage 37.27% (157134/421604)
Region Coverage 31.90% (119938/375978)
Branch Coverage 33.29% (52663/158203)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

PR approved by anyone and no changes requested.

@koarz
Copy link
Contributor Author

koarz commented Sep 4, 2025

run cloud_p0

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 4, 2025

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 56.64% (18458/32590)
Line Coverage 42.01% (177023/421335)
Region Coverage 36.36% (138677/381349)
Branch Coverage 37.59% (59807/159093)

1 similar comment
@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 4, 2025

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 56.64% (18458/32590)
Line Coverage 42.01% (177023/421335)
Region Coverage 36.36% (138677/381349)
Branch Coverage 37.59% (59807/159093)

@yiguolei yiguolei merged commit 7ecb49f into apache:master Sep 5, 2025
29 of 31 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 5, 2025
@koarz
[thirdparty](patch)fix brpc core when enable ssl (#55649)
27dfcac 
apache/brpc#2166
apache/brpc#2180
@github-actions github-actions bot mentioned this pull request Sep 5, 2025
Merged
morrySnow pushed a commit that referenced this pull request Sep 5, 2025
@github-actions @koarz
branch-3.1: [thirdparty](patch)fix brpc core when enable ssl #55649 (#…
dd2faa8 
…55695)

Cherry-picked from #55649

Co-authored-by: koarz <lihao@selectdb.com>
@koarz koarz deleted the brpc_patch branch September 6, 2025 08:46
wenzhenghu pushed a commit to wenzhenghu/doris that referenced this pull request Sep 8, 2025
@koarz @wenzhenghu
[thirdparty](patch)fix brpc core when enable ssl (apache#55649)
9dee8c6 
apache/brpc#2166
apache/brpc#2180
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@koarz @hello-stephen @doris-robot @gavinchou @yiguolei @morrySnow