Skip to content

[thirdparty](patch)brpc force ssl for all connections #55658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gavinchou merged 1 commit into from
Sep 5, 2025
Merged

[thirdparty](patch)brpc force ssl for all connections #55658

gavinchou merged 1 commit into from
Sep 5, 2025

Conversation

@koarz
Copy link
Contributor

@koarz koarz commented Sep 4, 2025 •
edited
Loading

@Thearas
Copy link
Contributor

Thearas commented Sep 4, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@koarz
Copy link
Contributor Author

koarz commented Sep 4, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 4, 2025

TPC-H: Total hot run time: 34253 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e1c7ce326b14eaa9d0efe81802389a2d97b2f58e, data reload: false

------ Round 1 ----------------------------------
q1	17656	5215	5122	5122
q2	2005	358	205	205
q3	10229	1457	729	729
q4	10231	1025	559	559
q5	7587	2429	2380	2380
q6	187	169	135	135
q7	913	765	620	620
q8	9339	1402	1145	1145
q9	7057	5125	5246	5125
q10	6912	2418	1956	1956
q11	486	298	287	287
q12	350	376	249	249
q13	17774	3657	3064	3064
q14	242	243	225	225
q15	583	514	492	492
q16	425	428	384	384
q17	601	882	381	381
q18	7605	7067	7072	7067
q19	1225	983	578	578
q20	345	334	224	224
q21	3893	2582	2338	2338
q22	1064	1054	988	988
Total cold run time: 106709 ms
Total hot run time: 34253 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5179	5097	5141	5097
q2	252	334	233	233
q3	2205	2670	2280	2280
q4	1363	1770	1321	1321
q5	4258	4436	4641	4436
q6	227	184	136	136
q7	2095	1980	1813	1813
q8	2704	2645	2677	2645
q9	7500	7488	7496	7488
q10	3111	3304	2862	2862
q11	579	515	535	515
q12	710	781	603	603
q13	3543	3918	3353	3353
q14	286	314	301	301
q15	537	491	501	491
q16	460	526	481	481
q17	1203	1607	1364	1364
q18	7841	7657	7797	7657
q19	868	889	943	889
q20	2038	2105	1895	1895
q21	4977	4343	4261	4261
q22	1096	1046	1026	1026
Total cold run time: 53032 ms
Total hot run time: 51147 ms

@doris-robot
Copy link

doris-robot commented Sep 4, 2025

TPC-DS: Total hot run time: 187309 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e1c7ce326b14eaa9d0efe81802389a2d97b2f58e, data reload: false

query1	1086	452	420	420
query2	6588	1773	1717	1717
query3	6751	227	224	224
query4	26480	23604	23129	23129
query5	4408	639	553	553
query6	356	237	237	237
query7	4645	514	305	305
query8	308	271	262	262
query9	8646	2917	2912	2912
query10	485	347	290	290
query11	16162	15123	14782	14782
query12	173	120	128	120
query13	1673	551	439	439
query14	9272	5980	5891	5891
query15	210	192	182	182
query16	7316	690	499	499
query17	1234	798	631	631
query18	2006	423	332	332
query19	234	205	175	175
query20	139	121	126	121
query21	225	133	116	116
query22	4000	4178	4072	4072
query23	34025	33094	33212	33094
query24	8156	2368	2402	2368
query25	583	508	442	442
query26	1241	278	169	169
query27	2727	505	359	359
query28	4364	2302	2292	2292
query29	825	598	483	483
query30	294	230	198	198
query31	912	802	781	781
query32	90	78	82	78
query33	587	383	363	363
query34	796	860	543	543
query35	812	842	785	785
query36	1001	1019	935	935
query37	126	108	94	94
query38	4141	4020	4112	4020
query39	1517	1416	1445	1416
query40	242	170	132	132
query41	66	63	65	63
query42	136	122	133	122
query43	496	520	484	484
query44	1363	867	868	867
query45	182	184	177	177
query46	878	1025	655	655
query47	1759	1807	1742	1742
query48	401	457	347	347
query49	759	505	420	420
query50	650	688	418	418
query51	4083	4114	4225	4114
query52	123	127	106	106
query53	257	277	207	207
query54	624	624	545	545
query55	101	92	93	92
query56	357	357	344	344
query57	1207	1208	1157	1157
query58	301	306	296	296
query59	2562	2725	2529	2529
query60	419	355	352	352
query61	165	164	163	163
query62	822	769	649	649
query63	224	198	204	198
query64	4542	1158	855	855
query65	4276	4207	4256	4207
query66	1194	441	353	353
query67	15825	15222	15386	15222
query68	6420	931	584	584
query69	503	337	301	301
query70	1184	1174	1134	1134
query71	554	448	327	327
query72	5817	5005	5080	5005
query73	697	744	361	361
query74	8991	8949	8894	8894
query75	3191	3114	2621	2621
query76	3184	1165	735	735
query77	506	425	356	356
query78	9596	9796	8938	8938
query79	2124	839	598	598
query80	708	600	524	524
query81	515	256	233	233
query82	220	141	113	113
query83	264	263	318	263
query84	257	118	93	93
query85	858	465	439	439
query86	386	311	291	291
query87	4322	4313	4171	4171
query88	2871	2258	2238	2238
query89	418	332	296	296
query90	1916	239	235	235
query91	179	167	141	141
query92	86	78	74	74
query93	1416	991	661	661
query94	696	416	336	336
query95	420	347	336	336
query96	496	600	285	285
query97	2671	2713	2582	2582
query98	251	226	217	217
query99	1355	1429	1282	1282
Total cold run time: 271680 ms
Total hot run time: 187309 ms

@doris-robot
Copy link

doris-robot commented Sep 4, 2025

ClickBench: Total hot run time: 33.15 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e1c7ce326b14eaa9d0efe81802389a2d97b2f58e, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.06	0.07
query3	0.26	0.08	0.08
query4	1.60	0.11	0.11
query5	0.45	0.43	0.43
query6	1.20	0.65	0.63
query7	0.04	0.03	0.02
query8	0.07	0.05	0.05
query9	0.60	0.54	0.52
query10	0.59	0.59	0.58
query11	0.17	0.12	0.11
query12	0.16	0.12	0.12
query13	0.63	0.63	0.62
query14	0.81	0.84	0.83
query15	0.87	0.87	0.88
query16	0.39	0.43	0.42
query17	1.06	1.08	1.06
query18	0.22	0.20	0.20
query19	1.97	1.88	1.88
query20	0.02	0.01	0.02
query21	15.41	0.97	0.59
query22	0.81	1.07	0.75
query23	14.90	1.42	0.62
query24	6.75	1.43	0.98
query25	0.52	0.11	0.12
query26	0.73	0.17	0.13
query27	0.06	0.06	0.05
query28	9.96	0.96	0.43
query29	12.74	3.95	3.30
query30	3.11	3.07	2.91
query31	2.82	0.59	0.38
query32	3.25	0.55	0.47
query33	3.05	3.06	3.08
query34	15.82	5.51	4.92
query35	4.92	4.96	4.93
query36	0.72	0.52	0.50
query37	0.10	0.07	0.07
query38	0.06	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.14	0.15
query41	0.09	0.03	0.04
query42	0.04	0.03	0.03
query43	0.04	0.03	0.04
Total cold run time: 107.37 s
Total hot run time: 33.15 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 4, 2025

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 51.90% (17243/33222)
Line Coverage 37.30% (157338/421851)
Region Coverage 31.93% (120072/376102)
Branch Coverage 33.30% (52701/158242)

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 4, 2025

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.62% (23363/32623)
Line Coverage 58.45% (246420/421577)
Region Coverage 54.68% (208608/381490)
Branch Coverage 55.76% (88735/159142)

dataroaring
dataroaring approved these changes Sep 4, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

PR approved by anyone and no changes requested.

@gavinchou gavinchou merged commit 68eb8f0 into apache:master Sep 5, 2025
29 of 31 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 5, 2025
@koarz
[thirdparty](patch)brpc force ssl for all connections (#55658)
5552389 
pick apache/brpc#2231
@github-actions github-actions bot mentioned this pull request Sep 5, 2025
Merged
@koarz koarz deleted the brpc_force_ssl branch September 6, 2025 08:47
wenzhenghu pushed a commit to wenzhenghu/doris that referenced this pull request Sep 8, 2025
@koarz @wenzhenghu
[thirdparty](patch)brpc force ssl for all connections (apache#55658)
3a69945 
pick apache/brpc#2231
morrySnow pushed a commit that referenced this pull request Sep 8, 2025
@github-actions @koarz
branch-3.1: [thirdparty](patch)brpc force ssl for all connections #55658
3a9ab4a 
 (#55696)

Cherry-picked from #55658

Co-authored-by: koarz <lihao@selectdb.com>
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@koarz @Thearas @doris-robot @hello-stephen @gavinchou @dataroaring @morrySnow