-
Notifications
You must be signed in to change notification settings - Fork 3.7k
branch-3.1: [fix](hive)fix querying hive text table with NULL DEFINED AS '' #55626 #55661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What problem does this PR solve? Problem Summary: This pull request improves the handling of empty string null formats and delimiter properties for Hive external tables, ensuring more robust and consistent behavior when parsing data. For hive text table like this: ```sql CREATE TABLE test_empty_null_defined_text ( id INT, name STRING ) ROW FORMAT DELIMITED FIELDS TERMINATED BY '\t' NULL DEFINED AS '' STORED AS TEXTFILE; INSERT INTO TABLE test_empty_null_defined_text VALUES (1, 'Alice'), (2, NULL); ``` Query in Doris: ```sql select * from test_empty_null_defined_text; ``` Before Result: ```text +------+-------+ | id | name | +------+-------+ | 1 | Alice | | 2 | | +------+-------+ ``` After Result: ```text +------+-------+ | id | name | +------+-------+ | 1 | Alice | | 2 | NULL | +------+-------+ ```
Contributor
|
run buildall |
TPC-H: Total hot run time: 32757 ms |
TPC-DS: Total hot run time: 192440 ms |
ClickBench: Total hot run time: 28.51 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
morrySnow
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #55626