-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](virtual slot) adjust virtual column expression nullable #55694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](virtual slot) adjust virtual column expression nullable #55694
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 33853 ms |
TPC-DS: Total hot run time: 186861 ms |
ClickBench: Total hot run time: 32.5 s |
|
run buildall |
TPC-H: Total hot run time: 34004 ms |
TPC-DS: Total hot run time: 186300 ms |
ClickBench: Total hot run time: 33.29 s |
|
Why would the virtual column affect this SQL? It doesn’t seem like there’s any common subexpression. |
@zhiqiang-hhhh day(t2.c_date) exists twice in filter |
FE Regression Coverage ReportIncrement line coverage |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
…#55694) ### What problem does this PR solve? need adjust nullable for expression of the virtual slot bug introduced by: apache#52701 example as follow: SQL: ```sql SELECT t1.*, t2.* FROM tbl_adjust_virtual_slot_nullable_1 AS t1 LEFT JOIN tbl_adjust_virtual_slot_nullable_2 AS t2 ON t1.c_int = t2.c_int WHERE NOT ( day(t2.c_date) IN (1, 3) AND day(t2.c_date) IN (2, 3, 3) ); ``` throw exception: ``` java.sql.SQLException: errCode = 2, detailMessage = (127.0.0.1)[INTERNAL_ERROR]Could not find function dayofmonth, arg c_date return Nullable(TINYINT) ```
What problem does this PR solve?
need adjust nullable for expression of the virtual slot
bug introduced by: #52701
example as follow:
SQL:
throw exception:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)