Skip to content

[External](parquet) pass non predicates column's offset index to RowGroupReader #55795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 1 commit into from
Oct 23, 2025
Merged

[External](parquet) pass non predicates column's offset index to RowGroupReader #55795

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions be/src/vec/exec/format/parquet/vparquet_reader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1081,10 +1081,6 @@ Status ParquetReader::_process_page_index(const tparquet::RowGroup& row_group,
continue;
}
auto slot_id = _colname_to_slot_id->at(read_table_col);
if (!_push_down_simple_expr.contains(slot_id)) {
continue;
}
const auto& push_down_expr = _push_down_simple_expr[slot_id];

int parquet_col_id =
_file_metadata->schema().get_column(read_file_col)->physical_column_index;
Expand All @@ -1093,6 +1089,19 @@ Status ParquetReader::_process_page_index(const tparquet::RowGroup& row_group,
continue;
}
auto& chunk = row_group.columns[parquet_col_id];

if (chunk.offset_index_length == 0) {
continue;
}
tparquet::OffsetIndex offset_index;
RETURN_IF_ERROR(page_index.parse_offset_index(chunk, off_index_buff.data(), &offset_index));
_col_offsets[parquet_col_id] = offset_index;

if (!_push_down_simple_expr.contains(slot_id)) {
continue;
}
const auto& push_down_expr = _push_down_simple_expr[slot_id];

if (chunk.column_index_offset == 0 && chunk.column_index_length == 0) {
continue;
}
Expand Down Expand Up @@ -1132,16 +1141,13 @@ Status ParquetReader::_process_page_index(const tparquet::RowGroup& row_group,
if (skipped_page_range.empty()) {
continue;
}
tparquet::OffsetIndex offset_index;
RETURN_IF_ERROR(page_index.parse_offset_index(chunk, off_index_buff.data(), &offset_index));
for (int page_id : skipped_page_range) {
RowRange skipped_row_range;
RETURN_IF_ERROR(page_index.create_skipped_row_range(offset_index, row_group.num_rows,
page_id, &skipped_row_range));
// use the union row range
skipped_row_ranges.emplace_back(skipped_row_range);
}
_col_offsets[parquet_col_id] = offset_index;
}
if (skipped_row_ranges.empty()) {
read_whole_row_group();
Expand Down
Loading