Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions be/src/pipeline/pipeline_task.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,9 @@ PipelineTask::PipelineTask(PipelinePtr& pipeline, uint32_t task_id, RuntimeState
_task_idx(task_idx),
_memory_sufficient_dependency(state->get_query_ctx()->get_memory_sufficient_dependency()),
_pipeline_name(_pipeline->name()) {
#ifndef BE_TEST
_query_mem_tracker = fragment_context->get_query_ctx()->query_mem_tracker();
#endif
_execution_dependencies.push_back(state->get_query_ctx()->get_execution_dependency());
if (!_shared_state_map.contains(_sink->dests_id().front())) {
auto shared_state = _sink->create_shared_state();
Expand All @@ -90,6 +93,24 @@ PipelineTask::PipelineTask(PipelinePtr& pipeline, uint32_t task_id, RuntimeState
}
}

PipelineTask::~PipelineTask() {
// PipelineTask is also hold by task queue( https://github.com/apache/doris/pull/49753),
// so that it maybe the last one to be destructed.
// But pipeline task hold some objects, like operators, shared state, etc. So that should release
// memory manually.
#ifndef BE_TEST
SCOPED_SWITCH_THREAD_MEM_TRACKER_LIMITER(_query_mem_tracker);
#endif
_shared_state_map.clear();
_sink_shared_state.reset();
_op_shared_states.clear();
_sink.reset();
_operators.clear();
_spill_context.reset();
_block.reset();
_pipeline.reset();
}

Status PipelineTask::prepare(const std::vector<TScanRangeParams>& scan_range, const int sender_id,
const TDataSink& tsink) {
DCHECK(_sink);
Expand Down
4 changes: 4 additions & 0 deletions be/src/pipeline/pipeline_task.h
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ class PipelineTask : public std::enable_shared_from_this<PipelineTask> {
shared_state_map,
int task_idx);

~PipelineTask();

Status prepare(const std::vector<TScanRangeParams>& scan_range, const int sender_id,
const TDataSink& tsink);

Expand Down Expand Up @@ -259,6 +261,8 @@ class PipelineTask : public std::enable_shared_from_this<PipelineTask> {
std::atomic<bool> _running {false};
std::atomic<bool> _eos {false};
std::atomic<bool> _wake_up_early {false};
// PipelineTask maybe hold by TaskQueue
std::shared_ptr<MemTrackerLimiter> _query_mem_tracker;

/**
*
Expand Down
Loading