Skip to content

branch-3.1: [fix](variant) Compatibility error when the sparse column is empty #55817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morrySnow merged 1 commit into from
Sep 11, 2025
Merged

branch-3.1: [fix](variant) Compatibility error when the sparse column is empty #55817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions be/src/olap/rowset/segment_v2/variant/variant_column_reader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,11 @@ Status VariantColumnReader::_new_iterator_with_flat_leaves(ColumnIteratorUPtr* i
target_col.has_path_info() ? _subcolumns_meta_info->find_leaf(relative_path) : nullptr;
if (!node) {
if (relative_path.get_path() == SPARSE_COLUMN_PATH) {
if (_sparse_column_reader == nullptr) {
return Status::InternalError(
"Sparse column reader is not initialize, variant column is: {}",
target_col.path_info_ptr()->get_path());
}
// read sparse column and filter extracted columns in subcolumn_path_map
std::unique_ptr<ColumnIterator> inner_iter;
RETURN_IF_ERROR(_sparse_column_reader->new_iterator(&inner_iter, nullptr));
Expand Down
8 changes: 8 additions & 0 deletions be/test/olap/rowset/segment_v2/variant_column_writer_reader_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,6 +715,14 @@ TEST_F(VariantColumnWriterReaderTest, test_write_data_normal) {
EXPECT_TRUE(st.ok()) << st.msg();
EXPECT_TRUE(assert_cast<DefaultValueColumnIterator*>(it7.get()) != nullptr);
EXPECT_TRUE(io::global_local_filesystem()->delete_directory(_tablet->tablet_path()).ok());

// 20. check sparse column reader is nullptr
ColumnIteratorUPtr it_error;
variant_column_reader->_sparse_column_reader = nullptr;
st = variant_column_reader->new_iterator(&it_error, &sparse_column, &storage_read_opts,
&column_reader_cache);
EXPECT_FALSE(st.ok()) << st.msg();
EXPECT_TRUE(it_error == nullptr);
}

TEST_F(VariantColumnWriterReaderTest, test_write_data_advanced) {
Expand Down
Loading