Fix(Variant) Fix null value handling when serializing to JSON string #55876
+73
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
eldenmoon
force-pushed
the
fix-serde-json
branch
from
ebce83d to
f5ffb25
Compare
Member
Author
|
run buildall |
TPC-H: Total hot run time: 34569 ms |
TPC-DS: Total hot run time: 189453 ms |
ClickBench: Total hot run time: 30.11 s |
eldenmoon
force-pushed
the
fix-serde-json
branch
from
f5ffb25 to
5a78c90
Compare
Member
Author
|
run buildall |
TPC-H: Total hot run time: 34713 ms |
TPC-DS: Total hot run time: 189454 ms |
ClickBench: Total hot run time: 29.78 s |
eldenmoon
force-pushed
the
fix-serde-json
branch
from
5a78c90 to
83b0cfd
Compare
Member
Author
|
run buildall |
TPC-H: Total hot run time: 34603 ms |
TPC-DS: Total hot run time: 189490 ms |
ClickBench: Total hot run time: 30.04 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Problem:
When Variant data is NULL or its root is empty, serializing it
to JSON would incorrectly produce '\N' or other unexpected
results. The standard JSON format expects a 'null' literal or
an empty object '{}' for such cases.
Solution:
This commit addresses the issue with the following changes:
1. In `HierarchicalDataIterator`, when a Variant's root data
is empty, it is now explicitly marked as NULL in the null map.
2. The JSON serialization logic in
`ColumnVariant::serialize_text_json` is modified to serialize a
NULL sub-column as an empty JSON object '{}' instead of '\N'.
3. The logic in `is_visible_root_value` is updated to rely on
the null flag rather than checking if the data content is
empty, providing a more accurate reflection of the value's
existence.
These changes ensure that the Variant type produces correct and
expected JSON output when serializing null or empty data.
Corresponding regression tests have also been added to cover
scenarios involving NULL and empty JSON objects.
eldenmoon
force-pushed
the
fix-serde-json
branch
from
83b0cfd to
f0a6aab
Compare
Member
Author
|
run buildall |
TPC-H: Total hot run time: 34613 ms |
TPC-DS: Total hot run time: 190068 ms |
ClickBench: Total hot run time: 29.54 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
eldenmoon
changed the title
serialize_one_cell_to_json should result 'null' instead of '\\N' when cell is empty
eldenmoon
changed the title
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Member
Author
|
run p0 10 |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Sep 17, 2025
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Sep 17, 2025
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Sep 17, 2025
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Sep 17, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Problem:
When Variant data is NULL or its root is empty, serializing it
to JSON would incorrectly produce '\N' or other unexpected
results. The standard JSON format expects a 'null' literal or
an empty object '{}' for such cases.
Solution:
This commit addresses the issue with the following changes:
1. In
HierarchicalDataIterator, when a Variant's root datais empty, it is now explicitly marked as NULL in the null map.
2. The JSON serialization logic in
ColumnVariant::serialize_text_jsonis modified to serialize aNULL sub-column as an empty JSON object '{}' instead of '\N'.
3. The logic in
is_visible_root_valueis updated to rely onthe null flag rather than checking if the data content is
empty, providing a more accurate reflection of the value's
existence.
These changes ensure that the Variant type produces correct and
expected JSON output when serializing null or empty data.
Corresponding regression tests have also been added to cover
scenarios involving NULL and empty JSON objects.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)