Skip to content

branch-3.0: [fix](http stream) http stream should throw exception if parse sql failed #55863 #55890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Sep 11, 2025
Merged

branch-3.0: [fix](http stream) http stream should throw exception if parse sql failed #55863 #55890

dataroaring merged 1 commit into from
Sep 11, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Sep 11, 2025

Cherry-picked from #55863

@mymeiyi
[fix](http stream) http stream should throw exception if parse sql fa…
856ff88 
…iled (#55863)

Problem Summary:
if http stream parse sql failed, the exception is ignored and continue
execute, then throw exception:
```
    "Message": "[ANALYSIS_ERROR]TStatus: errCode = 2, detailMessage = exec sql error catch unknown result.java.lang.NullPointerException: Cannot invoke \"org.apache.doris.planner.Planner.getFragments()\" because \"planner\" is null"
```
@Thearas
Copy link
Contributor

Thearas commented Sep 11, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Sep 11, 2025
@Thearas
Copy link
Contributor

Thearas commented Sep 11, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 11, 2025

TPC-H: Total hot run time: 40472 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 856ff886fa5df006976dbb172782d5de8dc1ae33, data reload: false

------ Round 1 ----------------------------------
q1	17668	6871	6716	6716
q2	2032	192	189	189
q3	10641	1153	1204	1153
q4	10396	767	727	727
q5	7724	2916	2838	2838
q6	216	134	135	134
q7	997	627	628	627
q8	9369	2016	2100	2016
q9	6697	6423	6460	6423
q10	7036	2255	2327	2255
q11	471	275	270	270
q12	419	228	229	228
q13	17787	3028	2997	2997
q14	248	207	212	207
q15	516	463	458	458
q16	479	380	381	380
q17	1007	571	605	571
q18	7211	6710	6680	6680
q19	1412	1129	1076	1076
q20	476	210	209	209
q21	4039	3343	3395	3343
q22	1124	979	975	975
Total cold run time: 107965 ms
Total hot run time: 40472 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6616	6603	6716	6603
q2	340	241	250	241
q3	3053	3052	3055	3052
q4	2137	1896	1878	1878
q5	5823	5857	5766	5766
q6	218	140	140	140
q7	2219	1871	1788	1788
q8	3421	3593	3503	3503
q9	8976	8931	8936	8931
q10	3594	3559	3538	3538
q11	600	518	501	501
q12	797	628	640	628
q13	7534	3167	3216	3167
q14	305	277	269	269
q15	526	473	473	473
q16	529	455	442	442
q17	1867	1657	1652	1652
q18	8322	7746	7801	7746
q19	1675	1500	1594	1500
q20	2158	1870	1932	1870
q21	5415	5032	5039	5032
q22	1198	1047	1038	1038
Total cold run time: 67323 ms
Total hot run time: 59758 ms

@doris-robot
Copy link

doris-robot commented Sep 11, 2025

TPC-DS: Total hot run time: 192802 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 856ff886fa5df006976dbb172782d5de8dc1ae33, data reload: false

query1	939	396	371	371
query2	6277	1963	1868	1868
query3	8682	207	198	198
query4	33302	23673	23568	23568
query5	3519	469	444	444
query6	275	184	203	184
query7	4208	312	313	312
query8	286	212	231	212
query9	9562	2593	2582	2582
query10	485	276	270	270
query11	18362	15357	15338	15338
query12	159	103	107	103
query13	1547	441	422	422
query14	9603	6689	6580	6580
query15	240	176	181	176
query16	7978	479	496	479
query17	1627	655	598	598
query18	2147	349	361	349
query19	257	172	169	169
query20	124	119	114	114
query21	204	110	110	110
query22	4751	4585	4528	4528
query23	35382	34467	33910	33910
query24	11763	2965	2980	2965
query25	698	451	442	442
query26	1575	182	185	182
query27	2846	351	368	351
query28	7691	2208	2209	2208
query29	1021	463	462	462
query30	269	169	164	164
query31	1066	822	847	822
query32	104	58	66	58
query33	788	332	309	309
query34	993	540	541	540
query35	866	742	739	739
query36	1123	959	955	955
query37	137	68	70	68
query38	4100	3924	3972	3924
query39	1526	1533	1485	1485
query40	267	106	120	106
query41	52	49	53	49
query42	115	102	103	102
query43	535	496	472	472
query44	1356	828	832	828
query45	191	171	169	169
query46	1209	739	749	739
query47	2003	1884	1905	1884
query48	480	380	389	380
query49	1059	409	400	400
query50	843	434	443	434
query51	7575	7284	7138	7138
query52	108	96	93	93
query53	268	186	196	186
query54	1333	481	485	481
query55	84	80	76	76
query56	276	264	256	256
query57	1337	1235	1192	1192
query58	232	212	216	212
query59	3145	3115	2973	2973
query60	315	269	274	269
query61	119	119	114	114
query62	860	707	702	702
query63	229	203	205	203
query64	4930	683	691	683
query65	3427	3331	3350	3331
query66	1504	329	323	323
query67	16410	15530	15702	15530
query68	4436	581	584	581
query69	443	271	266	266
query70	1187	1129	1118	1118
query71	372	258	259	258
query72	6291	4092	4120	4092
query73	785	353	362	353
query74	10597	9036	9043	9036
query75	3400	2647	2677	2647
query76	2749	1115	1165	1115
query77	401	285	284	284
query78	10546	9645	9547	9547
query79	2225	609	603	603
query80	1060	447	445	445
query81	549	220	227	220
query82	615	90	88	88
query83	234	143	142	142
query84	234	83	81	81
query85	1337	311	303	303
query86	462	305	303	303
query87	4405	4270	4269	4269
query88	3820	2405	2376	2376
query89	409	294	296	294
query90	1938	187	190	187
query91	207	153	178	153
query92	64	52	55	52
query93	2435	571	561	561
query94	838	303	303	303
query95	375	268	258	258
query96	655	279	284	279
query97	3357	3210	3201	3201
query98	220	201	203	201
query99	1505	1331	1302	1302
Total cold run time: 304895 ms
Total hot run time: 192802 ms

@doris-robot
Copy link

doris-robot commented Sep 11, 2025

ClickBench: Total hot run time: 29.89 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 856ff886fa5df006976dbb172782d5de8dc1ae33, data reload: false

query1	0.03	0.02	0.03
query2	0.06	0.03	0.03
query3	0.23	0.06	0.06
query4	1.63	0.11	0.11
query5	0.51	0.51	0.52
query6	1.15	0.73	0.73
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.57	0.50	0.50
query10	0.54	0.54	0.56
query11	0.15	0.10	0.10
query12	0.15	0.11	0.11
query13	0.61	0.60	0.60
query14	0.78	0.82	0.80
query15	0.84	0.83	0.84
query16	0.38	0.38	0.39
query17	1.03	0.98	1.02
query18	0.25	0.21	0.24
query19	1.91	1.84	1.89
query20	0.01	0.01	0.01
query21	15.38	0.60	0.59
query22	2.21	2.36	2.13
query23	17.13	0.93	0.74
query24	4.00	1.78	0.39
query25	0.22	0.05	0.16
query26	0.61	0.14	0.14
query27	0.05	0.04	0.04
query28	9.67	0.54	0.46
query29	12.61	3.22	3.17
query30	0.25	0.06	0.06
query31	2.85	0.41	0.38
query32	3.22	0.46	0.46
query33	3.05	3.01	3.05
query34	17.08	4.57	4.57
query35	4.62	4.53	4.61
query36	0.68	0.49	0.47
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.12	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 105 s
Total hot run time: 29.89 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 11, 2025

FE UT Coverage Report

Increment line coverage 0.00% (0/7) 🎉
Increment coverage report
Complete coverage report

dataroaring
dataroaring approved these changes Sep 11, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit f587a44 into branch-3.0 Sep 11, 2025
25 of 26 checks passed
@github-actions github-actions bot deleted the auto-pick-55863-branch-3.0 branch September 11, 2025 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Thearas @doris-robot @hello-stephen @dataroaring @mymeiyi