Skip to content

branch-3.1: [fix](http stream) http stream should throw exception if parse sql failed #55863 #55891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Sep 12, 2025
Merged

branch-3.1: [fix](http stream) http stream should throw exception if parse sql failed #55863 #55891

morrySnow merged 1 commit into from
Sep 12, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Sep 11, 2025

Cherry-picked from #55863

@mymeiyi
[fix](http stream) http stream should throw exception if parse sql fa…
d1cc98d 
…iled (#55863)

Problem Summary:
if http stream parse sql failed, the exception is ignored and continue
execute, then throw exception:
```
    "Message": "[ANALYSIS_ERROR]TStatus: errCode = 2, detailMessage = exec sql error catch unknown result.java.lang.NullPointerException: Cannot invoke \"org.apache.doris.planner.Planner.getFragments()\" because \"planner\" is null"
```
@github-actions github-actions bot requested a review from morrySnow as a code owner September 11, 2025 01:06
@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 11, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Sep 11, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 11, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 11, 2025

TPC-H: Total hot run time: 32469 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d1cc98d98013600cd03833955256a00b9848d3de, data reload: false

------ Round 1 ----------------------------------
q1	17589	5483	5318	5318
q2	2018	409	280	280
q3	12113	1262	749	749
q4	10313	869	443	443
q5	9409	2337	2113	2113
q6	188	165	133	133
q7	889	728	617	617
q8	9332	1428	1181	1181
q9	5177	4927	4891	4891
q10	6778	2234	1827	1827
q11	494	300	256	256
q12	333	353	209	209
q13	17791	3604	3032	3032
q14	225	219	213	213
q15	531	464	456	456
q16	426	417	368	368
q17	605	848	349	349
q18	6908	6406	6337	6337
q19	1222	947	546	546
q20	336	333	202	202
q21	2730	2385	1982	1982
q22	1029	1009	967	967
Total cold run time: 106436 ms
Total hot run time: 32469 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5473	5466	5513	5466
q2	234	325	237	237
q3	2241	2610	2377	2377
q4	1374	1787	1437	1437
q5	4386	4952	5075	4952
q6	176	159	132	132
q7	2117	2011	1861	1861
q8	2657	2877	2770	2770
q9	7427	7382	7212	7212
q10	3029	3338	2707	2707
q11	560	506	496	496
q12	647	747	612	612
q13	3435	3728	3139	3139
q14	293	303	265	265
q15	540	474	467	467
q16	433	499	428	428
q17	1209	1745	1236	1236
q18	7532	7407	7456	7407
q19	813	1089	1096	1089
q20	2014	2069	1909	1909
q21	5167	4939	4680	4680
q22	1058	1020	1005	1005
Total cold run time: 52815 ms
Total hot run time: 51884 ms

@doris-robot
Copy link

doris-robot commented Sep 11, 2025

TPC-DS: Total hot run time: 191537 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d1cc98d98013600cd03833955256a00b9848d3de, data reload: false

query1	959	405	414	405
query2	6215	1892	1822	1822
query3	8686	204	204	204
query4	33557	23801	23452	23452
query5	3652	625	449	449
query6	309	187	162	162
query7	4186	488	319	319
query8	301	237	228	228
query9	9600	2639	2613	2613
query10	479	337	260	260
query11	18204	15474	15256	15256
query12	164	105	107	105
query13	1552	540	417	417
query14	9081	7220	6608	6608
query15	245	185	179	179
query16	8048	679	511	511
query17	1585	770	608	608
query18	2135	431	346	346
query19	228	194	167	167
query20	124	129	133	129
query21	210	127	109	109
query22	4516	4495	4386	4386
query23	34854	34331	34105	34105
query24	7284	2735	2742	2735
query25	558	511	441	441
query26	1226	291	167	167
query27	2645	465	367	367
query28	5620	2223	2216	2216
query29	793	604	461	461
query30	242	194	163	163
query31	1101	930	844	844
query32	87	56	58	56
query33	506	380	352	352
query34	771	884	538	538
query35	812	811	722	722
query36	1029	1089	951	951
query37	103	93	68	68
query38	4039	3942	3994	3942
query39	1530	1508	1490	1490
query40	207	122	108	108
query41	49	50	48	48
query42	132	109	105	105
query43	497	524	485	485
query44	1324	843	816	816
query45	187	179	174	174
query46	900	1077	676	676
query47	1980	1999	1940	1940
query48	416	435	354	354
query49	761	506	392	392
query50	689	708	434	434
query51	7301	7291	7151	7151
query52	104	104	95	95
query53	224	269	205	205
query54	549	556	466	466
query55	78	81	79	79
query56	266	283	256	256
query57	1298	1265	1221	1221
query58	246	221	235	221
query59	3050	3172	2921	2921
query60	304	290	274	274
query61	125	113	113	113
query62	795	761	694	694
query63	232	191	185	185
query64	4746	1000	645	645
query65	3395	3302	3307	3302
query66	967	413	314	314
query67	16708	16082	15619	15619
query68	7526	827	533	533
query69	490	307	271	271
query70	1180	1130	1095	1095
query71	425	297	263	263
query72	5147	3765	3998	3765
query73	627	745	349	349
query74	10279	9433	8961	8961
query75	3799	3195	2636	2636
query76	3599	1193	762	762
query77	776	360	288	288
query78	10182	10392	9535	9535
query79	6530	873	587	587
query80	647	528	429	429
query81	485	256	217	217
query82	229	123	91	91
query83	170	165	140	140
query84	282	104	78	78
query85	752	363	306	306
query86	349	319	301	301
query87	4338	4339	4184	4184
query88	4317	2425	2414	2414
query89	427	334	300	300
query90	2050	193	186	186
query91	130	139	109	109
query92	62	57	51	51
query93	3845	875	533	533
query94	656	406	312	312
query95	339	275	259	259
query96	493	619	286	286
query97	3213	3272	3141	3141
query98	234	204	201	201
query99	1513	1396	1308	1308
Total cold run time: 299857 ms
Total hot run time: 191537 ms

@doris-robot
Copy link

doris-robot commented Sep 11, 2025

ClickBench: Total hot run time: 28.76 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d1cc98d98013600cd03833955256a00b9848d3de, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.06	0.07
query4	1.63	0.11	0.10
query5	0.50	0.52	0.52
query6	1.14	0.73	0.72
query7	0.02	0.01	0.01
query8	0.04	0.04	0.03
query9	0.57	0.51	0.49
query10	0.53	0.55	0.55
query11	0.15	0.11	0.11
query12	0.14	0.11	0.12
query13	0.60	0.59	0.60
query14	0.77	0.78	0.79
query15	0.84	0.82	0.84
query16	0.38	0.40	0.38
query17	1.01	0.99	1.04
query18	0.24	0.21	0.21
query19	1.88	1.87	1.88
query20	0.01	0.02	0.01
query21	15.42	0.97	0.59
query22	0.74	0.74	0.58
query23	15.25	1.43	0.60
query24	3.14	1.44	0.86
query25	0.27	0.04	0.08
query26	0.29	0.15	0.14
query27	0.04	0.04	0.04
query28	13.85	0.98	0.43
query29	12.55	3.93	3.26
query30	0.25	0.09	0.07
query31	2.82	0.60	0.38
query32	3.22	0.54	0.47
query33	3.01	3.03	3.05
query34	16.56	5.23	4.54
query35	4.58	4.53	4.60
query36	0.64	0.51	0.48
query37	0.09	0.06	0.06
query38	0.04	0.03	0.04
query39	0.03	0.02	0.03
query40	0.17	0.14	0.12
query41	0.08	0.03	0.03
query42	0.03	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 103.88 s
Total hot run time: 28.76 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 11, 2025

FE UT Coverage Report

Increment line coverage 0.00% (0/7) 🎉
Increment coverage report
Complete coverage report

@morrySnow morrySnow merged commit bd38508 into branch-3.1 Sep 12, 2025
23 checks passed
@morrySnow morrySnow deleted the auto-pick-55863-branch-3.1 branch September 12, 2025 02:42
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hello-stephen @doris-robot @morrySnow @dataroaring @mymeiyi