Skip to content

Conversation

@kaka11chen
Copy link
Contributor

@kaka11chen kaka11chen commented Sep 11, 2025

What problem does this PR solve?

Problem Summary:

Release note

Fix paimon native-reader don't use late materialization because of push_down_predicates checking is incorrect.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Sep 11, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@kaka11chen
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34829 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7baf2dea44b4208e4478f503f733bbf3eb07f5a4, data reload: false

------ Round 1 ----------------------------------
q1	17621	5250	5114	5114
q2	1992	355	218	218
q3	10244	1318	734	734
q4	10220	1031	523	523
q5	7541	2400	2340	2340
q6	183	167	136	136
q7	926	766	647	647
q8	9365	1378	1115	1115
q9	7061	5165	5110	5110
q10	6895	2413	1977	1977
q11	488	310	288	288
q12	346	369	227	227
q13	17766	3754	3063	3063
q14	252	254	219	219
q15	548	488	487	487
q16	1028	1011	938	938
q17	618	858	376	376
q18	7415	7170	7168	7168
q19	1233	977	550	550
q20	349	331	229	229
q21	3806	3218	2372	2372
q22	1066	1038	998	998
Total cold run time: 106963 ms
Total hot run time: 34829 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5133	5056	5085	5056
q2	242	339	238	238
q3	2236	2711	2325	2325
q4	1332	1807	1330	1330
q5	4259	4678	4648	4648
q6	228	177	138	138
q7	2092	1993	1835	1835
q8	2665	2583	2702	2583
q9	7424	7658	7189	7189
q10	3097	3296	2890	2890
q11	588	525	519	519
q12	750	857	654	654
q13	3585	4032	3233	3233
q14	313	327	294	294
q15	533	503	510	503
q16	1144	1132	1058	1058
q17	1221	1507	1442	1442
q18	8034	7754	7634	7634
q19	832	854	884	854
q20	2122	2049	1927	1927
q21	4967	4364	4445	4364
q22	1068	1049	999	999
Total cold run time: 53865 ms
Total hot run time: 51713 ms

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 51.97% (17303/33296)
Line Coverage 37.31% (157693/422642)
Region Coverage 31.95% (120325/376628)
Branch Coverage 33.32% (52819/158505)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.69% (23439/32695)
Line Coverage 58.61% (247550/422388)
Region Coverage 54.74% (209140/382057)
Branch Coverage 55.86% (89052/159408)

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 11, 2025
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.69% (23439/32695)
Line Coverage 58.61% (247563/422388)
Region Coverage 54.74% (209150/382057)
Branch Coverage 55.87% (89057/159408)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.9-merged dev/3.1.1-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants