Skip to content

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Sep 12, 2025

What problem does this PR solve?

fix coredump introduced in #54284

*** Query id: 0-0 ***
*** is nereids: 0 ***
*** tablet id: 0 ***
*** Aborted at 1757323304 (unix time) try "date -d @1757323304" if you are using GNU date ***
*** Current BE git commitID: e2bdf54ae16 ***
*** SIGFPE integer divide by zero (@0x562de1b7030d) received by PID 5468 (TID 5727 OR 0x7f480ebd7640) from PID 18446744073201451789; stack trace: ***
*** stack smashing detected ***: terminated
*** stack smashing detected ***: terminated
 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /home/zcp/repo_center/doris_master/doris/be/src/common/signal_handler.h:420
 1# PosixSignals::chained_handler(int, siginfo*, void*) [clone .part.0] in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so
 2# JVM_handle_linux_signal in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so
 3# 0x00007F493CE5F520 in /lib/x86_64-linux-gnu/libc.so.6
 4# std::_Hashtable<doris::RowsetId, std::pair<doris::RowsetId const, doris::CloudTablet::RowsetWarmUpInfo>, std::allocator<std::pair<doris::RowsetId const, doris::CloudTablet::RowsetWarmUpInfo> >, std::__detail::_Select1st, std::equal_to<doris::RowsetId>, std::hash<doris::RowsetId>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::_M_locate(doris::RowsetId const&) const at /usr/local/ldb-toolchain-v0.26/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/hashtable.h:2280
 5# doris::CloudTablet::complete_rowset_segment_warmup(doris::RowsetId, doris::Status) at /home/zcp/repo_center/doris_master/doris/be/src/cloud/cloud_tablet.cpp:1630
 6# std::_Function_handler<void (doris::Status), doris::CloudInternalServiceImpl::warm_up_rowset(google::protobuf::RpcController*, doris::PWarmUpRowsetRequest const*, doris::PWarmUpRowsetResponse*, google::protobuf::Closure*)::$_0>::_M_invoke(std::_Any_data const&, doris::Status&&) at /usr/local/ldb-toolchain-v0.26/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/std_function.h:292
 7# doris::io::FileCacheBlockDownloader::download_segment_file(doris::io::DownloadFileMeta const&) at /home/zcp/repo_center/doris_master/doris/be/src/io/cache/block_file_cache_downloader.cpp:297
 8# doris::ThreadPool::dispatch_thread() at /home/zcp/repo_center/doris_master/doris/be/src/util/threadpool.cpp:621
 9# doris::Thread::supervise_thread(void*) at /home/zcp/repo_center/doris_master/doris/be/src/util/thread.cpp:461
10# start_thread at ./nptl/pthread_create.c:442
11# 0x00007F493CF43850 at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:83

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@bobhan1 bobhan1 requested a review from morrySnow as a code owner September 12, 2025 02:08
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@bobhan1 bobhan1 force-pushed the branch-3.1-fix-core-54284 branch from 239720a to 193cb64 Compare September 12, 2025 02:12
@bobhan1
Copy link
Contributor Author

bobhan1 commented Sep 12, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32498 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 193cb64fe5b452c75d0e8b8e6c522102f5aaf859, data reload: false

------ Round 1 ----------------------------------
q1	17584	5573	5441	5441
q2	2017	387	282	282
q3	12330	1220	739	739
q4	10555	866	452	452
q5	9384	2350	2085	2085
q6	179	164	138	138
q7	886	738	618	618
q8	9327	1410	1124	1124
q9	5200	4949	4861	4861
q10	6750	2249	1803	1803
q11	473	288	265	265
q12	346	357	219	219
q13	17779	3632	3041	3041
q14	223	222	219	219
q15	516	465	457	457
q16	414	429	371	371
q17	596	859	365	365
q18	6772	6299	6187	6187
q19	1203	956	562	562
q20	321	336	224	224
q21	3056	2176	2000	2000
q22	1071	1045	1068	1045
Total cold run time: 106982 ms
Total hot run time: 32498 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5509	5422	5421	5421
q2	242	333	242	242
q3	2312	2735	2401	2401
q4	1354	1832	1402	1402
q5	4553	5055	5117	5055
q6	175	166	132	132
q7	2119	2031	1900	1900
q8	2651	2847	2752	2752
q9	7403	7388	7333	7333
q10	3055	3259	2778	2778
q11	595	533	491	491
q12	725	780	588	588
q13	3367	3730	3140	3140
q14	297	318	290	290
q15	509	478	472	472
q16	448	474	430	430
q17	1217	1738	1268	1268
q18	7566	7422	7181	7181
q19	828	1086	1115	1086
q20	2024	2052	1873	1873
q21	5296	4923	4586	4586
q22	1094	1057	1040	1040
Total cold run time: 53339 ms
Total hot run time: 51861 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192460 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 193cb64fe5b452c75d0e8b8e6c522102f5aaf859, data reload: false

query1	961	391	382	382
query2	6221	1891	1857	1857
query3	8686	204	217	204
query4	33471	23747	23575	23575
query5	3574	593	446	446
query6	291	197	186	186
query7	4205	483	327	327
query8	313	250	240	240
query9	9377	2623	2607	2607
query10	467	313	248	248
query11	18173	15261	15286	15261
query12	160	107	101	101
query13	1545	526	415	415
query14	9661	7185	7117	7117
query15	240	192	178	178
query16	8140	639	522	522
query17	1562	779	619	619
query18	2169	421	332	332
query19	239	193	161	161
query20	125	119	123	119
query21	211	126	105	105
query22	4659	4570	4429	4429
query23	35181	34213	33925	33925
query24	7513	2706	2690	2690
query25	551	492	429	429
query26	855	292	186	186
query27	1928	480	367	367
query28	5192	2214	2182	2182
query29	722	611	467	467
query30	246	189	163	163
query31	987	956	842	842
query32	99	62	63	62
query33	501	383	325	325
query34	753	874	527	527
query35	823	826	726	726
query36	1044	1100	952	952
query37	104	99	70	70
query38	4112	4015	3942	3942
query39	1530	1471	1454	1454
query40	200	116	103	103
query41	47	48	48	48
query42	125	113	108	108
query43	524	510	474	474
query44	1290	830	829	829
query45	185	187	173	173
query46	881	1073	666	666
query47	2028	2011	1939	1939
query48	422	428	365	365
query49	722	488	408	408
query50	663	691	420	420
query51	7414	7237	7256	7237
query52	102	107	92	92
query53	232	264	204	204
query54	551	558	467	467
query55	82	88	83	83
query56	261	266	282	266
query57	1290	1280	1223	1223
query58	231	244	215	215
query59	3105	3079	2967	2967
query60	294	298	269	269
query61	109	115	119	115
query62	782	740	691	691
query63	242	195	189	189
query64	3808	987	625	625
query65	3398	3327	3308	3308
query66	800	411	312	312
query67	16659	15899	15666	15666
query68	7670	821	537	537
query69	489	303	281	281
query70	1191	1131	1152	1131
query71	436	304	272	272
query72	5180	3801	3773	3773
query73	655	752	353	353
query74	10524	9116	9205	9116
query75	3938	3114	2689	2689
query76	3488	1170	763	763
query77	770	370	276	276
query78	10314	10419	9615	9615
query79	3383	874	592	592
query80	746	514	429	429
query81	479	259	219	219
query82	349	118	91	91
query83	164	161	157	157
query84	280	103	76	76
query85	737	359	287	287
query86	341	305	305	305
query87	4338	4284	4230	4230
query88	3282	2424	2390	2390
query89	426	331	293	293
query90	1989	188	185	185
query91	130	137	107	107
query92	65	57	52	52
query93	2111	862	531	531
query94	633	413	288	288
query95	343	275	266	266
query96	487	600	286	286
query97	3211	3297	3174	3174
query98	221	205	195	195
query99	1546	1440	1299	1299
Total cold run time: 292954 ms
Total hot run time: 192460 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.22 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 193cb64fe5b452c75d0e8b8e6c522102f5aaf859, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.06	0.07
query4	1.63	0.11	0.10
query5	0.52	0.52	0.51
query6	1.13	0.71	0.73
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.57	0.50	0.50
query10	0.54	0.54	0.55
query11	0.15	0.13	0.10
query12	0.14	0.11	0.10
query13	0.61	0.60	0.58
query14	0.79	0.80	0.82
query15	0.85	0.82	0.84
query16	0.38	0.41	0.39
query17	1.07	1.03	1.05
query18	0.24	0.22	0.22
query19	1.91	1.88	1.86
query20	0.02	0.01	0.01
query21	15.38	0.92	0.59
query22	0.75	0.81	0.60
query23	15.14	1.41	0.58
query24	3.02	1.81	1.13
query25	0.13	0.13	0.24
query26	0.16	0.14	0.13
query27	0.04	0.05	0.04
query28	14.16	1.00	0.44
query29	12.58	3.86	3.26
query30	0.27	0.09	0.06
query31	2.82	0.61	0.37
query32	3.22	0.54	0.47
query33	2.97	3.06	3.03
query34	16.74	5.20	4.62
query35	4.55	4.56	4.57
query36	0.67	0.51	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.16	0.14	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.02	0.03
Total cold run time: 104 s
Total hot run time: 29.22 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.54% (12761/28023)
Line Coverage 36.37% (113763/312824)
Region Coverage 34.00% (65062/191376)
Branch Coverage 31.03% (34143/110046)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/18) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.47% (21076/27561)
Line Coverage 69.73% (217472/311856)
Region Coverage 67.64% (129966/192153)
Branch Coverage 61.11% (67563/110560)

@morrySnow morrySnow merged commit 454e93a into apache:branch-3.1 Sep 13, 2025
20 of 22 checks passed
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants