Skip to content

Conversation

@dataroaring
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34585 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 290303927cd4b00cde0871fec5eec29f777d8329, data reload: false

------ Round 1 ----------------------------------
q1	17633	5167	5042	5042
q2	1991	375	215	215
q3	10214	1281	702	702
q4	10235	1016	533	533
q5	7530	2352	2386	2352
q6	183	173	135	135
q7	909	772	636	636
q8	9329	1308	1114	1114
q9	6928	5136	5150	5136
q10	6968	2400	1949	1949
q11	488	306	281	281
q12	355	353	230	230
q13	17782	3719	3064	3064
q14	253	243	221	221
q15	567	497	493	493
q16	1001	997	944	944
q17	592	863	360	360
q18	7766	7266	7040	7040
q19	1232	939	569	569
q20	335	336	233	233
q21	3648	2546	2319	2319
q22	1078	1046	1017	1017
Total cold run time: 107017 ms
Total hot run time: 34585 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5167	5080	5075	5075
q2	247	326	231	231
q3	2199	2671	2343	2343
q4	1373	1771	1345	1345
q5	4219	4543	4454	4454
q6	227	172	137	137
q7	2034	1992	1896	1896
q8	2708	2528	2602	2528
q9	7408	7394	7346	7346
q10	3191	3312	2826	2826
q11	587	532	529	529
q12	711	778	627	627
q13	3504	3956	3399	3399
q14	285	307	289	289
q15	527	498	489	489
q16	1069	1160	1055	1055
q17	1144	1561	1463	1463
q18	8154	7670	7381	7381
q19	748	755	778	755
q20	1948	1947	1825	1825
q21	4720	4305	4293	4293
q22	1076	1042	988	988
Total cold run time: 53246 ms
Total hot run time: 51274 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 188617 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 290303927cd4b00cde0871fec5eec29f777d8329, data reload: false

query1	1057	449	415	415
query2	6557	1723	1716	1716
query3	6740	222	218	218
query4	26208	23169	23171	23169
query5	4401	623	471	471
query6	381	242	227	227
query7	4656	501	299	299
query8	306	262	248	248
query9	8680	2606	2607	2606
query10	496	361	311	311
query11	15752	15212	14793	14793
query12	180	116	116	116
query13	1677	566	472	472
query14	10920	9143	9154	9143
query15	209	190	171	171
query16	7455	672	540	540
query17	1225	727	606	606
query18	2017	419	358	358
query19	201	205	176	176
query20	131	125	127	125
query21	213	138	116	116
query22	4098	4148	4047	4047
query23	33851	33184	33162	33162
query24	8496	2386	2391	2386
query25	576	520	459	459
query26	1234	274	164	164
query27	2749	505	374	374
query28	4376	2218	2186	2186
query29	809	600	477	477
query30	293	228	201	201
query31	905	811	765	765
query32	77	76	78	76
query33	579	393	324	324
query34	789	867	513	513
query35	818	823	743	743
query36	986	1008	930	930
query37	116	110	87	87
query38	3592	3599	3452	3452
query39	1469	1420	1413	1413
query40	218	129	123	123
query41	68	62	61	61
query42	125	115	119	115
query43	523	482	480	480
query44	1318	827	842	827
query45	188	185	175	175
query46	853	1012	646	646
query47	1780	1834	1754	1754
query48	384	425	313	313
query49	794	508	414	414
query50	659	690	403	403
query51	3889	3964	3897	3897
query52	113	111	99	99
query53	232	290	184	184
query54	588	580	525	525
query55	89	80	82	80
query56	307	322	301	301
query57	1194	1218	1124	1124
query58	276	268	266	266
query59	2567	2680	2518	2518
query60	368	329	330	329
query61	177	166	161	161
query62	814	721	661	661
query63	228	189	191	189
query64	4495	1171	981	981
query65	4043	3981	3998	3981
query66	1130	435	327	327
query67	15537	15227	15055	15055
query68	7943	922	578	578
query69	488	312	277	277
query70	1333	1236	1277	1236
query71	575	346	305	305
query72	5872	5158	5139	5139
query73	671	654	352	352
query74	8890	9103	8863	8863
query75	3324	3290	2780	2780
query76	3281	1175	745	745
query77	552	393	321	321
query78	9546	9677	8914	8914
query79	1946	796	592	592
query80	673	651	524	524
query81	514	267	227	227
query82	219	171	138	138
query83	263	266	251	251
query84	263	114	97	97
query85	852	463	421	421
query86	376	300	297	297
query87	3746	3782	3661	3661
query88	2806	2186	2210	2186
query89	394	341	296	296
query90	1931	209	207	207
query91	156	166	136	136
query92	83	72	61	61
query93	2071	1018	643	643
query94	696	471	329	329
query95	390	315	307	307
query96	482	572	279	279
query97	2891	2999	2893	2893
query98	232	210	207	207
query99	1343	1412	1311	1311
Total cold run time: 273034 ms
Total hot run time: 188617 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.76 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 290303927cd4b00cde0871fec5eec29f777d8329, data reload: false

query1	0.06	0.05	0.06
query2	0.10	0.07	0.06
query3	0.26	0.09	0.09
query4	1.60	0.12	0.12
query5	0.29	0.26	0.26
query6	1.20	0.65	0.66
query7	0.04	0.04	0.03
query8	0.06	0.05	0.04
query9	0.61	0.53	0.52
query10	0.59	0.60	0.58
query11	0.17	0.13	0.11
query12	0.16	0.13	0.13
query13	0.63	0.63	0.64
query14	1.04	1.05	1.04
query15	0.90	0.84	0.86
query16	0.44	0.41	0.42
query17	1.04	1.10	1.04
query18	0.23	0.20	0.20
query19	1.92	1.82	1.77
query20	0.02	0.02	0.01
query21	15.40	0.93	0.60
query22	0.76	1.20	0.65
query23	14.92	1.39	0.62
query24	7.66	0.98	0.45
query25	0.44	0.17	0.14
query26	0.65	0.16	0.13
query27	0.07	0.06	0.06
query28	9.54	0.86	0.42
query29	12.62	3.99	3.24
query30	0.33	0.17	0.14
query31	2.84	0.61	0.41
query32	3.23	0.56	0.48
query33	3.13	3.14	3.10
query34	16.04	5.46	4.91
query35	4.92	4.91	4.94
query36	0.70	0.52	0.51
query37	0.11	0.08	0.09
query38	0.07	0.05	0.05
query39	0.04	0.03	0.03
query40	0.18	0.16	0.15
query41	0.09	0.04	0.03
query42	0.05	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 105.2 s
Total hot run time: 29.76 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.21% (17431/33388)
Line Coverage 37.43% (158410/423170)
Region Coverage 31.99% (120762/377473)
Branch Coverage 33.37% (53002/158824)

@shuke987
Copy link
Collaborator

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34873 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 290303927cd4b00cde0871fec5eec29f777d8329, data reload: false

------ Round 1 ----------------------------------
q1	17628	5244	5087	5087
q2	2003	314	211	211
q3	10274	1266	716	716
q4	10232	1022	547	547
q5	7572	2436	2341	2341
q6	190	170	140	140
q7	935	786	651	651
q8	9357	1344	1048	1048
q9	6866	5158	5112	5112
q10	6971	2406	1996	1996
q11	483	307	286	286
q12	357	370	236	236
q13	17803	3643	3216	3216
q14	247	238	218	218
q15	576	484	498	484
q16	1022	996	931	931
q17	609	867	382	382
q18	7359	7057	7167	7057
q19	1517	965	597	597
q20	344	342	231	231
q21	3798	2596	2400	2400
q22	1050	1030	986	986
Total cold run time: 107193 ms
Total hot run time: 34873 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5228	5134	5169	5134
q2	260	332	231	231
q3	2149	2673	2264	2264
q4	1379	1787	1340	1340
q5	4268	4547	4432	4432
q6	242	176	136	136
q7	2047	2095	1830	1830
q8	2656	2532	2544	2532
q9	7381	7417	7303	7303
q10	3100	3316	2868	2868
q11	567	509	524	509
q12	741	855	598	598
q13	3882	3883	3311	3311
q14	290	374	272	272
q15	516	501	490	490
q16	1105	1277	1052	1052
q17	1176	1548	1409	1409
q18	7993	7774	7789	7774
q19	828	855	939	855
q20	2032	2010	1943	1943
q21	4914	4343	4307	4307
q22	1089	1065	981	981
Total cold run time: 53843 ms
Total hot run time: 51571 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 188421 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 290303927cd4b00cde0871fec5eec29f777d8329, data reload: false

query1	1078	449	432	432
query2	6600	1715	1733	1715
query3	6760	225	217	217
query4	26037	23528	23035	23035
query5	4424	615	481	481
query6	345	244	227	227
query7	4663	520	293	293
query8	324	268	250	250
query9	8698	2611	2612	2611
query10	490	343	282	282
query11	15742	15286	15040	15040
query12	167	117	121	117
query13	1688	584	451	451
query14	10745	9418	9417	9417
query15	214	194	181	181
query16	7772	664	489	489
query17	1372	764	641	641
query18	2048	428	352	352
query19	257	196	184	184
query20	133	123	120	120
query21	217	129	113	113
query22	4144	4145	4041	4041
query23	33822	32858	33007	32858
query24	8454	2420	2381	2381
query25	556	498	430	430
query26	1238	277	156	156
query27	2683	506	358	358
query28	4342	2226	2186	2186
query29	780	605	484	484
query30	287	225	229	225
query31	887	818	733	733
query32	85	73	74	73
query33	575	380	339	339
query34	802	858	523	523
query35	817	836	741	741
query36	988	1028	921	921
query37	122	133	84	84
query38	3451	3634	3501	3501
query39	1470	1451	1425	1425
query40	224	139	117	117
query41	65	61	62	61
query42	125	116	118	116
query43	532	518	454	454
query44	1369	852	847	847
query45	188	173	167	167
query46	858	1013	648	648
query47	1763	1813	1737	1737
query48	393	438	321	321
query49	745	519	419	419
query50	659	685	405	405
query51	3954	3931	3994	3931
query52	112	114	109	109
query53	241	271	191	191
query54	596	594	529	529
query55	90	81	82	81
query56	314	321	304	304
query57	1187	1185	1108	1108
query58	273	268	262	262
query59	2599	2687	2539	2539
query60	354	333	321	321
query61	191	160	160	160
query62	852	747	680	680
query63	219	189	195	189
query64	4444	1113	859	859
query65	4080	3961	3981	3961
query66	1108	461	356	356
query67	15376	15520	15087	15087
query68	9510	917	575	575
query69	490	321	290	290
query70	1402	1346	1232	1232
query71	569	345	310	310
query72	6083	4995	5046	4995
query73	711	614	361	361
query74	8895	9272	8741	8741
query75	4362	3281	2944	2944
query76	3684	1172	731	731
query77	1005	414	324	324
query78	9596	9789	8847	8847
query79	2661	859	590	590
query80	693	564	491	491
query81	475	266	237	237
query82	455	159	136	136
query83	300	267	244	244
query84	301	108	98	98
query85	897	453	422	422
query86	340	311	309	309
query87	3798	3765	3609	3609
query88	2946	2241	2250	2241
query89	406	328	294	294
query90	1919	210	208	208
query91	161	159	131	131
query92	81	69	63	63
query93	1292	994	637	637
query94	684	424	337	337
query95	388	312	302	302
query96	491	563	281	281
query97	2947	2977	2880	2880
query98	235	225	209	209
query99	1437	1423	1286	1286
Total cold run time: 277402 ms
Total hot run time: 188421 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.13 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 290303927cd4b00cde0871fec5eec29f777d8329, data reload: false

query1	0.06	0.04	0.05
query2	0.09	0.05	0.05
query3	0.26	0.09	0.08
query4	1.61	0.12	0.12
query5	0.27	0.28	0.25
query6	1.18	0.66	0.64
query7	0.04	0.03	0.03
query8	0.06	0.04	0.04
query9	0.60	0.53	0.52
query10	0.59	0.59	0.58
query11	0.17	0.12	0.12
query12	0.16	0.13	0.12
query13	0.63	0.63	0.63
query14	1.02	1.05	1.04
query15	0.86	0.85	0.86
query16	0.40	0.42	0.40
query17	1.06	1.04	1.05
query18	0.21	0.20	0.20
query19	1.93	1.78	1.83
query20	0.01	0.01	0.02
query21	15.40	0.92	0.60
query22	0.77	1.26	0.63
query23	14.94	1.29	0.66
query24	6.98	1.57	1.05
query25	0.47	0.23	0.14
query26	0.67	0.15	0.14
query27	0.06	0.05	0.05
query28	9.27	0.88	0.43
query29	12.63	3.90	3.25
query30	0.28	0.13	0.11
query31	2.84	0.61	0.39
query32	3.24	0.57	0.48
query33	3.10	3.03	3.11
query34	16.20	5.49	4.82
query35	4.92	4.94	4.92
query36	0.70	0.52	0.49
query37	0.11	0.08	0.08
query38	0.06	0.05	0.04
query39	0.04	0.03	0.03
query40	0.17	0.15	0.16
query41	0.08	0.03	0.03
query42	0.03	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 104.21 s
Total hot run time: 30.13 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.20% (17430/33388)
Line Coverage 37.43% (158393/423184)
Region Coverage 32.00% (120776/377482)
Branch Coverage 33.37% (53004/158830)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 70.88% (23142/32649)
Line Coverage 57.30% (241899/422177)
Region Coverage 52.76% (201782/382479)
Branch Coverage 54.41% (86800/159535)

Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 14, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit 7f5a600 into apache:master Sep 14, 2025
30 of 33 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 14, 2025
github-actions bot pushed a commit that referenced this pull request Sep 14, 2025
dataroaring added a commit that referenced this pull request Sep 14, 2025
Cherry-picked from #56019

Co-authored-by: Yongqiang YANG <yangyongqiang@selectdb.com>
morrySnow pushed a commit that referenced this pull request Sep 17, 2025
Cherry-picked from #56019

Co-authored-by: Yongqiang YANG <yangyongqiang@selectdb.com>
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.9-merged dev/3.1.1-merged p0_test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants