Skip to content

Conversation

@Hastyshell
Copy link
Collaborator

@Hastyshell Hastyshell commented Sep 15, 2025

picked from #56092

@Thearas
Copy link
Contributor

Thearas commented Sep 15, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Hastyshell
Copy link
Collaborator Author

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot
Copy link

TPC-H: Total hot run time: 32770 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 87cfb228641d6aaff68d35893810f176b2cbc9c6, data reload: false

------ Round 1 ----------------------------------
q1	17581	5486	5459	5459
q2	2014	393	278	278
q3	12196	1236	739	739
q4	10222	872	457	457
q5	7841	2383	2137	2137
q6	187	163	132	132
q7	910	761	603	603
q8	9350	1453	1178	1178
q9	5255	4938	4917	4917
q10	6766	2326	1817	1817
q11	467	281	269	269
q12	344	358	217	217
q13	17824	3644	3048	3048
q14	227	242	214	214
q15	535	469	472	469
q16	425	426	374	374
q17	604	859	355	355
q18	6781	6355	6434	6355
q19	1219	953	563	563
q20	318	331	206	206
q21	2823	2176	2008	2008
q22	1063	1014	975	975
Total cold run time: 104952 ms
Total hot run time: 32770 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5593	5498	5602	5498
q2	237	319	228	228
q3	2295	2659	2312	2312
q4	1348	1800	1378	1378
q5	4403	4892	4963	4892
q6	168	165	129	129
q7	2055	1997	1860	1860
q8	2640	2835	2716	2716
q9	7203	7139	7237	7139
q10	3039	3299	2758	2758
q11	561	509	495	495
q12	661	754	620	620
q13	3443	3786	3173	3173
q14	275	288	270	270
q15	514	473	480	473
q16	465	504	434	434
q17	1243	1765	1250	1250
q18	7465	7353	7413	7353
q19	802	1203	1074	1074
q20	2030	2070	1901	1901
q21	5444	4907	4654	4654
q22	1101	1084	996	996
Total cold run time: 52985 ms
Total hot run time: 51603 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192304 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 87cfb228641d6aaff68d35893810f176b2cbc9c6, data reload: false

query1	958	398	403	398
query2	6253	1928	1846	1846
query3	8678	205	189	189
query4	33615	23880	23259	23259
query5	3733	599	430	430
query6	287	198	170	170
query7	4206	487	312	312
query8	318	256	242	242
query9	9390	2627	2591	2591
query10	454	328	255	255
query11	18014	15434	15208	15208
query12	166	110	105	105
query13	1555	537	411	411
query14	9533	7161	6925	6925
query15	230	193	183	183
query16	8086	670	524	524
query17	1575	788	595	595
query18	2192	438	324	324
query19	241	192	179	179
query20	132	119	117	117
query21	205	131	113	113
query22	4578	4761	4561	4561
query23	34720	34257	34102	34102
query24	7419	2737	2665	2665
query25	500	483	412	412
query26	799	285	172	172
query27	2245	481	371	371
query28	5054	2233	2202	2202
query29	729	599	429	429
query30	243	196	166	166
query31	966	952	830	830
query32	102	56	55	55
query33	497	365	320	320
query34	753	875	526	526
query35	769	828	727	727
query36	1030	1069	965	965
query37	109	90	70	70
query38	4045	3988	3909	3909
query39	1548	1553	1515	1515
query40	205	119	106	106
query41	51	50	46	46
query42	118	107	100	100
query43	529	500	484	484
query44	1354	791	812	791
query45	184	174	173	173
query46	885	1052	677	677
query47	2017	2045	1954	1954
query48	436	442	349	349
query49	741	496	398	398
query50	670	689	444	444
query51	7335	7449	7227	7227
query52	105	104	92	92
query53	232	259	193	193
query54	553	544	485	485
query55	79	78	78	78
query56	271	293	257	257
query57	1304	1262	1239	1239
query58	242	221	222	221
query59	3089	3120	3029	3029
query60	282	272	290	272
query61	117	113	118	113
query62	803	748	691	691
query63	232	190	196	190
query64	3816	1007	663	663
query65	3421	3261	3316	3261
query66	811	406	304	304
query67	16504	15781	15886	15781
query68	7699	836	539	539
query69	500	308	269	269
query70	1161	1136	1118	1118
query71	364	294	268	268
query72	5184	3729	3951	3729
query73	650	760	355	355
query74	10050	9417	9297	9297
query75	3208	3176	2683	2683
query76	2958	1174	781	781
query77	482	403	271	271
query78	10270	10497	9575	9575
query79	2856	918	601	601
query80	722	515	426	426
query81	486	253	222	222
query82	553	124	90	90
query83	185	163	146	146
query84	285	104	83	83
query85	773	349	292	292
query86	351	302	271	271
query87	4310	4283	4225	4225
query88	4122	2389	2479	2389
query89	396	325	298	298
query90	1781	191	190	190
query91	149	139	109	109
query92	64	55	52	52
query93	1106	895	535	535
query94	693	422	303	303
query95	335	278	269	269
query96	498	600	277	277
query97	3192	3316	3118	3118
query98	218	218	200	200
query99	1548	1415	1332	1332
Total cold run time: 289462 ms
Total hot run time: 192304 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.71 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 87cfb228641d6aaff68d35893810f176b2cbc9c6, data reload: false

query1	0.04	0.03	0.02
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.64	0.11	0.10
query5	0.50	0.52	0.50
query6	1.13	0.75	0.72
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.58	0.51	0.48
query10	0.56	0.54	0.56
query11	0.15	0.10	0.11
query12	0.13	0.12	0.11
query13	0.62	0.61	0.60
query14	0.78	0.79	0.80
query15	0.86	0.83	0.82
query16	0.38	0.40	0.38
query17	0.99	1.05	1.06
query18	0.24	0.24	0.23
query19	1.92	1.85	1.89
query20	0.02	0.01	0.01
query21	15.40	1.02	0.61
query22	0.73	0.94	0.53
query23	15.08	1.48	0.58
query24	3.02	1.78	0.80
query25	0.12	0.07	0.14
query26	0.33	0.14	0.14
query27	0.05	0.04	0.05
query28	13.88	1.02	0.45
query29	12.60	3.96	3.26
query30	0.24	0.09	0.07
query31	2.82	0.62	0.37
query32	3.22	0.54	0.47
query33	3.01	3.00	3.03
query34	16.74	5.20	4.54
query35	4.61	4.55	4.58
query36	0.65	0.50	0.48
query37	0.08	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.02	0.02
query40	0.17	0.13	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 103.88 s
Total hot run time: 28.71 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.56% (12778/28048)
Line Coverage 36.38% (113936/313152)
Region Coverage 34.01% (65150/191574)
Branch Coverage 31.03% (34184/110160)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.50% (21102/27585)
Line Coverage 69.80% (217902/312186)
Region Coverage 67.69% (130195/192351)
Branch Coverage 61.26% (67795/110674)

@morrySnow morrySnow changed the title [fix](tde) Correct encryption key version display branch-3.1: [fix](tde) Correct encryption key version display #56092 Sep 16, 2025
@morrySnow morrySnow merged commit 1c5b656 into apache:branch-3.1 Sep 16, 2025
25 of 26 checks passed
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants