Skip to content

Conversation

@liaoxin01
Copy link
Contributor

@liaoxin01 liaoxin01 commented Sep 16, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

PR #51219 fixed the issue of S3 load HTTPS access failure, but the changes were accidentally dropped during the cherry-pick in PR #52479. Now we need to add those changes back.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Sep 16, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@liaoxin01
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32549 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7d6c378c75dfa83c611b2873a47e528e742348cd, data reload: false

------ Round 1 ----------------------------------
q1	17583	5449	5446	5446
q2	2022	402	283	283
q3	12206	1247	762	762
q4	10546	872	441	441
q5	9629	2378	2106	2106
q6	190	165	130	130
q7	930	755	617	617
q8	9332	1437	1167	1167
q9	5193	4965	4870	4870
q10	6783	2256	1797	1797
q11	466	281	265	265
q12	344	364	208	208
q13	17792	3638	2996	2996
q14	223	226	216	216
q15	514	460	459	459
q16	423	438	373	373
q17	611	857	352	352
q18	6747	6334	6364	6334
q19	1281	951	573	573
q20	328	348	206	206
q21	2765	2198	1991	1991
q22	1046	1009	957	957
Total cold run time: 106954 ms
Total hot run time: 32549 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5489	5509	5526	5509
q2	246	334	252	252
q3	2349	2696	2434	2434
q4	1426	1889	1477	1477
q5	4516	5074	5022	5022
q6	167	163	129	129
q7	2083	1939	1821	1821
q8	2640	2864	2726	2726
q9	7296	7318	7224	7224
q10	3021	3181	2764	2764
q11	571	519	514	514
q12	661	733	644	644
q13	3489	3808	3158	3158
q14	282	311	274	274
q15	519	467	455	455
q16	444	483	435	435
q17	1233	1730	1287	1287
q18	7683	7396	7428	7396
q19	865	1101	1097	1097
q20	1997	2033	1908	1908
q21	5207	4810	4452	4452
q22	1147	1132	1013	1013
Total cold run time: 53331 ms
Total hot run time: 51991 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192238 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7d6c378c75dfa83c611b2873a47e528e742348cd, data reload: false

query1	948	402	396	396
query2	6087	1954	1912	1912
query3	8690	199	193	193
query4	33633	23844	23374	23374
query5	3617	610	439	439
query6	273	194	181	181
query7	4204	492	327	327
query8	305	232	263	232
query9	9279	2605	2560	2560
query10	478	325	264	264
query11	18099	15727	15038	15038
query12	157	111	105	105
query13	1560	561	409	409
query14	10031	7550	7053	7053
query15	237	186	186	186
query16	8025	640	476	476
query17	1556	778	574	574
query18	2131	402	302	302
query19	242	180	159	159
query20	125	120	124	120
query21	211	128	109	109
query22	4511	4644	4498	4498
query23	34763	34059	34264	34059
query24	7613	2731	2680	2680
query25	558	502	444	444
query26	777	295	183	183
query27	2124	483	370	370
query28	5157	2206	2158	2158
query29	743	595	456	456
query30	245	197	167	167
query31	970	937	835	835
query32	94	60	63	60
query33	526	374	328	328
query34	739	861	505	505
query35	810	825	765	765
query36	996	1053	974	974
query37	111	96	68	68
query38	4016	4052	3975	3975
query39	1549	1476	1515	1476
query40	210	122	114	114
query41	55	51	49	49
query42	116	102	103	102
query43	500	516	464	464
query44	1385	811	830	811
query45	188	189	176	176
query46	907	1046	673	673
query47	2013	2044	1937	1937
query48	406	416	342	342
query49	731	527	410	410
query50	676	695	425	425
query51	7297	7201	7185	7185
query52	108	104	95	95
query53	230	261	201	201
query54	538	544	463	463
query55	77	75	82	75
query56	278	262	252	252
query57	1274	1307	1222	1222
query58	242	216	222	216
query59	3043	3174	3046	3046
query60	293	288	276	276
query61	115	123	117	117
query62	805	747	698	698
query63	248	200	201	200
query64	3728	998	660	660
query65	3355	3332	3334	3332
query66	887	420	312	312
query67	16778	15915	15792	15792
query68	7901	809	530	530
query69	490	308	268	268
query70	1203	1156	1113	1113
query71	393	291	272	272
query72	5720	3741	3884	3741
query73	625	740	349	349
query74	10382	9390	9091	9091
query75	3516	3154	2706	2706
query76	3250	1188	756	756
query77	762	363	279	279
query78	10324	10351	9617	9617
query79	3918	838	581	581
query80	697	515	441	441
query81	508	265	227	227
query82	554	116	89	89
query83	174	165	148	148
query84	286	106	79	79
query85	787	353	306	306
query86	398	326	300	300
query87	4374	4267	4224	4224
query88	5074	2526	2395	2395
query89	408	333	294	294
query90	1786	188	190	188
query91	138	146	109	109
query92	64	57	51	51
query93	2317	900	539	539
query94	646	412	293	293
query95	336	276	258	258
query96	485	603	281	281
query97	3222	3275	3143	3143
query98	222	212	201	201
query99	1577	1401	1314	1314
Total cold run time: 295210 ms
Total hot run time: 192238 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.54 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7d6c378c75dfa83c611b2873a47e528e742348cd, data reload: false

query1	0.04	0.03	0.03
query2	0.06	0.04	0.03
query3	0.24	0.07	0.07
query4	1.62	0.12	0.11
query5	0.53	0.54	0.59
query6	1.14	0.74	0.74
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.56	0.51	0.49
query10	0.56	0.55	0.57
query11	0.15	0.10	0.10
query12	0.14	0.10	0.11
query13	0.62	0.60	0.60
query14	0.78	0.83	0.81
query15	0.85	0.84	0.83
query16	0.37	0.39	0.40
query17	1.01	1.02	1.00
query18	0.23	0.22	0.22
query19	1.86	1.89	1.84
query20	0.02	0.02	0.01
query21	15.37	0.88	0.58
query22	0.72	0.75	0.74
query23	15.09	1.38	0.52
query24	3.13	1.40	2.02
query25	0.17	0.19	0.08
query26	0.22	0.14	0.14
query27	0.05	0.04	0.05
query28	14.67	0.97	0.44
query29	12.54	3.94	3.28
query30	0.26	0.10	0.07
query31	2.80	0.60	0.38
query32	3.22	0.55	0.47
query33	3.00	2.98	3.07
query34	16.51	5.26	4.62
query35	4.61	4.66	4.50
query36	0.64	0.49	0.50
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.03	0.02
query40	0.16	0.13	0.12
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.04
Total cold run time: 104.33 s
Total hot run time: 29.54 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/11) 🎉
Increment coverage report
Complete coverage report

@liaoxin01
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32716 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d03068fb1488325bf14876c9c78d0a2b25d4cbe3, data reload: false

------ Round 1 ----------------------------------
q1	17594	5460	5409	5409
q2	2036	388	285	285
q3	12096	1241	746	746
q4	10446	863	445	445
q5	9692	2394	2132	2132
q6	188	164	136	136
q7	901	728	630	630
q8	9353	1433	1115	1115
q9	5222	5046	4938	4938
q10	6754	2271	1808	1808
q11	480	282	263	263
q12	339	369	221	221
q13	17792	3645	3017	3017
q14	229	227	231	227
q15	515	464	468	464
q16	419	432	382	382
q17	600	858	345	345
q18	6816	6506	6393	6393
q19	1218	945	577	577
q20	334	336	205	205
q21	3004	2154	1958	1958
q22	1053	1049	1020	1020
Total cold run time: 107081 ms
Total hot run time: 32716 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5511	5534	5470	5470
q2	239	330	233	233
q3	2244	2615	2333	2333
q4	1336	1763	1343	1343
q5	4437	5037	5044	5037
q6	166	165	128	128
q7	2121	1977	1821	1821
q8	2601	2767	2705	2705
q9	7310	7281	7437	7281
q10	3076	3268	2812	2812
q11	595	526	510	510
q12	685	807	628	628
q13	3436	3831	3211	3211
q14	292	301	274	274
q15	521	467	467	467
q16	452	476	445	445
q17	1235	1753	1266	1266
q18	7631	7385	7316	7316
q19	794	1051	1150	1051
q20	2036	2069	1870	1870
q21	5260	4893	4576	4576
q22	1078	1072	1002	1002
Total cold run time: 53056 ms
Total hot run time: 51779 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193566 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d03068fb1488325bf14876c9c78d0a2b25d4cbe3, data reload: false

query1	943	405	394	394
query2	6248	1977	1911	1911
query3	8690	199	193	193
query4	33382	24052	23718	23718
query5	3677	580	447	447
query6	294	212	167	167
query7	4193	493	323	323
query8	297	245	231	231
query9	9393	2628	2597	2597
query10	484	319	271	271
query11	18225	15631	15286	15286
query12	155	113	106	106
query13	1561	540	423	423
query14	9899	6710	7168	6710
query15	245	202	182	182
query16	8136	607	567	567
query17	1557	772	596	596
query18	2153	422	333	333
query19	240	204	173	173
query20	123	119	118	118
query21	210	131	109	109
query22	4517	4637	4577	4577
query23	34680	34524	34534	34524
query24	8042	2695	2721	2695
query25	554	545	454	454
query26	1021	295	177	177
query27	2160	499	358	358
query28	5417	2200	2188	2188
query29	766	631	466	466
query30	238	195	167	167
query31	1007	900	855	855
query32	91	82	55	55
query33	487	375	311	311
query34	748	851	523	523
query35	783	820	757	757
query36	1004	1072	980	980
query37	105	92	65	65
query38	4037	3963	4021	3963
query39	1524	1486	1463	1463
query40	208	114	108	108
query41	49	54	53	53
query42	127	113	109	109
query43	509	521	506	506
query44	1361	833	821	821
query45	189	180	174	174
query46	928	1066	678	678
query47	1980	2039	1937	1937
query48	416	448	365	365
query49	751	485	437	437
query50	699	698	435	435
query51	7463	7412	7129	7129
query52	108	101	92	92
query53	231	263	195	195
query54	544	556	470	470
query55	79	81	78	78
query56	265	268	259	259
query57	1264	1276	1210	1210
query58	248	223	225	223
query59	3160	3216	3048	3048
query60	291	286	275	275
query61	116	121	112	112
query62	788	762	695	695
query63	248	202	195	195
query64	4589	1015	670	670
query65	3372	3329	3360	3329
query66	1016	408	309	309
query67	16596	15736	15632	15632
query68	7665	839	554	554
query69	493	317	264	264
query70	1188	1115	1093	1093
query71	386	291	272	272
query72	5743	3731	3833	3731
query73	645	758	365	365
query74	10586	9546	9311	9311
query75	3221	3150	2698	2698
query76	3396	1177	774	774
query77	675	373	275	275
query78	10422	10350	9681	9681
query79	3083	911	606	606
query80	704	527	443	443
query81	512	263	225	225
query82	590	127	90	90
query83	177	164	155	155
query84	280	109	81	81
query85	798	351	308	308
query86	388	315	286	286
query87	4345	4304	4207	4207
query88	5078	2393	2402	2393
query89	410	356	308	308
query90	1764	195	197	195
query91	143	144	112	112
query92	61	57	54	54
query93	1971	943	547	547
query94	661	421	289	289
query95	349	292	277	277
query96	500	593	280	280
query97	3236	3307	3197	3197
query98	229	216	202	202
query99	1530	1396	1316	1316
Total cold run time: 296110 ms
Total hot run time: 193566 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.61 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d03068fb1488325bf14876c9c78d0a2b25d4cbe3, data reload: false

query1	0.04	0.03	0.02
query2	0.06	0.04	0.03
query3	0.23	0.07	0.07
query4	1.63	0.11	0.11
query5	0.50	0.53	0.54
query6	1.13	0.74	0.73
query7	0.02	0.01	0.01
query8	0.04	0.04	0.04
query9	0.57	0.49	0.49
query10	0.55	0.54	0.55
query11	0.14	0.11	0.11
query12	0.14	0.10	0.11
query13	0.62	0.60	0.59
query14	0.79	0.81	0.79
query15	0.85	0.84	0.81
query16	0.38	0.40	0.38
query17	1.05	1.01	1.02
query18	0.24	0.23	0.23
query19	1.89	1.88	1.85
query20	0.01	0.01	0.01
query21	15.42	0.88	0.59
query22	0.74	0.79	0.73
query23	15.03	1.47	0.54
query24	4.10	0.48	1.11
query25	0.13	0.06	0.11
query26	0.46	0.15	0.14
query27	0.05	0.05	0.07
query28	13.07	1.01	0.43
query29	12.58	3.95	3.27
query30	0.25	0.10	0.07
query31	2.82	0.62	0.39
query32	3.23	0.53	0.47
query33	3.01	3.07	3.04
query34	16.69	5.20	4.57
query35	4.53	4.54	4.61
query36	0.65	0.50	0.48
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.02	0.02
query40	0.17	0.13	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.13 s
Total hot run time: 28.61 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/11) 🎉
Increment coverage report
Complete coverage report

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morrySnow morrySnow merged commit d349c76 into apache:branch-3.1 Sep 19, 2025
22 checks passed
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants