Skip to content

[fix](fold constant) abs's return type should be argument type #56190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Sep 19, 2025
Merged

[fix](fold constant) abs's return type should be argument type #56190

morrySnow merged 1 commit into from
Sep 19, 2025

Conversation

@morrySnow
Copy link
Contributor

@morrySnow morrySnow commented Sep 18, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Sep 18, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow
Copy link
Contributor Author

morrySnow commented Sep 18, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 18, 2025

TPC-H: Total hot run time: 1494 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ac70c6997e804270f5a5cea9f7c9158e28512b74, data reload: false

------ Round 1 ----------------------------------
q1	17601	30	19	19
q2	2656	27	26	26
q3	10720	16	15	15
q4	11164	16	16	16
q5	8100	15	15	15
q6	236	14	13	13
q7	956	30	22	22
q8	9450	15	13	13
q9	9980	14	12	12
q10	7014	13	12	12
q11	717	23	20	20
q12	670	13	11	11
q13	18668	13	11	11
q14	261	12	10	10
q15	606	13	11	11
q16	1078	979	949	949
q17	569	13	12	12
q18	8008	13	12	12
q19	1152	13	11	11
q20	1991	368	252	252
q21	9127	21	21	21
q22	1085	12	11	11
Total cold run time: 121809 ms
Total hot run time: 1494 ms

----- Round 2, with runtime_filter_mode=off -----
q1	12	10	11	10
q2	21	19	20	19
q3	12	11	12	11
q4	14	12	11	11
q5	11	10	12	10
q6	10	10	10	10
q7	19	19	19	19
q8	11	11	10	10
q9	10	10	11	10
q10	11	11	11	11
q11	20	20	19	19
q12	10	10	11	10
q13	10	10	10	10
q14	10	11	12	11
q15	11	11	10	10
q16	1032	1117	1022	1022
q17	12	11	10	10
q18	10	11	10	10
q19	11	11	10	10
q20	1902	1949	1861	1861
q21	21	19	18	18
q22	9	10	9	9
Total cold run time: 3189 ms
Total hot run time: 3121 ms

@doris-robot
Copy link

doris-robot commented Sep 18, 2025

TPC-DS: Total hot run time: 2819 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ac70c6997e804270f5a5cea9f7c9158e28512b74, data reload: false

query1	1089	20	13	13
query2	7133	17	16	16
query3	7634	12	11	11
query4	26502	12	12	12
query5	4448	12	12	12
query6	367	11	10	10
query7	5448	12	11	11
query8	363	19	18	18
query9	9224	11	10	10
query10	730	12	11	11
query11	16031	10	9	9
query12	178	11	10	10
query13	1708	11	10	10
query14	10889	15	14	14
query15	229	11	10	10
query16	7167	10	10	10
query17	1533	12	10	10
query18	2806	11	11	11
query19	212	10	9	9
query20	143	11	9	9
query21	227	10	9	9
query22	4127	9	8	8
query23	33579	17	14	14
query24	9268	13	12	12
query25	718	10	10	10
query26	1071	11	10	10
query27	3391	11	10	10
query28	6277	10	10	10
query29	1208	11	10	10
query30	656	12	10	10
query31	1737	12	11	11
query32	118	11	11	11
query33	1049	11	10	10
query34	1620	822	527	527
query35	923	10	10	10
query36	1013	10	9	9
query37	119	10	9	9
query38	3558	9	8	8
query39	1506	745	750	745
query40	241	10	12	10
query41	82	11	12	11
query42	158	10	10	10
query43	518	10	10	10
query44	1366	10	9	9
query45	206	12	10	10
query46	931	11	9	9
query47	1806	10	9	9
query48	411	11	10	10
query49	1139	10	10	10
query50	768	10	10	10
query51	3920	10	8	8
query52	118	9	11	9
query53	250	10	11	10
query54	743	10	9	9
query55	99	11	9	9
query56	351	11	9	9
query57	1191	10	9	9
query58	315	11	11	11
query59	2631	9	10	9
query60	370	10	10	10
query61	179	10	10	10
query62	849	11	10	10
query63	279	10	12	10
query64	3949	10	9	9
query65	4042	10	8	8
query66	1091	11	9	9
query67	16509	15	12	12
query68	3472	9	10	9
query69	571	10	10	10
query70	1402	9	8	8
query71	430	360	360	360
query72	6723	9	11	9
query73	804	12	11	11
query74	9532	10	10	10
query75	3423	10	10	10
query76	2704	11	11	11
query77	981	13	11	11
query78	9988	11	9	9
query79	1090	9	9	9
query80	658	10	12	10
query81	506	9	9	9
query82	206	9	9	9
query83	302	11	11	11
query84	316	11	9	9
query85	968	11	10	10
query86	364	10	9	9
query87	3877	8	10	8
query88	2925	15	10	10
query89	404	9	9	9
query90	2041	10	7	7
query91	167	10	10	10
query92	87	12	9	9
query93	1077	9	10	9
query94	785	13	10	10
query95	525	10	10	10
query96	453	11	12	11
query97	3115	10	9	9
query98	231	270	235	235
query99	1469	13	10	10
Total cold run time: 282107 ms
Total hot run time: 2819 ms

@doris-robot
Copy link

doris-robot commented Sep 18, 2025

ClickBench: Total hot run time: 0.08 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ac70c6997e804270f5a5cea9f7c9158e28512b74, data reload: false

query1	0.07	0.02	0.01
query2	0.09	0.01	0.00
query3	0.27	0.01	0.01
query4	1.74	0.01	0.01
query5	0.28	0.00	0.01
query6	1.68	0.01	0.01
query7	0.06	0.00	0.01
query8	0.07	0.00	0.01
query9	0.61	0.01	0.00
query10	0.60	0.00	0.00
query11	0.17	0.01	0.00
query12	0.16	0.00	0.01
query13	0.63	0.00	0.00
query14	1.07	0.01	0.01
query15	0.90	0.00	0.01
query16	0.41	0.01	0.00
query17	1.06	0.00	0.00
query18	0.22	0.01	0.01
query19	1.93	0.00	0.00
query20	0.02	0.01	0.01
query21	15.37	0.00	0.00
query22	6.17	0.01	0.01
query23	16.19	0.00	0.00
query24	1.51	0.01	0.00
query25	0.23	0.00	0.00
query26	0.18	0.01	0.00
query27	0.11	0.00	0.01
query28	1.22	0.00	0.00
query29	13.30	0.00	0.00
query30	0.30	0.00	0.01
query31	2.32	0.01	0.00
query32	5.89	0.01	0.00
query33	4.36	0.01	0.00
query34	7.15	0.01	0.00
query35	6.11	0.00	0.01
query36	0.68	0.00	0.00
query37	0.11	0.01	0.00
query38	0.08	0.00	0.00
query39	0.05	0.00	0.00
query40	0.18	0.00	0.00
query41	0.10	0.01	0.00
query42	0.07	0.00	0.00
query43	0.05	0.00	0.01
Total cold run time: 93.77 s
Total hot run time: 0.08 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 18, 2025

FE Regression Coverage Report

Increment line coverage 50.00% (1/2) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2025

PR approved by anyone and no changes requested.

yujun777
yujun777 approved these changes Sep 19, 2025
View reviewed changes
Copy link
Contributor

@yujun777 yujun777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morrySnow morrySnow merged commit eae9856 into apache:master Sep 19, 2025
29 of 31 checks passed
@morrySnow morrySnow deleted the fix_abs_fold branch September 19, 2025 02:43
github-actions bot pushed a commit that referenced this pull request Sep 19, 2025
@morrySnow
[fix](fold constant) abs's return type should be argument type (#56190)
6086865
@github-actions github-actions bot mentioned this pull request Sep 19, 2025
Merged
morrySnow added a commit that referenced this pull request Sep 19, 2025
@github-actions @morrySnow
branch-3.1: [fix](fold constant) abs's return type should be argument…
7d3e601 
… type #56190 (#56210)

Cherry-picked from #56190

Co-authored-by: morrySnow <zhangwenxin@selectdb.com>
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jibing-Li Jibing-Li Jibing-Li approved these changes

+1 more reviewer

@yujun777 yujun777 yujun777 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@morrySnow @Thearas @doris-robot @hello-stephen @yujun777 @Jibing-Li