Skip to content

[fix](ubsan) fix ub error of uninitialized variable #56854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 1 commit into from
Oct 16, 2025
Merged

[fix](ubsan) fix ub error of uninitialized variable #56854

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions be/src/pipeline/exec/result_sink_operator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ struct ResultFileOptions {
std::vector<TParquetSchema> parquet_schemas;
TParquetCompressionType::type parquet_commpression_type;
TParquetVersion::type parquet_version;
bool parquert_disable_dictionary;
Copy link
Contributor

@yiguolei yiguolei Oct 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not init all the members of ResultFileOptions?

Copy link
Contributor Author

@morningman morningman Oct 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only primitive type like int and bool need init.
Other types have default constructor.

bool enable_int96_timestamps;
bool parquert_disable_dictionary = false;
bool enable_int96_timestamps = false;
//note: use outfile with parquet format, have deprecated 9:schema and 10:file_properties
//But in order to consider the compatibility when upgrading, so add a bool to check
//Now the code version is 1.1.2, so when the version is after 1.2, could remove this code.
Expand Down
Loading