Skip to content

[fix](nereids) fix rule AvgDistinctToSumDivCount need add cast #56887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 2 commits into from
Oct 16, 2025
Merged

[fix](nereids) fix rule AvgDistinctToSumDivCount need add cast #56887

morrySnow merged 2 commits into from
Oct 16, 2025

Conversation

@feiniaofeiafei
Copy link
Contributor

@feiniaofeiafei feiniaofeiafei commented Oct 13, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Oct 13, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@feiniaofeiafei
Copy link
Contributor Author

feiniaofeiafei commented Oct 13, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 13, 2025

TPC-DS: Total hot run time: 190986 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a4e019bb1ac4216ecb89b158ffdc2cf9775415b2, data reload: false

query1	1096	445	418	418
query2	6585	1706	1664	1664
query3	6755	222	218	218
query4	26130	23322	23307	23307
query5	4487	674	479	479
query6	325	242	230	230
query7	4650	513	303	303
query8	302	270	250	250
query9	8649	2571	2574	2571
query10	500	325	290	290
query11	15939	14988	14972	14972
query12	192	117	118	117
query13	1682	558	453	453
query14	11915	9303	9272	9272
query15	199	200	178	178
query16	7699	681	522	522
query17	1359	749	616	616
query18	2034	516	379	379
query19	237	238	186	186
query20	145	143	134	134
query21	280	141	132	132
query22	4717	4863	4629	4629
query23	34514	33893	33856	33856
query24	8347	2447	2424	2424
query25	594	577	524	524
query26	1284	289	178	178
query27	2762	567	385	385
query28	4493	2221	2238	2221
query29	801	640	506	506
query30	425	248	200	200
query31	956	812	770	770
query32	96	76	72	72
query33	609	388	347	347
query34	841	905	532	532
query35	840	860	822	822
query36	1048	1034	939	939
query37	129	112	88	88
query38	3724	3679	3689	3679
query39	1522	1477	1460	1460
query40	220	124	114	114
query41	61	61	57	57
query42	115	112	114	112
query43	492	499	461	461
query44	1346	831	827	827
query45	184	178	179	178
query46	836	992	643	643
query47	1762	1831	1794	1794
query48	395	431	334	334
query49	770	500	404	404
query50	646	693	407	407
query51	3939	3988	3880	3880
query52	113	111	108	108
query53	236	270	198	198
query54	600	579	522	522
query55	88	87	87	87
query56	350	319	323	319
query57	1197	1195	1141	1141
query58	292	296	293	293
query59	2585	2663	2552	2552
query60	351	339	330	330
query61	159	152	153	152
query62	800	725	672	672
query63	229	194	198	194
query64	4421	1148	852	852
query65	4011	3978	3977	3977
query66	1080	428	327	327
query67	15794	15289	15174	15174
query68	7526	995	595	595
query69	489	323	284	284
query70	1439	1301	1378	1301
query71	446	343	322	322
query72	6019	4969	4920	4920
query73	643	604	365	365
query74	9253	9082	8706	8706
query75	3290	3362	2802	2802
query76	3247	1170	748	748
query77	517	413	313	313
query78	9489	9519	8886	8886
query79	2531	844	598	598
query80	683	551	484	484
query81	520	265	231	231
query82	257	164	137	137
query83	266	270	252	252
query84	254	125	108	108
query85	940	542	547	542
query86	385	320	304	304
query87	3764	3754	3671	3671
query88	3971	2282	2378	2282
query89	381	333	302	302
query90	2046	217	216	216
query91	156	163	135	135
query92	86	69	67	67
query93	2148	956	635	635
query94	710	433	331	331
query95	399	316	317	316
query96	485	576	282	282
query97	2871	2983	2889	2889
query98	252	216	215	215
query99	1309	1442	1315	1315
Total cold run time: 278706 ms
Total hot run time: 190986 ms

@doris-robot
Copy link

doris-robot commented Oct 13, 2025

ClickBench: Total hot run time: 30.26 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a4e019bb1ac4216ecb89b158ffdc2cf9775415b2, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.05	0.06
query3	0.26	0.09	0.09
query4	1.60	0.11	0.12
query5	0.28	0.27	0.25
query6	1.17	0.65	0.65
query7	0.03	0.03	0.03
query8	0.05	0.05	0.05
query9	0.64	0.54	0.52
query10	0.58	0.57	0.59
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.63	0.61	0.63
query14	1.06	1.04	1.02
query15	0.88	0.85	0.88
query16	0.39	0.39	0.40
query17	1.05	1.06	1.04
query18	0.21	0.21	0.20
query19	1.96	1.87	1.87
query20	0.02	0.01	0.02
query21	15.45	0.97	0.58
query22	0.76	1.23	0.70
query23	14.87	1.42	0.64
query24	7.41	1.47	0.38
query25	0.43	0.19	0.13
query26	0.67	0.17	0.15
query27	0.06	0.05	0.05
query28	9.00	1.37	0.92
query29	12.57	3.92	3.34
query30	0.30	0.14	0.12
query31	2.83	0.59	0.38
query32	3.23	0.57	0.47
query33	3.16	3.24	3.08
query34	16.12	5.45	4.89
query35	4.89	4.96	4.95
query36	0.69	0.51	0.50
query37	0.10	0.07	0.07
query38	0.07	0.05	0.04
query39	0.04	0.03	0.03
query40	0.17	0.16	0.15
query41	0.08	0.05	0.04
query42	0.05	0.03	0.03
query43	0.05	0.03	0.03
Total cold run time: 104.27 s
Total hot run time: 30.26 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2025

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 13, 2025

FE UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉
Increment coverage report
Complete coverage report

@feiniaofeiafei feiniaofeiafei force-pushed the fix_AvgDistinctToSumDivCount branch from a4e019b to f0c061e Compare October 13, 2025 06:33
@feiniaofeiafei
Copy link
Contributor Author

feiniaofeiafei commented Oct 13, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 13, 2025

TPC-DS: Total hot run time: 190250 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f0c061effadfbd02b5a88db1bf181a999b89aaf5, data reload: false

query1	1066	437	411	411
query2	6550	1692	1680	1680
query3	6754	224	230	224
query4	26347	23892	23107	23107
query5	5274	653	498	498
query6	319	254	233	233
query7	4657	514	289	289
query8	305	251	235	235
query9	8711	2579	2600	2579
query10	544	338	301	301
query11	15553	15120	14905	14905
query12	185	118	112	112
query13	1673	549	423	423
query14	11489	9189	9330	9189
query15	210	185	171	171
query16	7636	677	503	503
query17	1362	779	604	604
query18	2056	459	382	382
query19	264	246	178	178
query20	140	141	147	141
query21	223	140	122	122
query22	4760	4828	4593	4593
query23	35325	34480	33878	33878
query24	9592	2490	2462	2462
query25	592	543	491	491
query26	1470	299	173	173
query27	3001	524	363	363
query28	4448	2199	2247	2199
query29	828	654	487	487
query30	343	240	224	224
query31	976	861	790	790
query32	83	80	83	80
query33	602	394	355	355
query34	827	890	554	554
query35	845	871	811	811
query36	1032	1060	977	977
query37	129	108	88	88
query38	3493	3535	3507	3507
query39	1483	1425	1409	1409
query40	218	125	119	119
query41	61	59	61	59
query42	124	119	111	111
query43	486	504	481	481
query44	1325	835	824	824
query45	191	178	181	178
query46	826	999	649	649
query47	1782	1854	1728	1728
query48	397	413	347	347
query49	763	521	416	416
query50	623	680	401	401
query51	3929	4011	3880	3880
query52	107	107	104	104
query53	237	270	197	197
query54	584	578	518	518
query55	88	83	89	83
query56	306	345	305	305
query57	1186	1212	1133	1133
query58	279	274	285	274
query59	2613	2728	2504	2504
query60	341	344	334	334
query61	159	152	148	148
query62	831	734	683	683
query63	229	191	190	190
query64	4507	1247	929	929
query65	4076	3998	3988	3988
query66	1095	451	355	355
query67	15734	15372	15183	15183
query68	8078	945	598	598
query69	518	343	293	293
query70	1406	1258	1325	1258
query71	516	352	395	352
query72	5987	4924	4915	4915
query73	695	608	355	355
query74	9186	9250	8822	8822
query75	4065	3366	2879	2879
query76	3785	1249	732	732
query77	813	393	317	317
query78	9743	9738	8880	8880
query79	2842	833	587	587
query80	677	555	485	485
query81	504	269	231	231
query82	463	162	130	130
query83	294	256	251	251
query84	303	115	87	87
query85	933	464	415	415
query86	359	333	301	301
query87	3781	3771	3662	3662
query88	3742	2195	2212	2195
query89	412	328	296	296
query90	2040	221	212	212
query91	162	159	139	139
query92	84	69	64	64
query93	2029	968	638	638
query94	686	438	324	324
query95	393	319	318	318
query96	482	570	284	284
query97	2962	3012	2870	2870
query98	243	219	218	218
query99	1463	1434	1293	1293
Total cold run time: 283890 ms
Total hot run time: 190250 ms

@doris-robot
Copy link

doris-robot commented Oct 13, 2025

ClickBench: Total hot run time: 30.64 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f0c061effadfbd02b5a88db1bf181a999b89aaf5, data reload: false

query1	0.06	0.04	0.05
query2	0.10	0.05	0.06
query3	0.25	0.09	0.09
query4	1.61	0.13	0.13
query5	0.29	0.27	0.26
query6	1.20	0.65	0.64
query7	0.04	0.03	0.03
query8	0.06	0.04	0.04
query9	0.63	0.54	0.51
query10	0.59	0.61	0.58
query11	0.16	0.11	0.12
query12	0.15	0.13	0.12
query13	0.63	0.62	0.61
query14	1.04	1.06	1.02
query15	0.86	0.88	0.87
query16	0.40	0.40	0.40
query17	1.06	1.05	1.04
query18	0.21	0.20	0.20
query19	1.99	1.78	1.86
query20	0.02	0.02	0.02
query21	15.45	0.93	0.58
query22	0.76	1.18	0.70
query23	14.91	1.42	0.65
query24	6.85	2.45	1.00
query25	0.48	0.24	0.09
query26	0.55	0.17	0.13
query27	0.06	0.06	0.05
query28	9.73	1.34	0.94
query29	12.59	3.98	3.31
query30	0.28	0.13	0.12
query31	2.83	0.61	0.38
query32	3.26	0.56	0.48
query33	3.05	3.09	3.09
query34	16.17	5.48	4.84
query35	4.97	4.94	4.86
query36	0.69	0.51	0.50
query37	0.10	0.08	0.07
query38	0.07	0.05	0.04
query39	0.04	0.03	0.04
query40	0.20	0.17	0.15
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.05	0.03	0.03
Total cold run time: 104.57 s
Total hot run time: 30.64 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 13, 2025

FE Regression Coverage Report

Increment line coverage 100.00% (2/2) 🎉
Increment coverage report
Complete coverage report

@feiniaofeiafei
Copy link
Contributor Author

feiniaofeiafei commented Oct 14, 2025

run p0

@feiniaofeiafei
Copy link
Contributor Author

feiniaofeiafei commented Oct 14, 2025

run nonconcurrent

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 14, 2025

FE Regression Coverage Report

Increment line coverage 100.00% (2/2) 🎉
Increment coverage report
Complete coverage report

@feiniaofeiafei
Copy link
Contributor Author

feiniaofeiafei commented Oct 14, 2025

run nonconcurrent

@feiniaofeiafei
Copy link
Contributor Author

feiniaofeiafei commented Oct 15, 2025

run NonConcurrent

@feiniaofeiafei
Copy link
Contributor Author

feiniaofeiafei commented Oct 15, 2025

run NonConcurrent Regression

@feiniaofeiafei
Copy link
Contributor Author

feiniaofeiafei commented Oct 15, 2025

run nonConcurrent

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 15, 2025

FE Regression Coverage Report

Increment line coverage 100.00% (2/2) 🎉
Increment coverage report
Complete coverage report

@morrySnow morrySnow merged commit 16c62be into apache:master Oct 16, 2025
26 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 16, 2025
@feiniaofeiafei
[fix](nereids) fix rule AvgDistinctToSumDivCount need add cast (#56887)
5e0e2b2
@github-actions github-actions bot mentioned this pull request Oct 16, 2025
Merged
yiguolei pushed a commit that referenced this pull request Oct 17, 2025
@github-actions @feiniaofeiafei
branch-4.0: [fix](nereids) fix rule AvgDistinctToSumDivCount need add…
fc541ed 
… cast #56887 (#57056)

Cherry-picked from #56887

Co-authored-by: feiniaofeiafei <moailing@selectdb.com>
github-actions bot pushed a commit that referenced this pull request Nov 25, 2025
@feiniaofeiafei
[fix](nereids) fix rule AvgDistinctToSumDivCount need add cast (#56887)
0a276b0
@github-actions github-actions bot mentioned this pull request Nov 25, 2025
Merged
morrySnow pushed a commit that referenced this pull request Nov 26, 2025
@github-actions @feiniaofeiafei
branch-3.1: [fix](nereids) fix rule AvgDistinctToSumDivCount need add…
66b3727 
… cast #56887 (#58330)

Cherry-picked from #56887

Co-authored-by: feiniaofeiafei <moailing@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starocean999 starocean999 starocean999 approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.4-merged dev/4.0.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@feiniaofeiafei @Thearas @doris-robot @hello-stephen @starocean999 @morrySnow @yiguolei