Skip to content

[fix] Check rs meta size during cool down progress #57368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hello-stephen merged 6 commits into from
Dec 31, 2025
Merged

[fix] Check rs meta size during cool down progress #57368

hello-stephen merged 6 commits into from
Dec 31, 2025
+9 −1

Conversation

@zhaorongsheng
Copy link
Contributor

@zhaorongsheng zhaorongsheng commented Oct 27, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #57367

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 27, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhaorongsheng
Copy link
Contributor Author

zhaorongsheng commented Oct 27, 2025

run buildall

@zhaorongsheng
Copy link
Contributor Author

zhaorongsheng commented Oct 27, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 27, 2025

ClickBench: Total hot run time: 29.02 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 65001b7485725ce1144c62338ae1bdad80e190b7, data reload: false

query1	0.06	0.06	0.05
query2	0.10	0.06	0.06
query3	0.26	0.10	0.10
query4	1.61	0.13	0.13
query5	0.31	0.28	0.30
query6	1.22	0.66	0.68
query7	0.05	0.03	0.03
query8	0.07	0.04	0.05
query9	0.66	0.55	0.56
query10	0.62	0.62	0.62
query11	0.19	0.14	0.14
query12	0.18	0.14	0.14
query13	0.64	0.62	0.61
query14	1.07	1.04	1.03
query15	0.89	0.91	0.91
query16	0.42	0.43	0.44
query17	1.16	1.21	1.14
query18	0.24	0.23	0.22
query19	2.00	1.91	1.93
query20	0.01	0.02	0.01
query21	15.36	0.23	0.17
query22	4.94	0.09	0.05
query23	15.61	0.32	0.11
query24	2.22	0.74	0.33
query25	0.08	0.07	0.07
query26	0.17	0.17	0.15
query27	0.07	0.07	0.06
query28	3.92	1.19	0.95
query29	12.59	4.62	3.77
query30	0.30	0.16	0.15
query31	2.83	0.68	0.42
query32	3.25	0.60	0.49
query33	3.20	3.08	3.16
query34	15.96	5.27	4.57
query35	4.67	4.66	4.64
query36	0.72	0.53	0.53
query37	0.11	0.07	0.07
query38	0.07	0.05	0.05
query39	0.05	0.04	0.03
query40	0.20	0.15	0.15
query41	0.09	0.04	0.04
query42	0.05	0.04	0.04
query43	0.05	0.04	0.04
Total cold run time: 98.27 s
Total hot run time: 29.02 s

@zhaorongsheng
Copy link
Contributor Author

zhaorongsheng commented Oct 28, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 28, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.76% (18055/34221)
Line Coverage 37.99% (163686/430872)
Region Coverage 32.36% (124741/385479)
Branch Coverage 33.73% (54546/161715)

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 28, 2025

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.36% (23925/33526)
Line Coverage 57.75% (248714/430673)
Region Coverage 52.85% (206219/390194)
Branch Coverage 54.56% (88652/162488)

@zhaorongsheng
Copy link
Contributor Author

zhaorongsheng commented Oct 29, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 29, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.77% (18065/34236)
Line Coverage 38.00% (163826/431108)
Region Coverage 32.37% (124876/385737)
Branch Coverage 33.74% (54606/161821)

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 29, 2025

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.42% (23959/33548)
Line Coverage 57.84% (249324/431043)
Region Coverage 53.03% (207150/390631)
Branch Coverage 54.69% (88984/162712)

gavinchou
gavinchou previously approved these changes Dec 18, 2025
View reviewed changes
gavinchou
gavinchou reviewed Dec 18, 2025
View reviewed changes
@gavinchou gavinchou self-requested a review December 18, 2025 15:38
@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Dec 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

PR approved by anyone and no changes requested.

@gavinchou
Copy link
Contributor

gavinchou commented Dec 18, 2025

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 18, 2025
@doris-robot
Copy link

doris-robot commented Dec 18, 2025

TPC-H: Total hot run time: 34906 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a4fbef8ce522e0a3f5ef20575124137c32553969, data reload: false

------ Round 1 ----------------------------------
q1	17719	4222	4041	4041
q2	2058	347	231	231
q3	10154	1315	730	730
q4	10201	793	306	306
q5	7540	2086	1949	1949
q6	181	169	138	138
q7	992	849	698	698
q8	9361	1363	1127	1127
q9	7129	5369	5341	5341
q10	6879	2419	1959	1959
q11	527	330	308	308
q12	746	752	583	583
q13	17795	3675	3047	3047
q14	287	307	271	271
q15	608	530	513	513
q16	672	670	621	621
q17	716	838	479	479
q18	7434	7218	7177	7177
q19	1133	965	597	597
q20	411	363	249	249
q21	4202	3915	3572	3572
q22	1057	1017	969	969
Total cold run time: 107802 ms
Total hot run time: 34906 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4082	3992	4049	3992
q2	334	396	313	313
q3	2082	2646	2270	2270
q4	1348	1753	1295	1295
q5	4240	4527	4750	4527
q6	247	187	141	141
q7	2079	2069	1806	1806
q8	2641	2596	2508	2508
q9	7493	7553	7574	7553
q10	3077	3330	2828	2828
q11	597	524	514	514
q12	678	816	650	650
q13	3575	4090	3324	3324
q14	308	316	283	283
q15	554	511	517	511
q16	649	667	640	640
q17	1203	1442	1434	1434
q18	7831	7891	7575	7575
q19	890	826	863	826
q20	1951	1969	1813	1813
q21	4640	4160	4215	4160
q22	1125	1035	999	999
Total cold run time: 51624 ms
Total hot run time: 49962 ms

@doris-robot
Copy link

doris-robot commented Dec 18, 2025

TPC-DS: Total hot run time: 178667 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a4fbef8ce522e0a3f5ef20575124137c32553969, data reload: false

query5	4424	615	445	445
query6	335	243	227	227
query7	4222	472	273	273
query8	328	282	247	247
query9	8785	2503	2529	2503
query10	495	374	331	331
query11	14913	15081	14548	14548
query12	179	121	124	121
query13	1279	517	407	407
query14	5953	3029	2710	2710
query14_1	2642	2616	2634	2616
query15	207	197	178	178
query16	849	464	401	401
query17	1111	682	597	597
query18	2416	429	345	345
query19	231	235	202	202
query20	114	116	112	112
query21	223	140	116	116
query22	4074	3935	3956	3935
query23	16574	16338	15987	15987
query23_1	16119	16187	16088	16088
query24	7342	1644	1233	1233
query24_1	1228	1217	1235	1217
query25	606	479	436	436
query26	1246	268	164	164
query27	2757	449	312	312
query28	4521	2118	2100	2100
query29	815	540	442	442
query30	321	247	212	212
query31	828	687	622	622
query32	75	70	68	68
query33	524	343	283	283
query34	892	904	536	536
query35	793	812	745	745
query36	864	904	817	817
query37	126	90	76	76
query38	2811	2897	2852	2852
query39	752	747	718	718
query39_1	700	709	696	696
query40	231	144	121	121
query41	68	64	62	62
query42	115	107	103	103
query43	422	450	406	406
query44	1327	738	746	738
query45	196	188	180	180
query46	865	977	627	627
query47	1686	1689	1631	1631
query48	353	320	241	241
query49	682	444	356	356
query50	657	301	231	231
query51	3829	3831	3866	3831
query52	100	113	100	100
query53	310	346	291	291
query54	286	259	244	244
query55	78	76	73	73
query56	294	301	291	291
query57	1175	1167	1085	1085
query58	270	260	262	260
query59	2395	2484	2387	2387
query60	305	325	283	283
query61	163	161	159	159
query62	710	670	627	627
query63	336	300	312	300
query64	5077	1309	1121	1121
query65	4036	3956	3933	3933
query66	1484	444	332	332
query67	15002	15029	15072	15029
query68	2711	1059	763	763
query69	452	342	310	310
query70	1068	952	988	952
query71	316	295	278	278
query72	6186	4938	4972	4938
query73	496	565	314	314
query74	8457	8941	8696	8696
query75	3124	3177	2813	2813
query76	2860	1121	773	773
query77	373	398	296	296
query78	9467	9687	8833	8833
query79	1013	857	607	607
query80	710	650	581	581
query81	503	275	231	231
query82	330	138	105	105
query83	267	256	242	242
query84	257	118	106	106
query85	869	502	472	472
query86	341	302	289	289
query87	2954	3047	2987	2987
query88	3165	2310	2285	2285
query89	467	426	393	393
query90	1908	162	161	161
query91	199	186	170	170
query92	76	68	65	65
query93	946	888	556	556
query94	381	328	298	298
query95	584	404	317	317
query96	592	451	208	208
query97	2248	2331	2249	2249
query98	203	196	199	196
query99	1287	1312	1223	1223
Total cold run time: 250133 ms
Total hot run time: 178667 ms

@doris-robot
Copy link

doris-robot commented Dec 18, 2025

ClickBench: Total hot run time: 27.29 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a4fbef8ce522e0a3f5ef20575124137c32553969, data reload: false

query1	0.05	0.04	0.05
query2	0.10	0.05	0.05
query3	0.26	0.08	0.09
query4	1.61	0.11	0.11
query5	0.29	0.26	0.25
query6	1.18	0.64	0.63
query7	0.04	0.03	0.02
query8	0.06	0.05	0.04
query9	0.60	0.52	0.52
query10	0.56	0.57	0.56
query11	0.15	0.10	0.11
query12	0.15	0.11	0.12
query13	0.63	0.60	0.60
query14	1.00	0.98	0.99
query15	0.81	0.81	0.82
query16	0.39	0.40	0.42
query17	1.04	1.04	1.06
query18	0.23	0.22	0.21
query19	1.98	1.87	1.73
query20	0.02	0.02	0.01
query21	15.44	0.28	0.14
query22	4.66	0.05	0.05
query23	16.03	0.28	0.09
query24	1.90	0.29	1.18
query25	0.12	0.12	0.06
query26	0.14	0.13	0.13
query27	0.06	0.05	0.06
query28	5.02	1.23	1.03
query29	12.62	4.04	3.20
query30	0.28	0.14	0.12
query31	2.82	0.64	0.38
query32	3.24	0.55	0.47
query33	3.07	3.02	3.00
query34	16.79	5.20	4.56
query35	4.60	4.61	4.62
query36	0.65	0.49	0.49
query37	0.11	0.06	0.07
query38	0.07	0.04	0.03
query39	0.04	0.02	0.02
query40	0.16	0.14	0.13
query41	0.09	0.04	0.03
query42	0.05	0.04	0.03
query43	0.04	0.04	0.03
Total cold run time: 99.15 s
Total hot run time: 27.29 s

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 29, 2025
dataroaring
dataroaring approved these changes Dec 31, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot
Copy link

doris-robot commented Dec 31, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.38% (18955/35510)
Line Coverage 39.27% (175972/448083)
Region Coverage 33.85% (136219/402428)
Branch Coverage 34.78% (58819/169140)

@hello-stephen hello-stephen merged commit 9140b21 into apache:master Dec 31, 2025
31 of 33 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 31, 2025
@zhaorongsheng
[fix] Check rs meta size during cool down progress (#57368)
11805a3 
### What problem does this PR solve?

Issue Number: close #57367
@github-actions github-actions bot mentioned this pull request Dec 31, 2025
Open
github-actions bot pushed a commit that referenced this pull request Dec 31, 2025
@zhaorongsheng
[fix] Check rs meta size during cool down progress (#57368)
6a0379e 
### What problem does this PR solve?

Issue Number: close #57367
@github-actions github-actions bot mentioned this pull request Dec 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.x dev/3.0.x dev/3.1.x dev/4.0.x reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Be core during hot/cold cooldown progress

5 participants

@zhaorongsheng @hello-stephen @doris-robot @gavinchou @dataroaring