-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[feature](search) add phrase/wildcard/regex support for search and refact some code #57372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82 changes: 82 additions & 0 deletions
82
be/src/olap/rowset/segment_v2/inverted_index/query_v2/null_bitmap_fetcher.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| #pragma once | ||
|
|
||
| #include <glog/logging.h> | ||
|
|
||
| #include <memory> | ||
| #include <roaring/roaring.hh> | ||
| #include <string> | ||
|
|
||
| #include "olap/rowset/segment_v2/index_iterator.h" | ||
| #include "olap/rowset/segment_v2/inverted_index/query_v2/scorer.h" | ||
| #include "olap/rowset/segment_v2/inverted_index/query_v2/weight.h" | ||
| #include "olap/rowset/segment_v2/inverted_index_cache.h" | ||
|
|
||
| namespace doris::segment_v2::inverted_index::query_v2 { | ||
|
|
||
| // Small helper that centralizes "field NULL bitmap" lookups so weights/scorers | ||
| // don't have to duplicate resolver plumbing. | ||
| class FieldNullBitmapFetcher { | ||
| public: | ||
| FieldNullBitmapFetcher() = delete; | ||
|
|
||
| static std::shared_ptr<roaring::Roaring> fetch(const QueryExecutionContext& context, | ||
| const std::string& logical_field, | ||
| const Scorer* scorer = nullptr) { | ||
| return fetch(context.null_resolver, logical_field, scorer); | ||
| } | ||
|
|
||
| static std::shared_ptr<roaring::Roaring> fetch(const NullBitmapResolver* resolver, | ||
| const std::string& logical_field, | ||
| const Scorer* scorer = nullptr) { | ||
| if (resolver == nullptr || logical_field.empty()) { | ||
| return nullptr; | ||
| } | ||
|
|
||
| EmptyScorer fallback_scorer; | ||
| const Scorer* resolver_scorer = scorer != nullptr ? scorer : &fallback_scorer; | ||
|
|
||
| auto iterator = resolver->iterator_for(*resolver_scorer, logical_field); | ||
| if (iterator == nullptr) { | ||
| return nullptr; | ||
| } | ||
|
|
||
| auto has_null = iterator->has_null(); | ||
| if (!has_null.has_value() || !has_null.value()) { | ||
| return nullptr; | ||
| } | ||
|
|
||
| segment_v2::InvertedIndexQueryCacheHandle cache_handle; | ||
| auto status = iterator->read_null_bitmap(&cache_handle); | ||
| if (!status.ok()) { | ||
| LOG(WARNING) << "Failed to read null bitmap for field '" << logical_field | ||
| << "': " << status.to_string(); | ||
| return nullptr; | ||
| } | ||
|
|
||
| auto bitmap_ptr = cache_handle.get_bitmap(); | ||
| if (bitmap_ptr == nullptr) { | ||
| return nullptr; | ||
| } | ||
|
|
||
| return std::make_shared<roaring::Roaring>(*bitmap_ptr); | ||
| } | ||
| }; | ||
|
|
||
| } // namespace doris::segment_v2::inverted_index::query_v2 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The class documentation uses informal language ('Small helper'). Consider more professional phrasing such as: 'Utility class that centralizes field NULL bitmap lookups to avoid duplicating resolver logic across weights and scorers.'