-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[opt](filecache) schema change adaptive to file cache #57470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opt](filecache) schema change adaptive to file cache #57470
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
| DCHECK_EQ(_output_rowset->version(), _input_rowsets[0]->version()); | ||
| // MUST NOT move input rowset to stale path. | ||
| cloud_tablet()->add_rowsets({_output_rowset}, true, wrlock); | ||
| cloud_tablet()->add_rowsets({_output_rowset}, true, wrlock, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be also fixed, we cannot always warm up data when doing index compaction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in a separate PR
|
run buildall |
1 similar comment
|
run buildall |
TPC-DS: Total hot run time: 190149 ms |
ClickBench: Total hot run time: 27.81 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
7974597 to
915dcbd
Compare
fecf849 to
c33eb68
Compare
|
run buildall |
TPC-H: Total hot run time: 35645 ms |
TPC-DS: Total hot run time: 187610 ms |
ClickBench: Total hot run time: 27.32 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
| double input_hit_rate = static_cast<double>(cached_index_size + cached_data_size) / total_size; | ||
|
|
||
| if (input_hit_rate > config::file_cache_keep_schema_change_output_min_hit_ratio) { | ||
| return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add LOG(INFO) here to clarify the decision
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tabletid, xxx_size, ratio, etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I wiil add LOG here.
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
TPC-H: Total hot run time: 34471 ms |
|
run cloud_p0 |
TPC-DS: Total hot run time: 183967 ms |
ClickBench: Total hot run time: 28.02 s |
|
run cloud_p0 |
|
run buildall |
TPC-H: Total hot run time: 34263 ms |
TPC-DS: Total hot run time: 184847 ms |
ClickBench: Total hot run time: 27.55 s |
|
run check_coverage |
|
skip check_coverage |
No description provided.