-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](maxcompute)fix maxcompute push down predicates null pointer. #57474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
ClickBench: Total hot run time: 27.85 s |
Contributor
FE Regression Coverage ReportIncrement line coverage |
morningman
approved these changes
Oct 31, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
CalvinKirs
approved these changes
Oct 31, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Oct 31, 2025
…57474) ### What problem does this PR solve? Problem Summary: This PR is a continuation of PR #55635. Based on the current investigation, the conclusion in PR #55635 appears to be incorrect — the reason why the predicate column cannot be found in the columnMap remains unclear. To help with further debugging, this PR adds additional log information. In addition, during the `refresh table` process, the MaxComputeExternalTable object remains unchanged, so the objects it holds also stay the same. When initializing the table schema, the map maintained by this object may have repeated `put` operations. So, move this map to `MaxComputeSchemaCacheValue`, which better matches its lifecycle and avoids repeated updates during table refresh.
github-actions bot
pushed a commit
that referenced
this pull request
Oct 31, 2025
…57474) ### What problem does this PR solve? Problem Summary: This PR is a continuation of PR #55635. Based on the current investigation, the conclusion in PR #55635 appears to be incorrect — the reason why the predicate column cannot be found in the columnMap remains unclear. To help with further debugging, this PR adds additional log information. In addition, during the `refresh table` process, the MaxComputeExternalTable object remains unchanged, so the objects it holds also stay the same. When initializing the table schema, the map maintained by this object may have repeated `put` operations. So, move this map to `MaxComputeSchemaCacheValue`, which better matches its lifecycle and avoids repeated updates during table refresh.
dwdwqfwe
pushed a commit
to dwdwqfwe/doris
that referenced
this pull request
Oct 31, 2025
…pache#57474) ### What problem does this PR solve? Problem Summary: This PR is a continuation of PR apache#55635. Based on the current investigation, the conclusion in PR apache#55635 appears to be incorrect — the reason why the predicate column cannot be found in the columnMap remains unclear. To help with further debugging, this PR adds additional log information. In addition, during the `refresh table` process, the MaxComputeExternalTable object remains unchanged, so the objects it holds also stay the same. When initializing the table schema, the map maintained by this object may have repeated `put` operations. So, move this map to `MaxComputeSchemaCacheValue`, which better matches its lifecycle and avoids repeated updates during table refresh.
w41ter
pushed a commit
to w41ter/incubator-doris
that referenced
this pull request
Dec 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
dev/3.1.3-merged
dev/4.0.1-merged
reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
This PR is a continuation of PR #55635. Based on the current investigation, the conclusion in PR #55635 appears to be incorrect — the reason why the predicate column cannot be found in the columnMap remains unclear.
To help with further debugging, this PR adds additional log information.
In addition, during the
refresh tableprocess, the MaxComputeExternalTable object remains unchanged, so the objects it holds also stay the same. When initializing the table schema, the map maintained by this object may have repeatedputoperations. So, move this map toMaxComputeSchemaCacheValue, which better matches its lifecycle and avoids repeated updates during table refresh.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)