Skip to content

branch-4.0: [Improve](audit) sql that fails to be syntax parsed is not audited #48527 #57496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Nov 5, 2025
Merged

branch-4.0: [Improve](audit) sql that fails to be syntax parsed is not audited #48527 #57496

yiguolei merged 1 commit into from
Nov 5, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 30, 2025

Cherry-picked from #48527

@github-actions github-actions bot requested a review from yiguolei as a code owner October 30, 2025 06:24
@Thearas
Copy link
Contributor

Thearas commented Oct 30, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Oct 30, 2025
@Thearas
Copy link
Contributor

Thearas commented Oct 30, 2025

run buildall

@qzsee @yiguolei
[Improve](audit) sql that fails to be syntax parsed is not audited (#…
7279499 
…48527)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #47595

Problem Summary:

For PR #47595 , set `stmt` to `error messsage` of
`org.apache.doris.qe.QueryState.ErrType#ANALYSIS_ERR` of query audit, so
many of the original SQL will be abandoned, this is very unreasonable,
It is now more appropriate to set stmt to error message only for queries
that are syntax parsed incorrectly

Now only sql with syntax errors is ignored

Co-authored-by: garenshi <garenshi@tencent.com>
@yiguolei yiguolei force-pushed the auto-pick-48527-branch-4.0 branch from 98aaf94 to 7279499 Compare November 5, 2025 01:52
@yiguolei
Copy link
Contributor

yiguolei commented Nov 5, 2025

run buildall

@yiguolei yiguolei merged commit ffd505c into branch-4.0 Nov 5, 2025
25 of 29 checks passed
@github-actions github-actions bot deleted the auto-pick-48527-branch-4.0 branch November 5, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Thearas @yiguolei @dataroaring @qzsee