Skip to content

[Bug](Jni)should delete local ref after convert to global ref #57513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zclllyybb merged 1 commit into from
Oct 31, 2025
Merged

[Bug](Jni)should delete local ref after convert to global ref #57513

zclllyybb merged 1 commit into from
Oct 31, 2025

Conversation

@zhangstar333
Copy link
Contributor

@zhangstar333 zhangstar333 commented Oct 30, 2025

What problem does this PR solve?

Problem Summary:
hashmap_local_object is NewObject as local ref, and it's convert to global ref to as return value,
so should call delete local ref to avoid JVM can't GC.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Oct 30, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333
Copy link
Contributor Author

zhangstar333 commented Oct 30, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 30, 2025

ClickBench: Total hot run time: 29.17 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b1e691fc7e5caefb94affc322c1b7a7c57b1539f, data reload: false

query1	0.07	0.06	0.06
query2	0.11	0.06	0.06
query3	0.26	0.09	0.09
query4	1.61	0.12	0.13
query5	0.29	0.28	0.28
query6	1.21	0.68	0.67
query7	0.04	0.03	0.03
query8	0.06	0.05	0.05
query9	0.66	0.56	0.57
query10	0.63	0.62	0.63
query11	0.19	0.14	0.14
query12	0.22	0.14	0.14
query13	0.64	0.62	0.62
query14	1.07	1.04	1.04
query15	0.90	0.92	0.92
query16	0.46	0.42	0.44
query17	1.09	1.15	1.22
query18	0.26	0.23	0.23
query19	2.02	1.90	1.96
query20	0.02	0.01	0.02
query21	15.37	0.21	0.16
query22	5.05	0.08	0.06
query23	15.62	0.31	0.12
query24	2.88	0.88	0.31
query25	0.08	0.07	0.06
query26	0.16	0.15	0.16
query27	0.07	0.06	0.06
query28	4.62	1.22	0.97
query29	12.64	4.78	3.80
query30	0.32	0.18	0.16
query31	2.83	0.68	0.42
query32	3.26	0.60	0.50
query33	3.11	3.12	3.22
query34	15.88	5.30	4.64
query35	4.61	4.58	4.65
query36	0.70	0.55	0.53
query37	0.11	0.08	0.07
query38	0.07	0.06	0.05
query39	0.05	0.04	0.04
query40	0.19	0.15	0.15
query41	0.10	0.04	0.04
query42	0.05	0.04	0.03
query43	0.06	0.04	0.04
Total cold run time: 99.64 s
Total hot run time: 29.17 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 30, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.71% (18041/34224)
Line Coverage 37.96% (163720/431246)
Region Coverage 32.36% (124924/386099)
Branch Coverage 33.71% (54590/161953)

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 30, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.40% (24013/33631)
Line Coverage 57.83% (249716/431824)
Region Coverage 52.96% (207366/391533)
Branch Coverage 54.64% (89082/163024)

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 31, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.31% (24320/33631)
Line Coverage 59.14% (255373/431824)
Region Coverage 54.97% (215226/391533)
Branch Coverage 56.35% (91867/163024)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 31, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025

PR approved by anyone and no changes requested.

@yiguolei yiguolei added dev/3.1.x dev/4.0.x and removed approved Indicates a PR has been approved by one committer. reviewed labels Oct 31, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 31, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.31% (24320/33631)
Line Coverage 59.14% (255373/431824)
Region Coverage 54.97% (215226/391533)
Branch Coverage 56.35% (91867/163024)

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Oct 31, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025

PR approved by anyone and no changes requested.

@zclllyybb zclllyybb merged commit f3ac7db into apache:master Oct 31, 2025
29 of 31 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 31, 2025
@zhangstar333
[Bug](Jni)should delete local ref after convert to global ref (#57513)
ea5439c 
hashmap_local_object is NewObject as local ref, and it's convert to global ref to as return value, so should call delete local ref to avoid JVM can't GC.
@github-actions github-actions bot mentioned this pull request Oct 31, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Oct 31, 2025
@zhangstar333
[Bug](Jni)should delete local ref after convert to global ref (#57513)
98ef6a3 
hashmap_local_object is NewObject as local ref, and it's convert to global ref to as return value, so should call delete local ref to avoid JVM can't GC.
@github-actions github-actions bot mentioned this pull request Oct 31, 2025
Merged
zhangstar333 added a commit that referenced this pull request Nov 4, 2025
@zhangstar333
[Bug](Jni)should delete local ref after convert to global ref (#57513)
7fde40b 
hashmap_local_object is NewObject as local ref, and it's convert to global ref to as return value, so should call delete local ref to avoid JVM can't GC.
morrySnow pushed a commit that referenced this pull request Nov 4, 2025
@github-actions @zhangstar333
branch-3.1: [Bug](Jni)should delete local ref after convert to global…
f5f1a6c 
… ref #57513 (#57597)

Cherry-picked from #57513

Co-authored-by: zhangstar333 <zhangsida@selectdb.com>
yiguolei pushed a commit that referenced this pull request Nov 4, 2025
@github-actions @zhangstar333
branch-4.0: [Bug](Jni)should delete local ref after convert to global…
eb4a8f6 
… ref #57513 (#57598)

Cherry-picked from #57513

Co-authored-by: zhangstar333 <zhangsida@selectdb.com>
w41ter pushed a commit to w41ter/incubator-doris that referenced this pull request Dec 26, 2025
@zhangstar333
[Bug](Jni)should delete local ref after convert to global ref apache#…
e3f13c6 
…57513 (apache#6300)

pick: apache#57513
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@zclllyybb zclllyybb zclllyybb approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.3-merged dev/4.0.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@zhangstar333 @Thearas @doris-robot @hello-stephen @yiguolei @zclllyybb @morningman @morrySnow