[fix](nereids)PushDownJoinOnAssertNumRows create invalid LogicalProject node #57804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-DS: Total hot run time: 188851 ms |
ClickBench: Total hot run time: 27.49 s |
englefly
previously approved these changes
Nov 11, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
morrySnow
previously approved these changes
Nov 11, 2025
morrySnow
reviewed
Nov 11, 2025
| return null; | ||
| } | ||
|
|
||
| private LogicalProject<? extends Plan> projectAliasOnPlan(List<Alias> projections, Plan child) { |
Contributor
There was a problem hiding this comment.
add ut for this function
starocean999
dismissed stale reviews from morrySnow and englefly
via
9ca02ea
starocean999
force-pushed
the
nereids_1107
branch
from
2ba9bb3 to
9ca02ea
Compare
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
TPC-H: Total hot run time: 34387 ms |
TPC-DS: Total hot run time: 188885 ms |
ClickBench: Total hot run time: 27.43 s |
Contributor
FE Regression Coverage ReportIncrement line coverage |
1 similar comment
Contributor
FE Regression Coverage ReportIncrement line coverage |
morrySnow
approved these changes
Nov 13, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
englefly
approved these changes
Nov 13, 2025
Contributor
FE Regression Coverage ReportIncrement line coverage |
wyxxxcat
pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Nov 13, 2025
…ct node (apache#57804) when push alias into child node, we should always create a new project node for it. input: ``` Alias->cast(col_int_undef_signed#30 as DOUBLE) AS `cast(col_int_undef_signed as DOUBLE)`apache#70 childProject->LogicalProject(projects=[col_int_undef_signed2#50 AS `col_int_undef_signed`apache#30]) ``` error case: ```LogicalProject(projects=[col_int_undef_signed2#50 AS `col_int_undef_signed`apache#30, cast(col_int_undef_signed#30 as DOUBLE) AS `cast(col_int_undef_signed as DOUBLE)`apache#70])``` correct: ``` LogicalProject(projects=[col_int_undef_signed#30, cast(col_int_undef_signed#30 as DOUBLE) AS `cast(col_int_undef_signed as DOUBLE)`apache#70]) LogicalProject(projects=[col_int_undef_signed2#50 AS `col_int_undef_signed`apache#30]) ```
wyxxxcat
pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Nov 18, 2025
…ct node (apache#57804) when push alias into child node, we should always create a new project node for it. input: ``` Alias->cast(col_int_undef_signed#30 as DOUBLE) AS `cast(col_int_undef_signed as DOUBLE)`apache#70 childProject->LogicalProject(projects=[col_int_undef_signed2#50 AS `col_int_undef_signed`apache#30]) ``` error case: ```LogicalProject(projects=[col_int_undef_signed2#50 AS `col_int_undef_signed`apache#30, cast(col_int_undef_signed#30 as DOUBLE) AS `cast(col_int_undef_signed as DOUBLE)`apache#70])``` correct: ``` LogicalProject(projects=[col_int_undef_signed#30, cast(col_int_undef_signed#30 as DOUBLE) AS `cast(col_int_undef_signed as DOUBLE)`apache#70]) LogicalProject(projects=[col_int_undef_signed2#50 AS `col_int_undef_signed`apache#30]) ```
16 tasks
englefly
added a commit
that referenced
this pull request
Nov 24, 2025
…bug (#58174) ### What problem does this PR solve? pr #57414 will generate error project: LogicalProject(a as b, b as c), in which 'b as c' is not correct, because 'b' is not in output of project.child() pr #57804 fixed above issue, but made another issue, that is when the bottom project is not resued in result plan, some aliases definitions are lost.
nagisa-kunhah
pushed a commit
to nagisa-kunhah/doris
that referenced
this pull request
Dec 14, 2025
…bug (apache#58174) ### What problem does this PR solve? pr apache#57414 will generate error project: LogicalProject(a as b, b as c), in which 'b as c' is not correct, because 'b' is not in output of project.child() pr apache#57804 fixed above issue, but made another issue, that is when the bottom project is not resued in result plan, some aliases definitions are lost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when push alias into child node, we should always create a new project node for it.
input:
error case:
LogicalProject(projects=[col_int_undef_signed2#50 AS `col_int_undef_signed`#30, cast(col_int_undef_signed#30 as DOUBLE) AS `cast(col_int_undef_signed as DOUBLE)`#70])correct:
Issue Number: close #xxx
Related PR: (#57414)
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)