[MemTracker] Make some MemTracker have reasonable parent MemTracker to eazily to trace. Add show level of MemTracker #5783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HappenLee
changed the title
HappenLee
changed the title
HappenLee
changed the title
morningman
reviewed
May 18, 2021
be/src/common/config.h
Outdated
| // Trace = 6 | ||
| CONF_Int32(aws_log_level, "3"); | ||
|
|
||
| // default level of MemTracker to show in webpage |
Contributor
There was a problem hiding this comment.
Explain whether this value is higher and more detailed or lower and more detailed.
| _keys_type(keys_type), | ||
| _row_comparator(_schema), | ||
| _mem_tracker(MemTracker::CreateTracker(-1, "MemTable:" + std::to_string(tablet_id), parent_tracker)), | ||
| _mem_tracker(MemTracker::CreateTracker(-1, "MemTable", parent_tracker)), |
Contributor
Author
There was a problem hiding this comment.
Beacause the tracker will use the parent label id
| const std::shared_ptr<MemTracker>& mem_tracker) | ||
| : _key(key), _state(kInitialized), _closed_senders(64) { | ||
| _mem_tracker = MemTracker::CreateTracker(-1, "TabletsChannel:" + key.to_string(), mem_tracker); | ||
| _mem_tracker = MemTracker::CreateTracker(-1, "TabletsChannel", mem_tracker); |
1 Make some MemTracker have reasonable parent MemTracker not the root tracker 2 Make each MemTracker can be eazily to trace. 3 Add show level of MemTracker to reduce the MemTracker show in the web page to have a way to control show how many tracker in web page.
morningman
added
approved
stdpain
pushed a commit
to stdpain/incubator-doris
that referenced
this pull request
Jul 8, 2021
1 Make some MemTracker have reasonable parent MemTracker not the root tracker 2 Make each MemTracker can be easily to trace. 3 Add show level of MemTracker to reduce the MemTracker show in the web page to have a way to control show how many tracker in web page.
w41ter
pushed a commit
to w41ter/incubator-doris
that referenced
this pull request
Dec 26, 2025
…niform when group sets exist apache#56942 (apache#5783) pr: apache#56942 commitId: a5e4e1c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 Make some MemTracker have reasonable parent MemTracker not the root tracker
2 Make each MemTracker can be eazily to trace.
3 Add show level of MemTracker to reduce the MemTracker show in the web page to have a way to control show how many tracker in web page.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.