Skip to content

branch-3.1: [Feature](func) Support function mmh64_v2 (#57180) #57879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
linrrzqqq wants to merge 1 commit into from
Closed

branch-3.1: [Feature](func) Support function mmh64_v2 (#57180) #57879

linrrzqqq wants to merge 1 commit into from

Conversation

@linrrzqqq
Copy link
Contributor

@linrrzqqq linrrzqqq commented Nov 10, 2025

pick: #57180

@linrrzqqq linrrzqqq requested a review from morrySnow as a code owner November 10, 2025 18:22
@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 10, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@linrrzqqq
Copy link
Contributor Author

linrrzqqq commented Nov 10, 2025

run buildall

@linrrzqqq linrrzqqq force-pushed the pick_57180_branch_3.1 branch 4 times, most recently from c48e5a9 to 0f5db6e Compare November 11, 2025 10:37
@linrrzqqq
Copy link
Contributor Author

linrrzqqq commented Nov 11, 2025

run buildall

@linrrzqqq
[Feature](func) Support function mmh64_v2 (apache#57180)
de65fe4 
1. alias `xxhash3_64` for `xxhash_64`

2. Support function `murmur_hash3_64_v2`
Before:
```text
mysql> SELECT MURMUR_HASH3_64('1000209601_1756808272');
+------------------------------------------+
| MURMUR_HASH3_64('1000209601_1756808272') |
+------------------------------------------+
|                      1680830166030441144 |
+------------------------------------------+
```
This result differs from the return value of directly calling
mmh3.hash64 in other languages, because external APIs all use mmh3_128
for calculation and then truncate the first 64 bits. The 64-bit version
inside Doris compared to the 128-bit version lacks an h2 register (the
64-bit version only has h1), which will affect the final mixing
calculation of h1 and h2 in the algorithm, leading to issues in the
result.

After support:
```text
mysql> SELECT MURMUR_HASH3_64_V2('1000209601_1756808272');
+---------------------------------------------+
| MURMUR_HASH3_64_V2('1000209601_1756808272') |
+---------------------------------------------+
|                         4038800892574899471 |
+---------------------------------------------+
```

The result now is completely the same as the API call.
@linrrzqqq linrrzqqq force-pushed the pick_57180_branch_3.1 branch from 0f5db6e to de65fe4 Compare November 11, 2025 14:38
@linrrzqqq
Copy link
Contributor Author

linrrzqqq commented Nov 11, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Nov 11, 2025

BE UT Coverage Report

Increment line coverage 95.74% (45/47) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.89% (12957/28237)
Line Coverage 36.74% (115948/315598)
Region Coverage 34.24% (66091/193038)
Branch Coverage 31.26% (34705/111028)

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 11, 2025

BE Regression && UT Coverage Report

Increment line coverage 93.10% (27/29) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.35% (21234/27813)
Line Coverage 69.62% (219738/315635)
Region Coverage 67.55% (131118/194103)
Branch Coverage 61.17% (68301/111656)

@morrySnow morrySnow marked this pull request as draft November 19, 2025 06:46
@morrySnow morrySnow closed this Nov 27, 2025
@linrrzqqq linrrzqqq deleted the pick_57180_branch_3.1 branch January 22, 2026 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow Awaiting requested review from morrySnow morrySnow is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@linrrzqqq @hello-stephen @doris-robot @morrySnow