Skip to content

branch-4.0: [fix](memtable) add check when memtable init aggregate function to avoid core dump #57934 #57969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Nov 13, 2025
Merged

branch-4.0: [fix](memtable) add check when memtable init aggregate function to avoid core dump #57934 #57969

yiguolei merged 1 commit into from
Nov 13, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 12, 2025

Cherry-picked from #57934

@sollhui
[fix](memtable) add check when memtable init aggregate function to av…
f0704cc 
…oid core dump (#57934)

### What problem does this PR solve?

Sometimes planner will plan error and cause `slot_desc` less than
`_num_columns` and cause be core dump, this pr add check when memtable
init aggregate function to avoid core dump.

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions github-actions bot requested a review from yiguolei as a code owner November 12, 2025 18:56
@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 12, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Nov 12, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 12, 2025

run buildall

@yiguolei yiguolei merged commit e15512d into branch-4.0 Nov 13, 2025
24 of 27 checks passed
@github-actions github-actions bot deleted the auto-pick-57934-branch-4.0 branch November 13, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hello-stephen @yiguolei @dataroaring @sollhui