Skip to content

[fix](fe-ut) Fix FE-UT RewriteDataFilePlannerTest#57971

Merged
hello-stephen merged 1 commit intoapache:masterfrom
suxiaogang223:fix_rewrite_planner_test
Nov 13, 2025
Merged

[fix](fe-ut) Fix FE-UT RewriteDataFilePlannerTest#57971
hello-stephen merged 1 commit intoapache:masterfrom
suxiaogang223:fix_rewrite_planner_test

Conversation

@suxiaogang223
Copy link
Contributor

@suxiaogang223 suxiaogang223 commented Nov 13, 2025 •
edited
Loading

What problem does this PR solve?

Related PR: #56413

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Nov 13, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@suxiaogang223 suxiaogang223 force-pushed the fix_rewrite_planner_test branch from a15d1c4 to 818187f Compare November 13, 2025 02:30
@suxiaogang223
Copy link
Contributor Author

suxiaogang223 commented Nov 13, 2025

run fe-ut

@suxiaogang223
Copy link
Contributor Author

suxiaogang223 commented Nov 13, 2025

run compile

@suxiaogang223 suxiaogang223 force-pushed the fix_rewrite_planner_test branch from 818187f to eb01232 Compare November 13, 2025 02:33
@suxiaogang223 suxiaogang223 force-pushed the fix_rewrite_planner_test branch from eb01232 to 0a6708f Compare November 13, 2025 02:34
@suxiaogang223
Copy link
Contributor Author

suxiaogang223 commented Nov 13, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Nov 13, 2025

TPC-H: Total hot run time: 36021 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0a6708fce90f980641c9bd5555f0c6ba094246eb, data reload: false

------ Round 1 ----------------------------------
q1	17587	5287	5054	5054
q2	2039	308	214	214
q3	10248	1266	719	719
q4	10243	959	389	389
q5	7529	2401	2378	2378
q6	190	178	146	146
q7	938	784	653	653
q8	9371	1389	1139	1139
q9	6858	5151	5267	5151
q10	6879	2239	1858	1858
q11	497	311	285	285
q12	347	382	240	240
q13	17895	3687	3018	3018
q14	229	234	220	220
q15	604	520	535	520
q16	1082	1015	968	968
q17	612	906	388	388
q18	7608	7559	7564	7559
q19	1584	1015	569	569
q20	376	349	240	240
q21	4419	3441	3256	3256
q22	1138	1100	1057	1057
Total cold run time: 108273 ms
Total hot run time: 36021 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5432	5475	5368	5368
q2	266	334	232	232
q3	2451	2933	2462	2462
q4	1430	1872	1400	1400
q5	4557	4485	4453	4453
q6	208	163	136	136
q7	1978	1910	2028	1910
q8	2581	2588	2494	2494
q9	7422	7523	7235	7235
q10	2910	3139	2695	2695
q11	580	511	496	496
q12	623	730	563	563
q13	3224	3656	3238	3238
q14	262	287	272	272
q15	549	502	479	479
q16	1012	1072	983	983
q17	1108	1464	1371	1371
q18	7332	7118	7133	7118
q19	766	822	901	822
q20	1904	1959	1818	1818
q21	4787	4453	4294	4294
q22	1086	1046	1022	1022
Total cold run time: 52468 ms
Total hot run time: 50861 ms

@doris-robot
Copy link

doris-robot commented Nov 13, 2025

TPC-DS: Total hot run time: 186065 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0a6708fce90f980641c9bd5555f0c6ba094246eb, data reload: false

query1	1036	406	397	397
query2	6559	1659	1660	1659
query3	6766	233	229	229
query4	26333	23728	23361	23361
query5	4413	637	468	468
query6	349	248	236	236
query7	4645	506	301	301
query8	325	281	260	260
query9	8716	2625	2624	2624
query10	506	352	296	296
query11	15378	15071	14841	14841
query12	174	124	115	115
query13	1697	559	473	473
query14	10809	9341	9197	9197
query15	196	185	168	168
query16	7714	671	541	541
query17	1220	755	611	611
query18	2027	415	320	320
query19	210	199	176	176
query20	133	122	126	122
query21	215	138	113	113
query22	3957	4223	3865	3865
query23	33711	33015	32985	32985
query24	8440	2421	2435	2421
query25	591	517	441	441
query26	1236	274	161	161
query27	2744	486	347	347
query28	4363	2207	2182	2182
query29	800	609	520	520
query30	303	228	206	206
query31	888	799	715	715
query32	90	78	86	78
query33	614	393	335	335
query34	807	847	546	546
query35	806	859	775	775
query36	969	1003	902	902
query37	122	110	90	90
query38	3603	3599	3540	3540
query39	1495	1453	1429	1429
query40	228	134	126	126
query41	68	66	66	66
query42	127	120	118	118
query43	481	499	483	483
query44	1241	753	757	753
query45	190	188	175	175
query46	884	1025	648	648
query47	1743	1771	1715	1715
query48	396	425	318	318
query49	787	525	437	437
query50	648	691	404	404
query51	3943	3963	3969	3963
query52	115	117	109	109
query53	245	280	213	213
query54	308	303	279	279
query55	93	84	83	83
query56	314	328	324	324
query57	1200	1189	1121	1121
query58	284	274	280	274
query59	2555	2653	2537	2537
query60	333	345	333	333
query61	160	151	161	151
query62	795	724	657	657
query63	225	191	201	191
query64	4452	1148	853	853
query65	4034	3969	3987	3969
query66	1113	427	343	343
query67	15633	15185	14909	14909
query68	6297	882	592	592
query69	513	328	293	293
query70	1305	1343	1314	1314
query71	426	343	319	319
query72	5816	2613	5335	2613
query73	750	768	375	375
query74	9110	9060	9006	9006
query75	3276	3367	2822	2822
query76	3345	1152	795	795
query77	524	418	317	317
query78	9545	9864	8913	8913
query79	1039	836	588	588
query80	1343	585	508	508
query81	541	268	233	233
query82	419	160	133	133
query83	273	269	250	250
query84	254	120	91	91
query85	889	493	436	436
query86	341	328	296	296
query87	3811	3715	3632	3632
query88	2954	2317	2276	2276
query89	385	357	296	296
query90	1731	231	232	231
query91	172	165	137	137
query92	69	69	65	65
query93	1135	985	648	648
query94	708	424	320	320
query95	440	336	318	318
query96	498	585	290	290
query97	2903	2970	2876	2876
query98	237	215	209	209
query99	1327	1388	1275	1275
Total cold run time: 269931 ms
Total hot run time: 186065 ms

@doris-robot
Copy link

doris-robot commented Nov 13, 2025

ClickBench: Total hot run time: 27.58 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0a6708fce90f980641c9bd5555f0c6ba094246eb, data reload: false

query1	0.06	0.04	0.05
query2	0.09	0.04	0.05
query3	0.27	0.08	0.08
query4	1.60	0.11	0.11
query5	0.27	0.24	0.26
query6	1.17	0.65	0.65
query7	0.03	0.02	0.02
query8	0.05	0.04	0.05
query9	0.58	0.52	0.51
query10	0.58	0.57	0.57
query11	0.17	0.11	0.11
query12	0.15	0.13	0.12
query13	0.62	0.60	0.61
query14	1.02	1.01	0.99
query15	0.85	0.84	0.83
query16	0.39	0.40	0.38
query17	1.03	1.02	1.00
query18	0.21	0.20	0.20
query19	1.92	1.76	1.76
query20	0.02	0.02	0.02
query21	15.41	0.20	0.13
query22	4.97	0.06	0.04
query23	15.65	0.25	0.10
query24	2.99	0.57	2.12
query25	0.09	0.08	0.07
query26	0.14	0.12	0.14
query27	0.07	0.05	0.05
query28	6.44	1.13	0.94
query29	12.58	3.84	3.22
query30	0.28	0.14	0.11
query31	2.84	0.58	0.39
query32	3.23	0.56	0.49
query33	3.04	3.08	3.01
query34	15.80	5.17	4.58
query35	4.56	4.65	4.59
query36	0.66	0.51	0.49
query37	0.10	0.07	0.07
query38	0.07	0.04	0.04
query39	0.04	0.03	0.03
query40	0.18	0.15	0.15
query41	0.09	0.04	0.03
query42	0.04	0.03	0.02
query43	0.05	0.03	0.03
Total cold run time: 100.4 s
Total hot run time: 27.58 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025

PR approved by anyone and no changes requested.

MoanasDaddyXu
MoanasDaddyXu approved these changes Nov 13, 2025
View reviewed changes
Copy link
Contributor

@MoanasDaddyXu MoanasDaddyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 13, 2025

skip buildall

@hello-stephen hello-stephen merged commit 5d4f6d7 into apache:master Nov 13, 2025
29 of 30 checks passed
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Nov 13, 2025
@suxiaogang223 @wyxxxcat
[fix](fe-ut) Fix FE-UT RewriteDataFilePlannerTest (apache#57971)
2595ae5
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Nov 18, 2025
@suxiaogang223 @wyxxxcat
[fix](fe-ut) Fix FE-UT RewriteDataFilePlannerTest (apache#57971)
0c69b13
@suxiaogang223 suxiaogang223 deleted the fix_rewrite_planner_test branch December 5, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hello-stephen hello-stephen hello-stephen approved these changes

+1 more reviewer

@MoanasDaddyXu MoanasDaddyXu MoanasDaddyXu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@suxiaogang223 @Thearas @doris-robot @hello-stephen @MoanasDaddyXu