-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[fix](cloud) avoid broadcast remote read in topn query #58044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](cloud) avoid broadcast remote read in topn query #58044
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
Pls add a test to avoid duplicated bug in the future. |
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
deardeng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TPC-H: Total hot run time: 34264 ms |
TPC-DS: Total hot run time: 188559 ms |
ClickBench: Total hot run time: 27.65 s |
Topn lazy read only read the cache in cloud mode to reduce tablet cache read. fix apache#50803 failed to pass force_use_only_cached to tablet_mgr Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
25b4af0 to
2bcdb0d
Compare
|
run buildall |
eldenmoon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
TPC-H: Total hot run time: 34772 ms |
|
run buildall |
HappenLee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
e89d0c1
0ea8708 to
e89d0c1
Compare
TPC-H: Total hot run time: 34098 ms |
|
run buildall |
TPC-H: Total hot run time: 34234 ms |
TPC-DS: Total hot run time: 188773 ms |
ClickBench: Total hot run time: 27.5 s |
|
run buildall |
TPC-H: Total hot run time: 34021 ms |
TPC-DS: Total hot run time: 188427 ms |
ClickBench: Total hot run time: 27.8 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
PR approved by at least one committer and no changes requested. |
Topn lazy read only read the cache in cloud mode to reduce tablet cache read. fix #50803 failed to pass force_use_only_cached to tablet_mgr Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Topn lazy read only read the cache in cloud mode to reduce tablet cache read. fix #50803 failed to pass force_use_only_cached to tablet_mgr Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Topn lazy read only read the cache in cloud mode to reduce tablet cache read. fix #50803 failed to pass force_use_only_cached to tablet_mgr
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)