Skip to content

branch-4.0: [fix](nereids) Fix aggregate source repeat output is different from child repeat #57840 #58088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Nov 18, 2025
Merged

branch-4.0: [fix](nereids) Fix aggregate source repeat output is different from child repeat #57840 #58088

yiguolei merged 1 commit into from
Nov 18, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 17, 2025

Cherry-picked from #57840

@seawinde
[fix](nereids) Fix aggregate source repeat output is different from c…
611e5b5 
…hild repeat (#57840)

if cte def has group sets, after cte inline, the aggregate source repeat
output is different from child repeat
the pr fix this

such query as following
```sql
            with t as (
                select t1.l_partkey, t1.l_suppkey, o_orderdate,
                grouping(t1.l_suppkey),
                grouping(o_orderdate),
                grouping_id(t1.l_partkey, t1.l_suppkey),
                grouping_id(t1.l_partkey, t1.l_suppkey, o_orderdate),
                sum(o_totalprice),
                max(o_totalprice),
                min(o_totalprice),
                count(*),
                count(distinct case when o_shippriority > 1 and o_orderkey IN (1, 3) then o_custkey else null end)
                from (select * from lineitem where l_shipdate = '2023-12-11') t1
                left join orders on t1.l_orderkey = orders.o_orderkey and t1.l_shipdate = o_orderdate
                group by
                GROUPING SETS ((l_shipdate, o_orderdate, l_partkey), (l_partkey, l_suppkey), (l_suppkey), ())
            )
            select t1.l_suppkey, t2.o_orderdate
            from
            t t1
            inner join
            t t2 on t1.l_partkey = t2.l_partkey;
```
@github-actions github-actions bot requested a review from yiguolei as a code owner November 17, 2025 09:39
@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 17, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 17, 2025

run buildall

@yiguolei yiguolei closed this Nov 18, 2025
@yiguolei yiguolei reopened this Nov 18, 2025
@yiguolei yiguolei merged commit 74e1a1e into branch-4.0 Nov 18, 2025
25 of 27 checks passed
@github-actions github-actions bot deleted the auto-pick-57840-branch-4.0 branch November 18, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hello-stephen @yiguolei @seawinde