-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](nereids)fix pushdownLimit/topnThroughJoin dead loop #58305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
run buildall |
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
TPC-H: Total hot run time: 35057 ms |
TPC-DS: Total hot run time: 187349 ms |
ClickBench: Total hot run time: 28.33 s |
morrySnow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add ut and regression test
FE UT Coverage ReportIncrement line coverage |
FE Regression Coverage ReportIncrement line coverage |
|
run p0 |
|
run nonConcurrent |
FE Regression Coverage ReportIncrement line coverage |
3ba8b62 to
cf5b09a
Compare
|
run buildall |
3918932 to
f5179e7
Compare
|
run buildall |
seawinde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 34303 ms |
TPC-DS: Total hot run time: 182726 ms |
ClickBench: Total hot run time: 27.38 s |
FE Regression Coverage ReportIncrement line coverage |
|
PR approved by at least one committer and no changes requested. |
- PushDownTopNThroughJoin - PushDownLimitDistinctThroughJoin - PushDownTopNDistinctThroughJoin in pr#46773, we made above rules both applicable to RBO and CBO. In order to avoid dead loop, we have checked rewritten plan. But the check condition is not suitable to CBO. This leads optimizor apply these rules until group expression count reach memo_max_group_expression_size
- PushDownTopNThroughJoin - PushDownLimitDistinctThroughJoin - PushDownTopNDistinctThroughJoin in pr#46773, we made above rules both applicable to RBO and CBO. In order to avoid dead loop, we have checked rewritten plan. But the check condition is not suitable to CBO. This leads optimizor apply these rules until group expression count reach memo_max_group_expression_size
- PushDownTopNThroughJoin - PushDownLimitDistinctThroughJoin - PushDownTopNDistinctThroughJoin in pr#46773, we made above rules both applicable to RBO and CBO. In order to avoid dead loop, we have checked rewritten plan. But the check condition is not suitable to CBO. This leads optimizor apply these rules until group expression count reach memo_max_group_expression_size
What problem does this PR solve?
PushDownTopNThroughJoin
PushDownLimitDistinctThroughJoin
PushDownTopNDistinctThroughJoin
in pr #46773, we made above rules both applicable to RBO and CBO. In order to avoid dead loop, we have checked rewritten plan. But the check condition is not suitable to CBO. This leads optimizor apply these rules until group expression count reach memo_max_group_expression_size
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)