Skip to content

branch-3.1: [improve](glue)Enforce HTTPS protocol for Glue endpoint #58306 #58366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Nov 26, 2025
Merged

branch-3.1: [improve](glue)Enforce HTTPS protocol for Glue endpoint #58306 #58366

morrySnow merged 1 commit into from
Nov 26, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 25, 2025

Cherry-picked from #58306

@CalvinKirs
[improve](glue)Enforce HTTPS protocol for Glue endpoint (#58306)
54b9270 
FYI https://docs.aws.amazon.com/general/latest/gr/glue.html

This PR adds a validation to ensure that the Glue endpoint uses the
HTTPS protocol.

- Adds a check for Glue endpoint URLs.
- Throws an IllegalArgumentException if the endpoint does not start with
"https://".
- Error message: "glue.endpoint must use https protocol, please set
glue.endpoint to https://"


None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [x] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions github-actions bot requested a review from morrySnow as a code owner November 25, 2025 14:02
@Thearas
Copy link
Contributor

Thearas commented Nov 25, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Nov 25, 2025
@Thearas
Copy link
Contributor

Thearas commented Nov 25, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 25, 2025

FE UT Coverage Report

Increment line coverage 85.71% (6/7) 🎉
Increment coverage report
Complete coverage report

@morrySnow morrySnow merged commit b234bd0 into branch-3.1 Nov 26, 2025
22 of 23 checks passed
@github-actions github-actions bot deleted the auto-pick-58306-branch-3.1 branch November 26, 2025 02:50
@morrySnow morrySnow mentioned this pull request Dec 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Thearas @hello-stephen @morrySnow @dataroaring @CalvinKirs