Skip to content

[fix](parquet-reader) Fix read parquet footer is missing in FileReadBytes profile. #58383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Nov 28, 2025
Merged

[fix](parquet-reader) Fix read parquet footer is missing in FileReadBytes profile. #58383

morningman merged 1 commit into from
Nov 28, 2025

Conversation

@kaka11chen
Copy link
Contributor

@kaka11chen kaka11chen commented Nov 26, 2025

What problem does this PR solve?

Problem Summary:

Release note

Fix read parquet footer is missing in FileReadBytes profile.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 26, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@kaka11chen
Copy link
Contributor Author

kaka11chen commented Nov 26, 2025

run buildall

@kaka11chen kaka11chen force-pushed the fix_parquet_footer_missing_in_file_bytes branch from fac4567 to 3e84079 Compare November 26, 2025 04:08
@kaka11chen
Copy link
Contributor Author

kaka11chen commented Nov 26, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Nov 26, 2025

TPC-H: Total hot run time: 34489 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3e84079b8fdca245eb43130c33ac3e5df2d6c84c, data reload: false

------ Round 1 ----------------------------------
q1	17630	5070	4920	4920
q2	2000	323	209	209
q3	10252	1302	728	728
q4	10246	962	377	377
q5	7527	2428	2367	2367
q6	190	174	141	141
q7	945	788	660	660
q8	9382	1359	1138	1138
q9	7169	5396	5341	5341
q10	6870	2242	1813	1813
q11	501	308	293	293
q12	370	365	231	231
q13	17783	3653	3020	3020
q14	229	233	220	220
q15	581	508	517	508
q16	1044	1007	993	993
q17	593	876	360	360
q18	7843	7164	7098	7098
q19	1238	948	546	546
q20	340	337	229	229
q21	4125	3201	2324	2324
q22	1040	998	973	973
Total cold run time: 107898 ms
Total hot run time: 34489 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4988	4961	4945	4945
q2	329	407	315	315
q3	2151	2704	2246	2246
q4	1338	1776	1301	1301
q5	4213	4532	4506	4506
q6	213	173	129	129
q7	2065	1925	1869	1869
q8	2718	2540	2517	2517
q9	7611	7430	7471	7430
q10	3123	3248	2852	2852
q11	601	536	505	505
q12	897	783	584	584
q13	3422	3995	3276	3276
q14	291	320	291	291
q15	562	511	513	511
q16	1100	1119	1087	1087
q17	1185	1602	1383	1383
q18	7893	7824	7701	7701
q19	806	802	945	802
q20	2028	2008	1855	1855
q21	4733	4277	4218	4218
q22	1101	1031	1015	1015
Total cold run time: 53368 ms
Total hot run time: 51338 ms

@doris-robot
Copy link

doris-robot commented Nov 26, 2025

TPC-DS: Total hot run time: 184196 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3e84079b8fdca245eb43130c33ac3e5df2d6c84c, data reload: false

query1	1042	406	436	406
query2	6569	1597	1608	1597
query3	6763	224	219	219
query4	25263	22709	22769	22709
query5	4391	616	480	480
query6	348	270	231	231
query7	4639	492	294	294
query8	310	249	253	249
query9	8722	2596	2573	2573
query10	501	371	321	321
query11	15077	14798	14635	14635
query12	176	116	111	111
query13	1712	582	455	455
query14	10125	8924	8900	8900
query15	218	208	192	192
query16	7341	729	545	545
query17	1280	803	613	613
query18	1989	424	328	328
query19	202	195	171	171
query20	131	123	124	123
query21	217	139	117	117
query22	3906	4015	3862	3862
query23	32925	31998	32017	31998
query24	8408	2397	2393	2393
query25	635	505	441	441
query26	1227	270	161	161
query27	2765	496	355	355
query28	4388	2135	2120	2120
query29	816	612	531	531
query30	309	245	211	211
query31	832	703	627	627
query32	84	70	76	70
query33	600	374	331	331
query34	773	851	523	523
query35	796	845	776	776
query36	918	935	834	834
query37	119	107	88	88
query38	3330	3331	3273	3273
query39	1445	1403	1428	1403
query40	234	133	120	120
query41	67	63	63	63
query42	132	116	116	116
query43	461	472	455	455
query44	1231	755	756	755
query45	200	189	182	182
query46	891	1040	636	636
query47	1751	1736	1650	1650
query48	389	424	323	323
query49	785	497	407	407
query50	662	674	399	399
query51	3886	3990	3877	3877
query52	112	113	106	106
query53	248	267	196	196
query54	308	298	279	279
query55	86	87	84	84
query56	321	323	322	322
query57	1146	1163	1097	1097
query58	297	282	278	278
query59	2453	2577	2376	2376
query60	363	355	332	332
query61	183	170	160	160
query62	786	727	666	666
query63	227	190	192	190
query64	4590	1181	875	875
query65	4064	3955	3921	3921
query66	1178	449	324	324
query67	15127	15266	14861	14861
query68	5495	907	628	628
query69	525	334	303	303
query70	1278	1223	1264	1223
query71	416	335	311	311
query72	6013	4864	5169	4864
query73	658	589	371	371
query74	8537	8922	8466	8466
query75	3309	3331	2828	2828
query76	3265	1127	719	719
query77	517	471	319	319
query78	9363	9640	8862	8862
query79	2303	813	620	620
query80	709	583	478	478
query81	508	273	234	234
query82	206	158	134	134
query83	271	266	250	250
query84	264	115	100	100
query85	898	482	441	441
query86	374	302	303	302
query87	3446	3475	3456	3456
query88	3275	2242	2205	2205
query89	385	316	290	290
query90	2007	215	211	211
query91	175	180	142	142
query92	83	71	74	71
query93	2183	982	657	657
query94	714	452	344	344
query95	497	408	400	400
query96	498	564	273	273
query97	2864	2964	2870	2870
query98	244	226	223	223
query99	1308	1410	1285	1285
Total cold run time: 266058 ms
Total hot run time: 184196 ms

@doris-robot
Copy link

doris-robot commented Nov 26, 2025

ClickBench: Total hot run time: 27.34 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3e84079b8fdca245eb43130c33ac3e5df2d6c84c, data reload: false

query1	0.05	0.04	0.05
query2	0.09	0.05	0.05
query3	0.26	0.08	0.08
query4	1.61	0.12	0.11
query5	0.26	0.26	0.25
query6	1.17	0.65	0.65
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.58	0.52	0.52
query10	0.57	0.57	0.58
query11	0.15	0.11	0.12
query12	0.15	0.12	0.12
query13	0.62	0.60	0.62
query14	1.01	1.00	1.00
query15	0.84	0.83	0.85
query16	0.39	0.39	0.40
query17	1.05	1.02	1.01
query18	0.20	0.19	0.20
query19	1.94	1.85	1.83
query20	0.02	0.01	0.01
query21	15.44	0.17	0.12
query22	5.14	0.07	0.05
query23	15.65	0.27	0.10
query24	2.70	0.80	0.31
query25	0.07	0.07	0.06
query26	0.15	0.13	0.13
query27	0.06	0.06	0.05
query28	4.26	1.15	0.92
query29	12.55	3.93	3.26
query30	0.28	0.14	0.11
query31	2.82	0.59	0.40
query32	3.23	0.55	0.47
query33	3.03	3.07	3.09
query34	15.81	5.09	4.53
query35	4.52	4.50	4.57
query36	0.68	0.50	0.49
query37	0.09	0.07	0.07
query38	0.06	0.04	0.04
query39	0.03	0.02	0.02
query40	0.18	0.15	0.13
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 97.96 s
Total hot run time: 27.34 s

@doris-robot
Copy link

doris-robot commented Nov 26, 2025

BE UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.92% (18434/34833)
Line Coverage 38.40% (168512/438778)
Region Coverage 33.18% (130787/394139)
Branch Coverage 34.13% (56293/164938)

morningman
morningman approved these changes Nov 26, 2025
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 26, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.62% (24490/34194)
Line Coverage 58.13% (255171/438929)
Region Coverage 53.36% (213127/399436)
Branch Coverage 54.79% (90906/165931)

@morningman morningman merged commit 298e2fb into apache:master Nov 28, 2025
29 of 31 checks passed
@kaka11chen kaka11chen mentioned this pull request Dec 2, 2025
Merged
morrySnow pushed a commit that referenced this pull request Dec 2, 2025
@kaka11chen
branch-3.1: [fix](parquet-reader) Fix read parquet footer is missing …
6ce023a 
…in FileReadBytes profile. #58383 (#58593)

picked from #58383
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
@kaka11chen @nagisa-kunhah
[fix](parquet-reader) Fix read parquet footer is missing in FileReadB…
68bbbd0 
…ytes profile. (apache#58383)

Fix read parquet footer is missing in FileReadBytes profile.
@kaka11chen kaka11chen mentioned this pull request Jan 5, 2026
Merged
16 tasks
yiguolei pushed a commit that referenced this pull request Jan 7, 2026
@kaka11chen
[fix](parquet-reader) Fix read parquet footer is missing in FileReadB…
c05db7d 
…ytes profile. (#59571)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

Cherry-pick #58383

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

+1 more reviewer

@hubgeter hubgeter hubgeter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.x dev/3.1.4-merged dev/4.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@kaka11chen @hello-stephen @doris-robot @morningman @hubgeter @yiguolei @morrySnow